Bug#1036256: golang-github-pin-tftp: FTBFS in testing
On Mon, 18 Sep 2023 09:23:19 -0300 Thiago Andrade wrote: > I'm waiting for this upgrade. After I'll try to upgrade gobuster to > 3.6.0 version. Hello Thiago, the new package was uploaded and is now in unstable. However, after manually triggering the autopkgtests two times, I noticed that a test failed (2 times, on a different architecture each time, cf ppc64el and riscv64 logs at [1]). So it still looks like a test is flaky, or maybe there's a bug in the code. I pinged upstream to see if they can help [2]. Cheers, Arnaud -- [1] https://ci.debian.net/packages/g/golang-github-pin-tftp/ [2] https://github.com/pin/tftp/issues/87
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
Hi Arnaud Rebillout I'm waiting for this upgrade. After I'll try to upgrade gobuster to 3.6.0 version. Regards. Thanks a lot! On 18/09/2023 05:19, Arnaud Rebillout wrote: I tried to rebuild the package locally, works for me. Tried to run autopkgtests in GitLab CI: worked [1]. It hints at flaky tests indeed... I noticed that in Debian we package 2.2.0, however upstream is at version 3.0.0, with significant changes. We have only two reverse build-deps: gobuster and ignition. 1) gobuster already uses pin-tftp 3.0 2) ignition seems to use an older version of pin-tftp, but I could rebuild it with pin-tftp 3.0 successfully So I'm going to upload version 3.0 of pin-tftp, and I'll check if builds and autopkgtests succeed with this new version. -- [1]: https://gitlab.com/arnaudr/golang-github-pin-tftp/-/jobs/5108371487 -- ... ⢀⣴⠾⠻⢶⣦⠀ Thiago Andrade Marques ⣾⠁⢰⠒⠀⣿⡁ GPG: 4096R/F8CDB08B ⢿⡄⠘⠷⠚⠋⠀ GPG Fingerprint: 1D38 EE3C 624F 955C E1FA 3C85 5A30 3591 F8CD B08B ⠈⠳⣄
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
I tried to rebuild the package locally, works for me. Tried to run autopkgtests in GitLab CI: worked [1]. It hints at flaky tests indeed... I noticed that in Debian we package 2.2.0, however upstream is at version 3.0.0, with significant changes. We have only two reverse build-deps: gobuster and ignition. 1) gobuster already uses pin-tftp 3.0 2) ignition seems to use an older version of pin-tftp, but I could rebuild it with pin-tftp 3.0 successfully So I'm going to upload version 3.0 of pin-tftp, and I'll check if builds and autopkgtests succeed with this new version. -- [1]: https://gitlab.com/arnaudr/golang-github-pin-tftp/-/jobs/5108371487 -- Arnaud Rebillout / OffSec / Kali Linux Developer
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
On Mon, Jul 31, 2023 at 3:31 AM Thiago Andrade wrote: > > I tested this package on an amd64 PorterBox and the bug seems to have > been resolved by disabling two tests. > I've attached this diff, feel free to test it and upload it as soon as > possible. This doesn't make sense. Could you elaborate why these tests fail and should be skipped? Just disabling tests without explanation doesn't make this package less buggy. -- Shengjing Zhu
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
I tested this package on an amd64 PorterBox and the bug seems to have
been resolved by disabling two tests.
I've attached this diff, feel free to test it and upload it as soon as
possible.
Regards
--
...
⢀⣴⠾⠻⢶⣦⠀ Thiago Andrade Marques
⣾⠁⢰⠒⠀⣿⡁ GPG: 4096R/F8CDB08B
⢿⡄⠘⠷⠚⠋⠀ GPG Fingerprint: 1D38 EE3C 624F 955C E1FA 3C85 5A30 3591 F8CD B08B
⠈⠳⣄
diff -Nru golang-github-pin-tftp-2.2.0/debian/changelog golang-github-pin-tftp-2.2.0/debian/changelog
--- golang-github-pin-tftp-2.2.0/debian/changelog 2022-05-19 10:01:45.0 -0300
+++ golang-github-pin-tftp-2.2.0/debian/changelog 2023-07-30 16:12:59.0 -0300
@@ -1,3 +1,14 @@
+golang-github-pin-tftp (2.2.0-4) unstable; urgency=medium
+
+ * Team upload.
+
+ [ Thiago Andrade Marques ]
+ * debian/patches/single_port_test.go.patch: removed
+TestSendReceiveSinglePortWithBlockSize and
+TestServerReceiveTimeoutSinglePort. (Closes: #1036256)
+
+ -- Thiago Andrade Marques Sun, 30 Jul 2023 16:12:59 -0300
+
golang-github-pin-tftp (2.2.0-3) unstable; urgency=medium
* Team upload.
diff -Nru golang-github-pin-tftp-2.2.0/debian/patches/single_port_test.go.patch golang-github-pin-tftp-2.2.0/debian/patches/single_port_test.go.patch
--- golang-github-pin-tftp-2.2.0/debian/patches/single_port_test.go.patch 2022-05-19 09:48:59.0 -0300
+++ golang-github-pin-tftp-2.2.0/debian/patches/single_port_test.go.patch 2023-07-30 16:12:59.0 -0300
@@ -1,11 +1,17 @@
Subject: remove test that timeout during build
-
golang-github-pin-tftp-2.2.0/single_port_test.go
-+++ golang-github-pin-tftp-2.2.0/single_port_test.go
-@@ -10,14 +10,6 @@
+Author: Thiago Andrade Marques
+Last-Update: 2023-07-30
+Bug-Debian: http://bugs.debian.org/1036256
+===
+Index: golang-github-pin-tftp-2.2.0/single_port_test.go
+===
+--- golang-github-pin-tftp.orig/single_port_test.go
golang-github-pin-tftp/single_port_test.go
+@@ -9,30 +9,3 @@ func TestZeroLengthSinglePort(t *testing
+ defer s.Shutdown()
testSendReceive(t, c, 0)
}
-
+-
-func TestSendReceiveSinglePort(t *testing.T) {
- s, c := makeTestServer(true)
- defer s.Shutdown()
@@ -14,18 +20,21 @@
- }
-}
-
- func TestSendReceiveSinglePortWithBlockSize(t *testing.T) {
- s, c := makeTestServer(true)
- defer s.Shutdown()
-@@ -27,11 +19,6 @@
- }
- }
-
+-func TestSendReceiveSinglePortWithBlockSize(t *testing.T) {
+- s, c := makeTestServer(true)
+- defer s.Shutdown()
+- for i := 600; i < 1000; i++ {
+- c.blksize = i
+- testSendReceive(t, c, 5000+int64(i))
+- }
+-}
+-
-func TestServerSendTimeoutSinglePort(t *testing.T) {
- s, c := makeTestServer(true)
- serverTimeoutSendTest(s, c, t)
-}
-
- func TestServerReceiveTimeoutSinglePort(t *testing.T) {
- s, c := makeTestServer(true)
- serverReceiveTimeoutTest(s, c, t)
+-func TestServerReceiveTimeoutSinglePort(t *testing.T) {
+- s, c := makeTestServer(true)
+- serverReceiveTimeoutTest(s, c, t)
+-}
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
On Thu, Jun 01, 2023 at 05:55:07PM +0200, Paul Gevers wrote: >... > On Wed, 31 May 2023 08:31:25 -0300 Thiago Andrade > wrote: > > I've tested golang-github-pin-tftp locally and everything looks perfect. > > I looked at the results on the reproducible build infrastructure and the > package seems to regularly fail. This may hint that the tests are flaky. > Also autopkgtest is not without failure [2]. To fix a similar problem with TestSendReceiveSinglePort, #1008412 fixed by disabling it in debian/patches/single_port_test.go.patch. The next test after TestSendReceiveSinglePort is TestSendReceiveSinglePortWithBlockSize, and just looking at the name it doesn't surprising if it has the same problem. > Paul >... cu Adrian
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
Hi all, On Wed, 31 May 2023 08:31:25 -0300 Thiago Andrade wrote: I've tested golang-github-pin-tftp locally and everything looks perfect. I looked at the results on the reproducible build infrastructure and the package seems to regularly fail. This may hint that the tests are flaky. Also autopkgtest is not without failure [2]. Paul [1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-github-pin-tftp.html [2] https://ci.debian.net/packages/g/golang-github-pin-tftp/ OpenPGP_signature Description: OpenPGP digital signature
Bug#1036256: golang-github-pin-tftp: FTBFS in testing
Hey folks. This bug is affecting the gobuster package that I maintain. I've tested golang-github-pin-tftp locally and everything looks perfect. It looks like a false positive on the Build. If anyone can see this by July 1st, it will be important that these packages are not automatically removed from testing. Thank you all! -- ... ⢀⣴⠾⠻⢶⣦⠀ Thiago Andrade Marques ⣾⠁⢰⠒⠀⣿⡁ GPG: 4096R/F8CDB08B ⢿⡄⠘⠷⠚⠋⠀ GPG Fingerprint: 1D38 EE3C 624F 955C E1FA 3C85 5A30 3591 F8CD B08B ⠈⠳⣄
Bug#1036256: golang-github-pin-tftp: FTBFS in testing: dh_auto_test: error: cd _build && go test -vet=off -v -p 8 github.com/pin/tftp github.com/pin/tftp/netascii returned exit code 1
Source: golang-github-pin-tftp
Version: 2.2.0-3
Severity: serious
Justification: FTBFS
Tags: bookworm sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20230517 ftbfs-bookworm
Hi,
During a rebuild of all packages in testing (bookworm), your package failed
to build on amd64.
Relevant part (hopefully):
> debian/rules binary
> dh binary --builddirectory=_build --buildsystem=golang --with=golang
>dh_update_autotools_config -O--builddirectory=_build -O--buildsystem=golang
>dh_autoreconf -O--builddirectory=_build -O--buildsystem=golang
>dh_auto_configure -O--builddirectory=_build -O--buildsystem=golang
>dh_auto_build -O--builddirectory=_build -O--buildsystem=golang
> cd _build && go install -trimpath -v -p 8 github.com/pin/tftp
> github.com/pin/tftp/netascii
> internal/goarch
> internal/race
> internal/unsafeheader
> internal/goexperiment
> internal/goos
> internal/cpu
> runtime/internal/syscall
> sync/atomic
> runtime/internal/atomic
> runtime/internal/math
> internal/abi
> unicode
> runtime/internal/sys
> unicode/utf8
> math/bits
> internal/itoa
> golang.org/x/net/internal/iana
> internal/nettrace
> internal/bytealg
> math
> runtime
> internal/reflectlite
> sync
> internal/testlog
> internal/singleflight
> math/rand
> runtime/cgo
> errors
> sort
> internal/oserror
> internal/safefilepath
> io
> path
> vendor/golang.org/x/net/dns/dnsmessage
> strconv
> syscall
> github.com/pin/tftp/netascii
> bytes
> strings
> reflect
> internal/syscall/execenv
> internal/syscall/unix
> time
> context
> io/fs
> internal/poll
> os
> internal/fmtsort
> encoding/binary
> golang.org/x/sys/unix
> internal/godebug
> fmt
> internal/intern
> net/netip
> net
> golang.org/x/net/bpf
> golang.org/x/net/internal/socket
> golang.org/x/net/ipv4
> golang.org/x/net/ipv6
> github.com/pin/tftp
>dh_auto_test -O--builddirectory=_build -O--buildsystem=golang
> cd _build && go test -vet=off -v -p 8 github.com/pin/tftp
> github.com/pin/tftp/netascii
> === RUN TestZeroLengthSinglePort
> --- PASS: TestZeroLengthSinglePort (0.00s)
> === RUN TestSendReceiveSinglePortWithBlockSize
> panic: test timed out after 10m0s
>
> goroutine 1643 [running]:
> testing.(*M).startAlarm.func1()
> /usr/lib/go-1.19/src/testing/testing.go:2036 +0x8e
> created by time.goFunc
> /usr/lib/go-1.19/src/time/sleep.go:176 +0x32
>
> goroutine 1 [chan receive, 10 minutes]:
> testing.(*T).Run(0xc000107520, {0x6315de?, 0x4d8ce5?}, 0x6517c8)
> /usr/lib/go-1.19/src/testing/testing.go:1494 +0x37a
> testing.runTests.func1(0xc000117710?)
> /usr/lib/go-1.19/src/testing/testing.go:1846 +0x6e
> testing.tRunner(0xc000107520, 0xc000179cd8)
> /usr/lib/go-1.19/src/testing/testing.go:1446 +0x10b
> testing.runTests(0xc000133360?, {0x796d40, 0x1b, 0x1b}, {0x7fbf08f3ba68?,
> 0x40?, 0x7cb9a0?})
> /usr/lib/go-1.19/src/testing/testing.go:1844 +0x456
> testing.(*M).Run(0xc000133360)
> /usr/lib/go-1.19/src/testing/testing.go:1726 +0x5d9
> main.main()
> _testmain.go:99 +0x1aa
>
> goroutine 36 [chan send, 9 minutes]:
> github.com/pin/tftp.(*Server).Shutdown(0xcd8000)
> /<>/_build/src/github.com/pin/tftp/server.go:310 +0x65
> github.com/pin/tftp.TestSendReceiveSinglePortWithBlockSize(0xe?)
> /<>/_build/src/github.com/pin/tftp/single_port_test.go:20
> +0xa9
> testing.tRunner(0xc8a4e0, 0x6517c8)
> /usr/lib/go-1.19/src/testing/testing.go:1446 +0x10b
> created by testing.(*T).Run
> /usr/lib/go-1.19/src/testing/testing.go:1493 +0x35f
>
> goroutine 22 [chan receive, 10 minutes]:
> github.com/pin/tftp.(*Server).internalGC(0xc0001a6000)
> /<>/_build/src/github.com/pin/tftp/single_port.go:121 +0x70
> created by github.com/pin/tftp.(*Server).EnableSinglePort
> /<>/_build/src/github.com/pin/tftp/server.go:129 +0x185
>
> goroutine 38 [IO wait, 9 minutes]:
> internal/poll.runtime_pollWait(0x7fbee00cef68, 0x72)
> /usr/lib/go-1.19/src/runtime/netpoll.go:305 +0x89
> internal/poll.(*pollDesc).wait(0xca0180?, 0xc000b2d800?, 0x0)
> /usr/lib/go-1.19/src/internal/poll/fd_poll_runtime.go:84 +0x32
> internal/poll.(*pollDesc).waitRead(...)
> /usr/lib/go-1.19/src/internal/poll/fd_poll_runtime.go:89
> internal/poll.(*FD).RawRead(0xca0180, 0xc00099a1e0)
> /usr/lib/go-1.19/src/internal/poll/fd_unix.go:766 +0x145
> net.(*rawConn).Read(0xc00011a0a0, 0xc0004c4fa8?)
> /usr/lib/go-1.19/src/net/rawconn.go:43 +0x45
> golang.org/x/net/internal/socket.(*Conn).recvMsg(0xc000152380, 0xc000b2d800,
> 0x0)
>
> /<>/_build/src/golang.org/x/net/internal/socket/rawconn_msg.go:28
> +0x179
> golang.org/x/net/internal/socket.(*Conn).RecvMsg(...)
>
> /<>/_build/src/golang.org/x/net/internal/socket/socket.go:247
> golang.org/x/net/ipv6.(*payloadHandler).ReadFrom(0xc0001005b0, {0xc000372000,
> 0x7d4, 0x7d4})
> /<>/_build/src/golang.org/x/net/ipv6/payload_cmsg.go:32
> +0x3c5
> github.com/pin/tftp.(*Server).getPacket(0xcd8090?, {0xc000372000?,
>
