Bug#1036809: pre-unblock: reaver/1.6.6-1
On Sat, May 27, 2023 at 6:13 AM Sebastian Ramacher wrote: > Isthe new upstream release a bug fix only release? What's upstream's policy on > that? Looking through the emails, I think this went unanswered about being a bugfix release and the answer would be yes. Changelog upstream to 1.6.6: several improvements have been made: improved bruteforce mode using .wpc save files. automatic pixiewps pin retrieval and live injection in current session if pin is cracked before the timeout happens, experimental uptime command line switch -u lots of bugfixes and improvements New debian changelog now fixes bugs (and one is release critical) only and with NMU. reaver (1.6.6-0.1) unstable; urgency=high . * Non-maintainer upload. * New upstream version. * debian/watch: - Fix watch file is broken and generating errors. (Closes: #901595) - Change version of 3 to 4. * Fix segmentation fault. (Closes: #1036591) -- Cheers, Leandro Cunha
Bug#1036809: pre-unblock: reaver/1.6.6-1
Hi Sebastian, On Sat, May 27, 2023 at 11:33 AM Leandro Cunha wrote: > > Hi Sebastian, > > On Sat, May 27, 2023 at 6:13 AM Sebastian Ramacher > wrote: > > > > Control: tags -1 moreinfo > > > > Hi > > > > On 2023-05-26 15:00:34 -0300, Leandro Cunha wrote: > > > [ Other info ] > > > The package has been moved to the pkg-security-team as maintainer and > > > has changed the previous maintainer to uploader. Samuel agrees to > > > upload the package. > > > This request has the build log and debdiff attached. > > > It's available at debian-mentors in > > > https://mentors.debian.net/package/reaver. > > > > From the changelog: > > > > reaver (1.6.6-1) unstable; urgency=high > > . > >* Team upload. > >* New upstream version. (Closes: #1036591) > >* Several improvements have been made by upstream. > >* Fix debian/watch to get new versions: > > - Watch file is broken and generating errors. (Closes: #901595) > > - Bump version of 3 to 4. > >* debian/control: > > - Set Debian Security Tools Team (pkg-security-team) as maintainer. > > - Set Bartosz Fenski as uploader. > > - Change debhelper 9 to debhelper-compat and update version to 13, > >causes removal of debian/compat. > > - Bump Standards-Version to 4.6.2. > > - Add Vcs-Browser, Vcs-Git to Salsa and to pkg-security-team group. > > - Add Rules-Requires-Root: no. > >* Lintian reports fixes: > > - Include trailing whitespace removal. > >* debian/copyright: > > - Add myself contribution. > >* Add salsa-ci.yml. > >* debian/upstream/metadata: created. > > > > > > At least the debhelper compat level change is not acceptable at this > > stage. The other changes to debian/ add additional noise. Isthe new > > upstream release a bug fix only release? What's upstream's policy on > > that? > > > > Cheers > > > > -- > > Sebastian Ramacher I switched to an NMU focusing on closing the RC bug. And I dropped the changes in debian/ which included changes in debhelper. Now the changelog has changed. recover (1.6.6-0.1) unstable; urgency=high * Non-maintainer upload. * New upstream version. * debian/watch: - Fix watch file is broken and generating errors. (Closes: #901595) - Change version from 3 to 4. * Fix segmentation fault. (Closes: #1036591) Coming soon at https://mentors.debian.net/package/reaver. It's available at debian-mentors in https://mentors.debian.net/package/reaver. -- Cheers, Leandro Cunha
Bug#1036809: pre-unblock: reaver/1.6.6-1
Hi Sebastian, On Sat, May 27, 2023 at 6:13 AM Sebastian Ramacher wrote: > > Control: tags -1 moreinfo > > Hi > > On 2023-05-26 15:00:34 -0300, Leandro Cunha wrote: > > [ Other info ] > > The package has been moved to the pkg-security-team as maintainer and > > has changed the previous maintainer to uploader. Samuel agrees to > > upload the package. > > This request has the build log and debdiff attached. > > It's available at debian-mentors in > > https://mentors.debian.net/package/reaver. > > From the changelog: > > reaver (1.6.6-1) unstable; urgency=high > . >* Team upload. >* New upstream version. (Closes: #1036591) >* Several improvements have been made by upstream. >* Fix debian/watch to get new versions: > - Watch file is broken and generating errors. (Closes: #901595) > - Bump version of 3 to 4. >* debian/control: > - Set Debian Security Tools Team (pkg-security-team) as maintainer. > - Set Bartosz Fenski as uploader. > - Change debhelper 9 to debhelper-compat and update version to 13, >causes removal of debian/compat. > - Bump Standards-Version to 4.6.2. > - Add Vcs-Browser, Vcs-Git to Salsa and to pkg-security-team group. > - Add Rules-Requires-Root: no. >* Lintian reports fixes: > - Include trailing whitespace removal. >* debian/copyright: > - Add myself contribution. >* Add salsa-ci.yml. >* debian/upstream/metadata: created. > > > At least the debhelper compat level change is not acceptable at this > stage. The other changes to debian/ add additional noise. Isthe new > upstream release a bug fix only release? What's upstream's policy on > that? > > Cheers > > -- > Sebastian Ramacher The repository presents as abandonment, I say because the last commit was made more than 1 year ago and exists issues and pull requests waiting for reply. The changes inserted in /debian, starting with the debhelper change, would be an update because it was using an obsolete one (it was version 9) and other corrections like /debian/watch makes corrections for errors. Other changes were reported by Lintian, which reduced the number of warnings and improved the situation of the package it was in. The last update was 5 years ago and upstream has not released new versions for 3 years (this being the last one). Having two options: the removal that I suggest of the package in bookworm (since it is not possible to use it in the state it is) can be included in backports later or I release this newer version (focusing on bug fixing) on top of an obsolete debhelper version that I didn't find it correct. But I can make this change which is the second option, it just won't be cool using the obsolete debhelper version and I can still do that today. -- Cheers, Leandro Cunha
Bug#1036809: pre-unblock: reaver/1.6.6-1
Control: tags -1 moreinfo Hi On 2023-05-26 15:00:34 -0300, Leandro Cunha wrote: > [ Other info ] > The package has been moved to the pkg-security-team as maintainer and > has changed the previous maintainer to uploader. Samuel agrees to > upload the package. > This request has the build log and debdiff attached. > It's available at debian-mentors in https://mentors.debian.net/package/reaver. >From the changelog: reaver (1.6.6-1) unstable; urgency=high . * Team upload. * New upstream version. (Closes: #1036591) * Several improvements have been made by upstream. * Fix debian/watch to get new versions: - Watch file is broken and generating errors. (Closes: #901595) - Bump version of 3 to 4. * debian/control: - Set Debian Security Tools Team (pkg-security-team) as maintainer. - Set Bartosz Fenski as uploader. - Change debhelper 9 to debhelper-compat and update version to 13, causes removal of debian/compat. - Bump Standards-Version to 4.6.2. - Add Vcs-Browser, Vcs-Git to Salsa and to pkg-security-team group. - Add Rules-Requires-Root: no. * Lintian reports fixes: - Include trailing whitespace removal. * debian/copyright: - Add myself contribution. * Add salsa-ci.yml. * debian/upstream/metadata: created. At least the debhelper compat level change is not acceptable at this stage. The other changes to debian/ add additional noise. Isthe new upstream release a bug fix only release? What's upstream's policy on that? Cheers -- Sebastian Ramacher
