Bug#1038025: Bug#985183: aranym: Switch from SDL1 to SDL2

[John Paul Adrian Glaubitz]

Hello Simon!

On Sun, 2023-06-25 at 15:48 +0100, Simon McVittie wrote:
> On closer inspection, the upstream default is SDL 2, so if libsdl2-dev
> happens to be installed then aranym will already accidentally switch
> from SDL 1.2 to SDL 2, even with the current unmodified Debian packaging.

According to one of the upstream developers, Aranym's SDL-2 support doesn't
seem to be very mature. Apparently, there are problems here and there [1].

> I'm intending to make the -dev package for sdl12-compat depend on
> libsdl2-dev as a workaround for legacy SDL-dependent packages that
> don't declare their build-dependencies explicitly, so when sdl12-compat
> takes over the libsdl1.2-dev binary package name, aranym is going to
> end up using SDL 2 in practice unless you explicitly configure with
> --disable-sdl2 (please do that if you are aware of reasons why the SDL
> 2 code paths are broken).

OK, thanks for the heads-up.

> aranym seems to compile fine in that configuration. I don't know what
> Atari ROMs or other software (if any) it might need, so I haven't
> attempted to test the resulting binaries.

That should definitely be properly tested. We don't gain anything if a
package builds find but doesn't work well for most users.

Adrian

> [1] https://github.com/aranym/aranym/issues/103#issuecomment-1593666173

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#1038025: Bug#985183: aranym: Switch from SDL1 to SDL2

[Simon McVittie]

On Sun, 14 Mar 2021 at 04:26:19 +0100, Guillem Jover wrote:
> This package is currently built against SDL 1.2, which is considered
> deprecated by upstream who recommend using instead SDL 2.0. The latter
> also supports Wayland natively.
> 
> It seems like this package can be built with both, so it would be nice
> to switch.

When I opened #1038025 asking for a port to SDL 2, I wasn't aware that
aranym has already supported SDL 2 since 2014 according to its changelog.

On closer inspection, the upstream default is SDL 2, so if libsdl2-dev
happens to be installed then aranym will already accidentally switch
from SDL 1.2 to SDL 2, even with the current unmodified Debian packaging.

I'm intending to make the -dev package for sdl12-compat depend on
libsdl2-dev as a workaround for legacy SDL-dependent packages that
don't declare their build-dependencies explicitly, so when sdl12-compat
takes over the libsdl1.2-dev binary package name, aranym is going to
end up using SDL 2 in practice unless you explicitly configure with
--disable-sdl2 (please do that if you are aware of reasons why the SDL
2 code paths are broken).

aranym seems to compile fine in that configuration. I don't know what
Atari ROMs or other software (if any) it might need, so I haven't
attempted to test the resulting binaries.

smcv