Bug#1038902: docker.io: FTBFS skip btrfs

2023-06-23 Thread Shengjing Zhu
On Fri, Jun 23, 2023 at 4:51 PM Bastien Roucariès  wrote:
> To test create a btrfs filesystem and mount in on your schroot root or 
> pbuilder root.
>

That's far from what I can do. Setting up a non normal build system is
not something we can support.
And throwing non non-working patch and tagging the bug with patch is
not appreciated.

-- 
Shengjing Zhu



Bug#1038902: docker.io: FTBFS skip btrfs

2023-06-23 Thread Bastien Roucariès
Le vendredi 23 juin 2023, 08:42:54 UTC Shengjing Zhu a écrit :
> Control: severity -1 wishlist
> Control: tags -1 patch
> 
> On Fri, Jun 23, 2023 at 5:33 AM Bastien Roucariès  wrote:
> >
> > Source: docker.io
> > Severity: serious
> > Tags: ftbfs
> > control: tags -1 + patch
> > Justification: FTBFS
> >
> > Dear Maintainer,
> >
> > I had applied the following patch for compiling under btrfs for buster. 
> > Could
> > you refresh and apply for other version
> 
> The patch doesn't apply to the current version. Meanwhile it doesn't
> FTBFS on buildd.
> 
> 
buildd use by memory ext4. for debian but this an implementation detail.

salsaci may migrate to snapshot in order to have better bandwith, so it should 
be fixed

To test create a btrfs filesystem and mount in on your schroot root or pbuilder 
root.

Bastien


signature.asc
Description: This is a digitally signed message part.


Bug#1038902: docker.io: FTBFS skip btrfs

2023-06-23 Thread Shengjing Zhu
Control: tags -1 - patch

On Fri, Jun 23, 2023 at 4:42 PM Shengjing Zhu  wrote:
>
> Control: severity -1 wishlist
> Control: tags -1 patch
>

Fixing control command...

-- 
Shengjing Zhu



Bug#1038902: docker.io: FTBFS skip btrfs

2023-06-23 Thread Shengjing Zhu
Control: severity -1 wishlist
Control: tags -1 patch

On Fri, Jun 23, 2023 at 5:33 AM Bastien Roucariès  wrote:
>
> Source: docker.io
> Severity: serious
> Tags: ftbfs
> control: tags -1 + patch
> Justification: FTBFS
>
> Dear Maintainer,
>
> I had applied the following patch for compiling under btrfs for buster. Could
> you refresh and apply for other version

The patch doesn't apply to the current version. Meanwhile it doesn't
FTBFS on buildd.

-- 
Shengjing Zhu



Bug#1038902: docker.io: FTBFS skip btrfs

2023-06-22 Thread Bastien Roucariès
Source: docker.io
Severity: serious
Tags: ftbfs
control: tags -1 + patch
Justification: FTBFS

Dear Maintainer,

I had applied the following patch for compiling under btrfs for buster. Could
you refresh and apply for other version


BastienFrom: =?utf-8?q?Bastien_Roucari=C3=A8s?= 
Date: Thu, 22 Jun 2023 19:10:05 +
Subject: Skip btrfs test

Do not test btrfs it fail on pbuilder with btrfs filesystem (need root)

forwarded: not-needed
---
 containerd/snapshots/btrfs/btrfs_test.go  | 3 +++
 engine/daemon/graphdriver/btrfs/btrfs_test.go | 6 ++
 2 files changed, 9 insertions(+)

diff --git a/containerd/snapshots/btrfs/btrfs_test.go b/containerd/snapshots/btrfs/btrfs_test.go
index 6e51023..5f08713 100644
--- a/containerd/snapshots/btrfs/btrfs_test.go
+++ b/containerd/snapshots/btrfs/btrfs_test.go
@@ -38,6 +38,7 @@ import (
 
 func boltSnapshotter(t *testing.T) func(context.Context, string) (snapshots.Snapshotter, func() error, error) {
 	mkbtrfs, err := exec.LookPath("mkfs.btrfs")
+	t.Skip("DM - skipping privileged test")
 	if err != nil {
 		t.Skipf("could not find mkfs.btrfs: %v", err)
 	}
@@ -88,11 +89,13 @@ func boltSnapshotter(t *testing.T) func(context.Context, string) (snapshots.Snap
 
 func TestBtrfs(t *testing.T) {
 	testutil.RequiresRoot(t)
+	t.Skip("DM - skipping privileged test")
 	testsuite.SnapshotterSuite(t, "Btrfs", boltSnapshotter(t))
 }
 
 func TestBtrfsMounts(t *testing.T) {
 	testutil.RequiresRoot(t)
+	t.Skip("DM - skipping privileged test")
 	ctx := context.Background()
 
 	// create temporary directory for mount point
diff --git a/engine/daemon/graphdriver/btrfs/btrfs_test.go b/engine/daemon/graphdriver/btrfs/btrfs_test.go
index b70e93b..b13ca42 100644
--- a/engine/daemon/graphdriver/btrfs/btrfs_test.go
+++ b/engine/daemon/graphdriver/btrfs/btrfs_test.go
@@ -13,22 +13,27 @@ import (
 // This avoids creating a new driver for each test if all tests are run
 // Make sure to put new tests between TestBtrfsSetup and TestBtrfsTeardown
 func TestBtrfsSetup(t *testing.T) {
+	t.Skip("DM - skipping privileged test")
 	graphtest.GetDriver(t, "btrfs")
 }
 
 func TestBtrfsCreateEmpty(t *testing.T) {
+	t.Skip("DM - skipping privileged test")
 	graphtest.DriverTestCreateEmpty(t, "btrfs")
 }
 
 func TestBtrfsCreateBase(t *testing.T) {
+	t.Skip("DM - skipping privileged test")
 	graphtest.DriverTestCreateBase(t, "btrfs")
 }
 
 func TestBtrfsCreateSnap(t *testing.T) {
+	t.Skip("DM - skipping privileged test")
 	graphtest.DriverTestCreateSnap(t, "btrfs")
 }
 
 func TestBtrfsSubvolDelete(t *testing.T) {
+	t.Skip("DM - skipping privileged test")
 	d := graphtest.GetDriver(t, "btrfs")
 	if err := d.CreateReadWrite("test", "", nil); err != nil {
 		t.Fatal(err)
@@ -61,5 +66,6 @@ func TestBtrfsSubvolDelete(t *testing.T) {
 }
 
 func TestBtrfsTeardown(t *testing.T) {
+	t.Skip("DM - skipping privileged test")
 	graphtest.PutDriver(t)
 }


signature.asc
Description: This is a digitally signed message part.