Bug#1040252: [3dprinter-general] Bug#1040252: cura-engine FTBFS on some 32bit architectures

[Gregor Riepl]

Hi myon,

I've tested the patch both on amd64 and i686 (in a chroot) and pushed it 
to Salsa.


Could you upload cura-engine 5.0.0-4 when you have time?
Thank you very much!

Regards,
Gregor

Bug#1040252: cura-engine FTBFS on some 32bit architectures

[Gregor Riepl]

This is actually a bug in the test and not CuraEngine.

In tests/InfillTest.cpp:104, they format a size_t as %lld instead of 
%zu. %llu works as well, but it's not 100% correct with a 32-bit size_t.


Current upstream HEAD still has the bug, so I'm going to report it there 
as well: 
https://github.com/Ultimaker/CuraEngine/blob/main/tests/InfillTest.cpp#L103


Patch:

diff --git a/tests/InfillTest.cpp b/tests/InfillTest.cpp
index 23b083f5..6f39b708 100644
--- a/tests/InfillTest.cpp
+++ b/tests/InfillTest.cpp
@@ -100,7 +100,7 @@ namespace cura
 result_lines(result_lines),
 result_polygons(result_polygons)
 {
-name = 
makeName("InfillTestParameters_P%d_Z%d_C%d_L%lld__%lld", 
(int)params.pattern, (int)params.zig_zagify, 
(int)params.connect_polygons, params.line_distance, test_polygon_id);
+name = 
makeName("InfillTestParameters_P%d_Z%d_C%d_L%lld__%zu", 
(int)params.pattern, (int)params.zig_zagify, 
(int)params.connect_polygons, params.line_distance, test_polygon_id);

 }

 friend std::ostream& operator<<(std::ostream& os, const 
InfillTestParameters& params)

Bug#1040252: cura-engine FTBFS on some 32bit architectures

[Adrian Bunk]

Source: cura-engine
Version: 1:5.0.0-3
Severity: serious
Tags: ftbfs

https://buildd.debian.org/status/logs.php?pkg=cura-engine&ver=1%3A5.0.0-1
https://buildd.debian.org/status/logs.php?pkg=cura-engine&ver=1%3A5.0.0-3

...
5: 
5: [ FATAL ] /usr/include/gtest/internal/gtest-param-util.h:585:: Condition 
IsValidParamName(param_name) failed. Parameterized test name 
'InfillTestParameters_P2_Z0_C0_L350__-4294967296' is invalid, in 
./tests/InfillTest.cpp line 241
5: 
...
96% tests passed, 1 tests failed out of 26

Total Test time (real) =  10.85 sec

The following tests FAILED:
  5 - InfillTest (Subprocess aborted)
Errors while running CTest
make[1]: *** [Makefile:94: test] Error 8