Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
Hi Jochen,
Am Fri, Jul 07, 2023 at 12:04:29PM +0200 schrieb Jochen Sprickerhof:
>
> echo "SALSA_TOKEN=" >> ~/.devscripts
> echo 'SALSA_CI_CONFIG_PATH="recipes/debian.yml@salsa-ci-team/pipeline"' >>
> ~/.devscripts
> sudo apt install devscripts
> salsa update_safe --group science-team --all
Thanks for this code. The only problem is that the salsa command does
not work for everybody - specifically not for me, despite I'm using the
token which works for any other task on salsa (including creating new
repositories, pushing etc.) I simply get
$ salsa update_safe --group science-team --all
Error GETing
https://salsa.debian.org/api/v4/groups/science-team?with_custom_attributes=0_projects=0
(HTTP 401): Unauthorized {"error":"invalid_token","error_description":"Toke...
at /usr/share/perl5/Devscripts/Salsa.pm line 396.
I would love to get this working for me but previous attempts to sort
this out failed. I know it works for a couple of other DDs.
The other thing is the setting this for all might be slightly dangerous
since we have a couple of configured debian/salsa-ci.yml files in Debian
Med and Pkg R teams.
Kind regards
Andreas.
--
http://fam-tille.de
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
I'd say thanks for opening the bug entry, because I was not well aware of the latest best practices with using salsa ci, nor was I aware that it was possible to refer to a generic forge-wide pipeline. I'll try this on a bunch of packages to see how this works. As far as I can read, having d/salsa-ci.yml remains useful for packages that include customisations, like excluding unworkable test items, or running the pipeline against stable. But this should remain exceptional. Have a nice day, :) -- .''`. Étienne Mollier : :' : gpg: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da `. `' sent from /dev/pts/2, please excuse my verbosity `-on air: Ayreon - Intergalactic Space Crusaders signature.asc Description: PGP signature
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
* Andreas Tille [2023-07-07 11:24]: Thanks for your opinion about this. What I mean with de facto standard: We have about 2000 repositories configured to check debian/salsa-ci.yml. I have not yet found a way to set the according field via gitlab API to something else. If this is scriptable I'd happily remove debian/salsa-ci.yml. For the moment I state two votes against salsa-ci.yml. ;-) echo "SALSA_TOKEN=" >> ~/.devscripts echo 'SALSA_CI_CONFIG_PATH="recipes/debian.yml@salsa-ci-team/pipeline"' >> ~/.devscripts sudo apt install devscripts salsa update_safe --group science-team --all Cheers Jochen signature.asc Description: PGP signature
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
Hi Andreas, Le ven. 7 juil. 2023 à 11:24, Andreas Tille a écrit : > > Thanks for your opinion about this. What I mean with de facto standard: We > have about 2000 repositories configured to check debian/salsa-ci.yml. I have > not yet found a way to set the according field via gitlab API to something > else. If this is scriptable I'd happily remove debian/salsa-ci.yml. For the > moment I state two votes against salsa-ci.yml. ;-) > We have a tool in Debian for that gitlab-rulez [1]. I haven't tried it on salsa yet, but it should work as we use it with our gitlab instance. Best regards, Dylan [1] https://tracker.debian.org/pkg/gitlab-rulez
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
Hi Jochen, Am Fri, Jul 07, 2023 at 09:48:45AM +0200 schrieb Jochen Sprickerhof: > > I confirm routine-update is going beyond the recommendation but in those > > teams where I'm working (in CC) we have this de-facto standard to use > > this file. Before I change the behaviour of routine-update I would like > > to discuss this inside these teams and ask for opinions. > > I don't think we have a de-facto standard on that file in debian-science, at > least I removed it from my packages a long time ago already and I agree with > Christopher that routine-update should do the same. There is no benefit in > having a file with the same content in every repo and every Debian package > if we can avoid it. Thanks for your opinion about this. What I mean with de facto standard: We have about 2000 repositories configured to check debian/salsa-ci.yml. I have not yet found a way to set the according field via gitlab API to something else. If this is scriptable I'd happily remove debian/salsa-ci.yml. For the moment I state two votes against salsa-ci.yml. ;-) Kind regards Andreas. -- http://fam-tille.de
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
Hi Andreas, * Andreas Tille [2023-07-07 09:20]: Am Thu, Jul 06, 2023 at 09:03:23PM +0100 schrieb Christopher Obbard: routine-update adds a file under the path "debian/salsa-ci.yml". Yes, this is intended. According to the salsa-ci-team[1], the default recommendation is to set the pipeline URL in the project settings rather than to use a standaline debian/salsa-ci.yml file. Therefore, please remove the addition of this file and instead please print a warning if this file exists for manual intervention to change the pipeline to the recommended suggestion by the Salsa CI team. I confirm routine-update is going beyond the recommendation but in those teams where I'm working (in CC) we have this de-facto standard to use this file. Before I change the behaviour of routine-update I would like to discuss this inside these teams and ask for opinions. I don't think we have a de-facto standard on that file in debian-science, at least I removed it from my packages a long time ago already and I agree with Christopher that routine-update should do the same. There is no benefit in having a file with the same content in every repo and every Debian package if we can avoid it. Cheers Jochen signature.asc Description: PGP signature
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
Control: severity -1 wishlist Hi Christopher, thanks you for the suggestion to enhance routine-update. Am Thu, Jul 06, 2023 at 09:03:23PM +0100 schrieb Christopher Obbard: > routine-update adds a file under the path "debian/salsa-ci.yml". Yes, this is intended. > According to the salsa-ci-team[1], the default recommendation is to > set the pipeline URL in the project settings rather than to use a > standaline debian/salsa-ci.yml file. > > Therefore, please remove the addition of this file and instead > please print a warning if this file exists for manual intervention to > change the pipeline to the recommended suggestion by the Salsa CI team. I confirm routine-update is going beyond the recommendation but in those teams where I'm working (in CC) we have this de-facto standard to use this file. Before I change the behaviour of routine-update I would like to discuss this inside these teams and ask for opinions. That's why I also have set the severity of this bug to wishlist (not because I consider it of minor interest but rather to express that the behaviour which you want to be changed is perfectly intended but should be discussed here in this bug report). Kind regards Andreas. > [1]: https://salsa.debian.org/salsa-ci-team/pipeline/#basic-use -- http://fam-tille.de
Bug#1040500: routine-update: Don't create d/salsa-ci.yml file
Package: routine-update Version: 0.1.1 Severity: normal Dear Maintainer, routine-update adds a file under the path "debian/salsa-ci.yml". According to the salsa-ci-team[1], the default recommendation is to set the pipeline URL in the project settings rather than to use a standaline debian/salsa-ci.yml file. Therefore, please remove the addition of this file and instead please print a warning if this file exists for manual intervention to change the pipeline to the recommended suggestion by the Salsa CI team. [1]: https://salsa.debian.org/salsa-ci-team/pipeline/#basic-use Cheers! Chris -- System Information: Debian Release: trixie/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 6.3.0-2-amd64 (SMP w/16 CPU threads; PREEMPT) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages routine-update depends on: ii cme1.038-1 ii devscripts 2.23.5 ii dpkg-dev 1.21.22 ii fakeroot 1.31-1.2 ii git1:2.40.1-1 ii git-buildpackage 0.9.30 ii gobject-introspection 1.74.0-3 ii libconfig-model-dpkg-perl 2.165 ii lintian-brush 0.149 ii pristine-tar 1.50 ii quilt 0.67+really0.66-1 routine-update recommends no packages. routine-update suggests no packages. -- no debconf information
