Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
On Thu, Dec 7, 2023 at 3:46 PM Jérôme Charaoui wrote: > > For the record, the upload is ready to go. I'm now only waiting for a > new build-dependency to pass through NEW, jruby-mavengem. > Sounds great, I'll take a look at the new package. Thanks for working on the 9.4 release. On my side in the meantime, I recently have been refreshing and updating several jruby build-dependencies like jnr-* package and a few other related packages.
Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
Le 2023-11-25 à 06 h 30, Miguel Landaeta a écrit : On Sat, Nov 25, 2023 at 12:29 AM Jérôme Charaoui wrote: [...] I've been working on a 9.4 release, you can see the progress here: https://salsa.debian.org/lavamind/jruby I plan to upload this version to experimental within a few days, I still have some minor issues with the testsuite to iron out before. Excellent, that's good to hear. There is no point then just backporting the fix if you are close to finishing preparing an upload. Let me know if there is something else I can help with. I think I'll take a look at some jnr-* dependencies packages that could use a new upstream release and/or bugfixes. For the record, the upload is ready to go. I'm now only waiting for a new build-dependency to pass through NEW, jruby-mavengem.
Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
On Sat, Nov 25, 2023 at 12:29 AM Jérôme Charaoui wrote: > > [...] > > I've been working on a 9.4 release, you can see the progress here: > https://salsa.debian.org/lavamind/jruby > > I plan to upload this version to experimental within a few days, I still > have some minor issues with the testsuite to iron out before. Excellent, that's good to hear. There is no point then just backporting the fix if you are close to finishing preparing an upload. Let me know if there is something else I can help with. I think I'll take a look at some jnr-* dependencies packages that could use a new upstream release and/or bugfixes. -- Miguel Landaeta, nomadium at debian.org secure email with PGP 0x6E608B637D8967E9 available at http://keyserver.pgp.com/ "Faith means not wanting to know what is true." -- Nietzsche
Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
Hi Miguel, Le 2023-11-24 à 18 h 38, Miguel Landaeta a écrit : Thomas and Jérôme, Do you have any concerns with me uploading a fix for this issue? I'm working with some folks here in Cambridge MiniDebConf and I also have some cycles to spare to work on JRuby and maybe prepare a new upstream release for 9.3 and/or 9.4 series (experimental). I've been working on a 9.4 release, you can see the progress here: https://salsa.debian.org/lavamind/jruby I plan to upload this version to experimental within a few days, I still have some minor issues with the testsuite to iron out before. Thanks, -- Jérôme
Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
Thomas and Jérôme, Do you have any concerns with me uploading a fix for this issue? I'm working with some folks here in Cambridge MiniDebConf and I also have some cycles to spare to work on JRuby and maybe prepare a new upstream release for 9.3 and/or 9.4 series (experimental).
Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
tags 1042129 + patch
thanks
Upstream handled this when they upgraded Joni dependency to 2.2 on
JRuby 9.4 series.
https://github.com/jruby/jruby/commit/3c94d31f1e198f294e9bfcb96b4188c315252b6b
https://github.com/jruby/jruby/commit/783d14bcb140477bb2577310a90742d594a48896
See attached a fix for this issue.
diff -Nru jruby-9.3.9.0+ds/debian/changelog jruby-9.3.9.0+ds/debian/changelog
--- jruby-9.3.9.0+ds/debian/changelog 2023-01-16 21:08:51.0 +
+++ jruby-9.3.9.0+ds/debian/changelog 2023-11-24 11:48:05.0 +
@@ -1,3 +1,11 @@
+jruby (9.3.9.0+ds-9~miguel1) UNRELEASED; urgency=medium
+
+ * Fix FTBFS: adapt and backport changes from 9.4 releases
+to accomodate for changes in regexp library Joni 2.2.
+(Closes: #1042129)
+
+ -- Miguel Landaeta Fri, 24 Nov 2023 11:48:05 +
+
jruby (9.3.9.0+ds-8) unstable; urgency=medium
* d/tests: flag jirb test as flaky
diff -Nru
jruby-9.3.9.0+ds/debian/patches/0012-Use-Region-accessors-in-prep-for-privatizing-fields.patch
jruby-9.3.9.0+ds/debian/patches/0012-Use-Region-accessors-in-prep-for-privatizing-fields.patch
---
jruby-9.3.9.0+ds/debian/patches/0012-Use-Region-accessors-in-prep-for-privatizing-fields.patch
1970-01-01 01:00:00.0 +0100
+++
jruby-9.3.9.0+ds/debian/patches/0012-Use-Region-accessors-in-prep-for-privatizing-fields.patch
2023-11-24 11:48:05.0 +
@@ -0,0 +1,390 @@
+Subject: Use Region accessors in prep for privatizing fields
+Forwarded:
https://github.com/jruby/jruby/commit/3c94d31f1e198f294e9bfcb96b4188c315252b6b
+--
+diff --git a/core/src/main/java/org/jruby/RubyMatchData.java
b/core/src/main/java/org/jruby/RubyMatchData.java
+index 48fa92b..87e7c9d 100644
+--- a/core/src/main/java/org/jruby/RubyMatchData.java
b/core/src/main/java/org/jruby/RubyMatchData.java
+@@ -175,11 +175,11 @@ public class RubyMatchData extends RubyObject {
+ private void updateCharOffsetOnlyOneReg(ByteList value, Encoding
encoding) {
+ if (charOffsetUpdated) return;
+
+-if (charOffsets == null || charOffsets.numRegs < 1) charOffsets = new
Region(1);
++if (charOffsets == null || charOffsets.getNumRegs() < 1) charOffsets
= new Region(1);
+
+ if (encoding.maxLength() == 1) {
+-charOffsets.beg[0] = begin;
+-charOffsets.end[0] = end;
++charOffsets.setBeg(0, begin);
++charOffsets.setEnd(0, end);
+ charOffsetUpdated = true;
+ return;
+ }
+@@ -195,14 +195,14 @@ public class RubyMatchData extends RubyObject {
+ updatePairs(value, encoding, pairs);
+
+ if (begin < 0) {
+-charOffsets.beg[0] = charOffsets.end[0] = -1;
++charOffsets.setBeg(0, charOffsets.setEnd(0, -1));
+ return;
+ }
+ Pair key = new Pair();
+ key.bytePos = begin;
+-charOffsets.beg[0] = pairs[Arrays.binarySearch(pairs, key)].charPos;
++charOffsets.setBeg(0, pairs[Arrays.binarySearch(pairs, key)].charPos);
+ key.bytePos = end;
+-charOffsets.end[0] = pairs[Arrays.binarySearch(pairs, key)].charPos;
++charOffsets.setEnd(0, pairs[Arrays.binarySearch(pairs, key)].charPos);
+
+ charOffsetUpdated = true;
+ }
+@@ -211,14 +211,14 @@ public class RubyMatchData extends RubyObject {
+ if (charOffsetUpdated) return;
+
+ final Region regs = this.regs;
+-int numRegs = regs.numRegs;
++int numRegs = regs.getNumRegs();
+
+-if (charOffsets == null || charOffsets.numRegs < numRegs) charOffsets
= new Region(numRegs);
++if (charOffsets == null || charOffsets.getNumRegs() < numRegs)
charOffsets = new Region(numRegs);
+
+ if (encoding.maxLength() == 1) {
+ for (int i = 0; i < numRegs; i++) {
+-charOffsets.beg[i] = regs.beg[i];
+-charOffsets.end[i] = regs.end[i];
++charOffsets.setBeg(i, regs.getBeg(i));
++charOffsets.setEnd(i, regs.getEnd(i));
+ }
+ charOffsetUpdated = true;
+ return;
+@@ -229,23 +229,23 @@ public class RubyMatchData extends RubyObject {
+
+ int numPos = 0;
+ for (int i = 0; i < numRegs; i++) {
+-if (regs.beg[i] < 0) continue;
+-pairs[numPos++].bytePos = regs.beg[i];
+-pairs[numPos++].bytePos = regs.end[i];
++if (regs.getBeg(i) < 0) continue;
++pairs[numPos++].bytePos = regs.getBeg(i);
++pairs[numPos++].bytePos = regs.getEnd(i);
+ }
+
+ updatePairs(value, encoding, pairs);
+
+ Pair key = new Pair();
+-for (int i = 0; i < regs.numRegs; i++) {
+-if (regs.beg[i] < 0) {
+-charOffsets.beg[i] = charOffsets.end[i] = -1;
++for (int i = 0; i < regs.getNumRegs(); i++) {
++if (regs.getBeg(i) < 0) {
++charOffsets.setBeg(i, charOffsets.setEnd(i, -1));
+
Bug#1042129: jruby: FTBFS: [ERROR] /<>/core/src/main/java/org/jruby/ext/strscan/RubyStringScanner.java:[653,34] error: cannot find symbol
Source: jruby Version: 9.3.9.0+ds-8 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lu...@debian.org Usertags: ftbfs-20230726 ftbfs-trixie Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[1]: Entering directory '/<>' > dh_auto_build -- -Djruby.revision=9.3.9.0+ds-8 -Pmain,complete,dist > /usr/lib/jvm/default-java/bin/java -noverify -cp > /usr/share/maven/boot/plexus-classworlds-2.x.jar > -Dmaven.home=/usr/share/maven > -Dmaven.multiModuleProjectDirectory=/<>/jruby-9.3.9.0\+ds > -Dclassworlds.conf=/etc/maven/m2-debian.conf > -Dproperties.file.manual=/<>/jruby-9.3.9.0\+ds/debian/maven.properties > org.codehaus.plexus.classworlds.launcher.Launcher > -s/etc/maven/settings-debian.xml > -Ddebian.dir=/<>/jruby-9.3.9.0\+ds/debian > -Dmaven.repo.local=/<>/jruby-9.3.9.0\+ds/debian/maven-repo > --batch-mode -Djruby.revision=9.3.9.0\+ds-8 -Pmain,complete,dist -DskipTests > -Dnotimestamp=true -Dlocale=en_US > OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were > deprecated in JDK 13 and will likely be removed in a future release. > [0m[0m[INFO] Scanning for projects... > [WARNING] > [WARNING] Some problems were encountered while building the effective model > for org.jruby:jruby-core:jar:9.3.9.0 > [WARNING] 'build.plugins.plugin.version' for > org.apache.maven.plugins:maven-source-plugin is missing. @ line 106, column 15 > [WARNING] > [WARNING] It is highly recommended to fix these problems because they > threaten the stability of your build. > [WARNING] > [WARNING] For this reason, future Maven versions might no longer support > building such malformed projects. > [WARNING] > [INFO] > > [INFO] Reactor Build Order: > [INFO] > [INFO] JRuby > [pom] > [INFO] JRuby Base > [jar] > [INFO] JRuby Core > [jar] > [INFO] JRuby Lib Setup > [jar] > [INFO] JRuby Artifacts > [pom] > [INFO] JRuby Main Maven Artifact > [jar] > [INFO] JRuby Complete > [bundle] > [INFO] JRuby Dist > [pom] > [INFO] > [INFO] ---< org.jruby:jruby-parent > >--- > [INFO] Building JRuby 9.3.9.0 > [1/8] > [INFO] [ pom > ]- > [INFO] > [INFO] --- maven-install-plugin:3.1.1:install (default-install) @ > jruby-parent --- > [INFO] Installing /<>/pom.xml to > /<>/debian/maven-repo/org/jruby/jruby-parent/9.3.9.0/jruby-parent-9.3.9.0.pom > [INFO] > [INFO] < org.jruby:jruby-base > > > [INFO] Building JRuby Base 9.3.9.0 > [2/8] > [INFO] [ jar > ]- > [WARNING] The artifact org.osgi:org.osgi.core:jar:debian has been relocated > to org.osgi:osgi.core:jar:debian > [INFO] > [INFO] --- exec-maven-plugin:3.1.0:exec (default) @ jruby-base --- > [INFO] > [INFO] --- maven-resources-plugin:3.3.0:resources (default-resources) @ > jruby-base --- > [INFO] Copying 42 resources > [INFO] Copying 2 resources > [INFO] > [INFO] --- maven-compiler-plugin:3.10.1:compile (anno) @ jruby-base --- > [INFO] Compiling 7 source files to /<>/core/target/classes > [WARNING] [options] bootstrap class path not set in conjunction with -source 8 > [INFO] > [INFO] --- maven-resources-plugin:3.3.0:copy-resources (default) @ jruby-base > --- > [INFO] Copying 1 resource to /<>/core/src/main/java > [INFO] Copying 4 resources to /<>/core/src/main/java/META-INF/ > [INFO] > [INFO] --- maven-compiler-plugin:3.10.1:compile (default-compile) @ > jruby-base --- > [INFO] Compiling 1463 source files to /<>/core/target/classes > [INFO] - > [WARNING] COMPILATION WARNING : > [INFO] - > [WARNING] [options] bootstrap class path not set in conjunction with -source 8 > [WARNING] method > org.jruby.ext.jruby.JRubyUtilLibrary.wait(org.jruby.runtime.ThreadContext,org.jruby.runtime.builtin.IRubyObject,org.jruby.runtime.builtin.IRubyObject) > should not throw exceptions: java.lang.InterruptedException > method > org.jruby.ext.jruby.JRubyUtilLibrary.wait(org.jruby.runtime.ThreadContext,org.jruby.runtime.builtin.IRubyObject,org.jruby.runtime.builtin.IRubyObject,org.jruby.runtime.builtin.IRubyObject) > should not throw exceptions: java.lang.InterruptedException
