Bug#1042855: openjdk-8: Please consider using libjpeg-dev virtual package as dependency

2023-08-02 Thread Thorsten Glaser
tags 1042855 + pending
thanks

Dixi quod…

>And libjpeg-dev does not appear in this list.

Ahem. That may be because there’s a real package with that name
in all(?) releases.

I’ll change this.

bye,
//mirabilos
-- 
22:20⎜ The crazy that persists in his craziness becomes a master
22:21⎜ And the distance between the craziness and geniality is
only measured by the success 18:35⎜ "Psychotics are consistently
inconsistent. The essence of sanity is to be inconsistently inconsistent



Bug#1042855: openjdk-8: Please consider using libjpeg-dev virtual package as dependency

2023-08-02 Thread Thorsten Glaser
Vladimir Petko dixit:

>The attached patch updates control and rules to select libjpeg-dev as a

By the way, no need to patch rules for Ubuntu, just regenerate
debian/control is sufficient. I built the package for PPA with
that.

>I think I found the relevant quote:
>"To specify which of a set of real packages should be the default to
>satisfy a particular dependency on a virtual package, list the real
>package as an alternative before the virtual one." 7.5 Virtual
>Packages - Provides.

Yes, that was the one I was thinking of, and you’re right it
doesn’t apply here, as we don’t care which of them is used
(with the exception of the one we Depends on for dlopen).

The first paragraph of 7.5 makes it clear that we *can* use virtual
packages as B-D. However, virtual-package-names-list.yaml says:

# Packages MUST NOT use virtual package names (except privately, amongst
# a cooperating group of packages) unless they have been agreed upon and
# appear in this list.

And libjpeg-dev does not appear in this list.

>> +  bd_syslibs += libjpeg62-turbo-dev | libjpeg-dev,

| [1] While "Build-Depends", "Build-Depends-Indep" and "Build-Depends-
| Arch" permit the use of alternative dependencies, those are only
| used for the backports suite on the Debian autobuilders. On the
| […]
| While this may limit the usefulness of alternatives in a single
| release, they can still be used to provide flexibility in building
| the same package across multiple distributions or releases, where

This indicates that specifically this was intended to make it
compatible with other distributions; if the other distribution
doesn’t accept alternatives, SOL…

bye,
//mirabilos
-- 
  “Having a smoking section in a restaurant is like having
  a peeing section in a swimming pool.”
-- Edward Burr



Bug#1042855: openjdk-8: Please consider using libjpeg-dev virtual package as dependency

2023-08-01 Thread Thorsten Glaser
Vladimir Petko dixit:

>openjdk-8 382-ga-1 uses libjpeg-turbo62 as a dependency rather than
>libjpeg-dev that it used before.

No, for Ubuntu it uses libjpeg-turbo8-dev, so why…

>The attached patch updates control and rules to select libjpeg-dev as a
>dependency allowing Ubuntu sync.

… oh, right, you don’t regenerate debian/control when you do a sync.

>The attached patch was applied to achieve the following:
>
>  * Use libjpeg-dev virtual package to solve dependency-wait (LP:
>#2028973).

No, virtual packages cannot be used as build dependencies,
that violates Policy.

Would be this okay for you:

--- a/debian/rules
+++ b/debian/rules
@@ -689,7 +689,7 @@ ifeq ($(derivative),Ubuntu)
 else ifneq (,$(filter $(distrel),wheezy))
   bd_syslibs += libjpeg8-dev,
 else
-  bd_syslibs += libjpeg62-turbo-dev,
+  bd_syslibs += libjpeg62-turbo-dev | libjpeg-dev,
 endif
 bd_syslibs += \
libgif-dev,

This will be valid in Debian (virtual package *is* allowed as
second alternative, because buildds only use the first) and
works iff Ubuntu buildd also use the second alternative.

bye,
//mirabilos
-- 
 you introduced a merge commit│ % g rebase -i HEAD^^
 sorry, no idea and rebasing just fscked │ Segmentation
 should have cloned into a clean repo  │  fault (core dumped)
 if I rebase that now, it's really ugh │ wuahh



Bug#1042855: openjdk-8: Please consider using libjpeg-dev virtual package as dependency

2023-08-01 Thread Vladimir Petko
Package: openjdk-8
Version: openjdk-8
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu mantic ubuntu-patch
X-Debbugs-Cc: vladimir.pe...@canonical.com

Dear Maintainer,

openjdk-8 382-ga-1 uses libjpeg-turbo62 as a dependency rather than libjpeg-dev
that it used before.
The attached patch updates control and rules to select libjpeg-dev as a
dependency allowing Ubuntu sync.

The attached patch was applied to achieve the following:

  * Use libjpeg-dev virtual package to solve dependency-wait (LP:
#2028973).


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers lunar-updates
  APT policy: (500, 'lunar-updates'), (500, 'lunar-security'), (500, 'lunar'), 
(100, 'lunar-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.2.0-25-generic (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru openjdk-8-8u382-ga/debian/control openjdk-8-8u382-ga/debian/control
--- openjdk-8-8u382-ga/debian/control   2023-07-22 05:19:02.0 +1200
+++ openjdk-8-8u382-ga/debian/control   2023-07-29 07:37:27.0 +1200
@@ -9,7 +9,7 @@
   xvfb, xauth, xfonts-base, 
libgl1-mesa-dri, xfwm4, x11-xkb-utils, 
dbus-x11, openjdk-8-jre-headless | default-jre-headless (>= 
2:1.8), jtreg, libasmtools-java, 
testng, time,
   autoconf (>= 2.69), automake, ant, ant-optional, fastjar (>= 
2:0.96-0ubuntu2),
   gcc-12, g++-12, libxtst-dev, libxi-dev, libxt-dev, libxaw7-dev, 
libxrender-dev, libcups2-dev, libasound2-dev, liblcms2-dev, libxinerama-dev, 
libkrb5-dev, xsltproc, libpcsclite-dev, libfreetype-dev, libgtk2.0-dev, 
libffi-dev,
-  zlib1g-dev, libattr1-dev, libpng-dev, libjpeg62-turbo-dev, libgif-dev, 
libpulse-dev (>= 0.9.12) [!alpha], systemtap-sdt-dev,
+  zlib1g-dev, libattr1-dev, libpng-dev, libjpeg-dev, libgif-dev, libpulse-dev 
(>= 0.9.12) [!alpha], systemtap-sdt-dev,
   libnss3-dev (>= 2:3.26), openjdk-8-jdk-headless , dpkg-dev (>= 
1.17.14),
 Standards-Version: 4.6.2
 Homepage: http://openjdk.java.net/
diff -Nru openjdk-8-8u382-ga/debian/rules openjdk-8-8u382-ga/debian/rules
--- openjdk-8-8u382-ga/debian/rules 2023-07-22 05:19:02.0 +1200
+++ openjdk-8-8u382-ga/debian/rules 2023-07-29 07:37:27.0 +1200
@@ -684,12 +684,10 @@
 else
   bd_syslibs += libpng-dev,
 endif
-ifeq ($(derivative),Ubuntu)
-  bd_syslibs += libjpeg-turbo8-dev,
-else ifneq (,$(filter $(distrel),wheezy))
+ifneq (,$(filter $(distrel),wheezy))
   bd_syslibs += libjpeg8-dev,
 else
-  bd_syslibs += libjpeg62-turbo-dev,
+  bd_syslibs += libjpeg-dev,
 endif
 bd_syslibs += \
libgif-dev,