Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2024-06-02 Thread Cyril Brulebois
Chris Hofstaedtler  (2024-05-30):
> Yes, having migrated enough packages I (we) believe this is safe.
> 
> Please land this in trixie before the transition freeze.

Please let me get the security fixes out of the way and I'll look into
those issues afterwards. Feel free to ping back in a week or two if that
hasn't happened by then (I don't control answer delays from either
security or release teams).


Cheers,
-- 
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/


signature.asc
Description: PGP signature


Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2024-05-29 Thread Chris Hofstaedtler
On Tue, Dec 19, 2023 at 04:36:16AM +0100, Cyril Brulebois wrote:
> Chris Hofstaedtler  (2023-12-19):
> > If you can reasonably expect that the package in question will not
> > change name, or split out or move the systemd unit files in any
> > other way, than strictly from /lib to /usr/lib, then this is safe to
> > do now.
> 
> That's very safe to assume, yes. If that's enough to guarantee that I
> won't actually be generating another problem down the line, I'm happy to
> implement this change.

Yes, having migrated enough packages I (we) believe this is safe.

Please land this in trixie before the transition freeze.

Thanks,
Chris



Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2023-12-18 Thread Cyril Brulebois
Hi,

Chris Hofstaedtler  (2023-12-19):
> If you can reasonably expect that the package in question will not
> change name, or split out or move the systemd unit files in any
> other way, than strictly from /lib to /usr/lib, then this is safe to
> do now.

That's very safe to assume, yes. If that's enough to guarantee that I
won't actually be generating another problem down the line, I'm happy to
implement this change.


Cheers,
-- 
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/


signature.asc
Description: PGP signature


Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2023-12-18 Thread Chris Hofstaedtler
Hi Cyril,

On Fri, Dec 08, 2023 at 10:48:59PM +0100, Cyril Brulebois wrote:
> Chris Hofstaedtler  (2023-12-08):
> > Can we help you out in any way to get the systemd units moved? It's
> > not so "early stage" anymore and the systemd units can certainly
> > move now.
> 
> I haven't been able to keep up with the state of this transition (having
> been busy with other topics that have been a blocker for it).

I hear you.

> If it's safe to move things around, I can handle that. At least that
> particular subject line from last week didn't seem encouraging:
> Subject: Pause /usr-merge moves
> See https://lists.debian.org/20231201210412.ga1344...@subdivi.de

Indeed, the concerns around these parts are a worry.

If you can reasonably expect that the package in question will not
change name, or split out or move the systemd unit files in any
other way, than strictly from /lib to /usr/lib, then this is safe to
do now.

Conversely, if you expect the package to change name, split out the
systemd unit files into another package, or otherwise move them
around, please do not move them now.

If the only things 'blocking' this bug is your time and/or
uncertainty about the situation right now, then this is also a good
to know datapoint.

I'm sorry that there are no easy (to read or otherwise) answers now,
and I also don't expect them to show up in the future :-/

Best,
Chris



Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2023-12-08 Thread Cyril Brulebois
Hi,

Chris Hofstaedtler  (2023-12-08):
> On Fri, Sep 08, 2023 at 11:25:24AM +0200, Helmut Grohne wrote:
> > Are you fine with uploading this change at this early
> > stage of the transition?
> 
> Can we help you out in any way to get the systemd units moved? It's
> not so "early stage" anymore and the systemd units can certainly
> move now.

I haven't been able to keep up with the state of this transition (having
been busy with other topics that have been a blocker for it). If it's
safe to move things around, I can handle that. At least that particular
subject line from last week didn't seem encouraging:

Subject: Pause /usr-merge moves

See https://lists.debian.org/20231201210412.ga1344...@subdivi.de


Cheers,
-- 
Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/


signature.asc
Description: PGP signature


Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2023-12-08 Thread Chris Hofstaedtler
Hi crowdsec-custom-bouncer Maintainers,
Hi Cyril,

On Fri, Sep 08, 2023 at 11:25:24AM +0200, Helmut Grohne wrote:
> Are you fine with uploading this change at this early
> stage of the transition?

Can we help you out in any way to get the systemd units moved? It's
not so "early stage" anymore and the systemd units can certainly
move now.

Thanks for considering,
Chris



Bug#1051460: crowdsec-custom-bouncer: move systemd units to /usr

2023-09-08 Thread Helmut Grohne
Source: crowdsec-custom-bouncer
Version: 0.0.15-3
Severity: wishlist
Tags: patch
User: helm...@debian.org
Usertags: dep17m2

Hi,

crowdsec-custom-bouncer happens to be affected by the /usr-merge by
virtue of including a systemd unit. The CTTE has recommended not moving
such units from / to /usr to avoid problems such as file loss. These
problems are better understood and documented at
https://subdivi.de/~helmut/dep17.html now. I'm looking into lifting the
moratorium in a controlled way and propose this patch as a test case for
it. Yes, this patch expressly violates the moratorium. I've taken care
to update debhelper to recognize the new location. No problems shall
arise unless you restructure crowdsec-custom-bouncer (renaming the
binary package, splitting it, moving files between packages). If you do
such activity within the trixie cycle, please upload to experimental
first such that https://salsa.debian.org/helmutg/dumat can tell you
whether the particular change is problematic. In case of problems, I'll
be assisting. Are you fine with uploading this change at this early
stage of the transition?

Thanks for considering

Helmut
diff --minimal -Nru crowdsec-custom-bouncer-0.0.15/debian/changelog 
crowdsec-custom-bouncer-0.0.15/debian/changelog
--- crowdsec-custom-bouncer-0.0.15/debian/changelog 2023-05-31 
19:01:19.0 +0200
+++ crowdsec-custom-bouncer-0.0.15/debian/changelog 2023-09-08 
11:11:47.0 +0200
@@ -1,3 +1,10 @@
+crowdsec-custom-bouncer (0.0.15-3.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Move systemd units to /usr. (Closes: #-1)
+
+ -- Helmut Grohne   Fri, 08 Sep 2023 11:11:47 +0200
+
 crowdsec-custom-bouncer (0.0.15-3) unstable; urgency=medium
 
   * Fix failure to install if crowdsec is unpacked but not configured
diff --minimal -Nru crowdsec-custom-bouncer-0.0.15/debian/control 
crowdsec-custom-bouncer-0.0.15/debian/control
--- crowdsec-custom-bouncer-0.0.15/debian/control   2023-03-21 
00:58:41.0 +0100
+++ crowdsec-custom-bouncer-0.0.15/debian/control   2023-09-08 
11:11:44.0 +0200
@@ -4,7 +4,8 @@
 Section: golang
 Testsuite: autopkgtest-pkg-go
 Priority: optional
-Build-Depends: debhelper-compat (= 13),
+Build-Depends: debhelper (>= 13.11.6),
+   debhelper-compat (= 13),
dh-golang,
golang-any,
golang-github-coreos-go-systemd-dev,
diff --minimal -Nru 
crowdsec-custom-bouncer-0.0.15/debian/crowdsec-custom-bouncer.install 
crowdsec-custom-bouncer-0.0.15/debian/crowdsec-custom-bouncer.install
--- crowdsec-custom-bouncer-0.0.15/debian/crowdsec-custom-bouncer.install   
2023-03-21 00:58:41.0 +0100
+++ crowdsec-custom-bouncer-0.0.15/debian/crowdsec-custom-bouncer.install   
2023-09-08 11:11:08.0 +0200
@@ -1,3 +1,3 @@
 # Manual copy, in addition to the dh_auto_install in golang mode:
-config/crowdsec-custom-bouncer.service lib/systemd/system
+config/crowdsec-custom-bouncer.service usr/lib/systemd/system
 config/crowdsec-custom-bouncer.yamletc/crowdsec/bouncers/