Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-05-29 Thread Chris Hofstaedtler
On Wed, May 29, 2024 at 12:57:21PM -0300, Lucas Castro wrote:
> I would like the NMU be canceled.

> cancel lsm_1.0.4-2.1_source.changes
Files removed from 3-day: lsm_1.0.4-2.1_source.changes lsm_1.0.4-2.1.dsc 
lsm_1.0.4-2.1.debian.tar.xz lsm_1.0.4-2.1_arm64.buildinfo

I'm looking forward to your fix landing before the trixie transition
freeze.

Chris



Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-05-29 Thread Lucas Castro


Em 25/05/2024 17:42, Lucas Castro escreveu:


Em 25/05/2024 17:23, Chris Hofstaedtler escreveu:

Dear Maintainer,

On Mon, Oct 16, 2023 at 08:11:55PM +0200, Helmut Grohne wrote:

Source: lsm
Version: 1.0.4-2

I've prepared an NMU and uploaded to DELAYED/7. It is time to get
this done.

Feel free to fix this bug yourself before this time.


Chris, the bug was fixed.

There's a RFS, if I'm waiting for someone to sponsor it, if you don't 
mind, feel free to sponsorship it.


https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064297


I would like the NMU be canceled.







Best,
Chris



OpenPGP_0x42F79A5E0A4D5598.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-05-25 Thread Lucas Castro


Em 25/05/2024 17:23, Chris Hofstaedtler escreveu:

Dear Maintainer,

On Mon, Oct 16, 2023 at 08:11:55PM +0200, Helmut Grohne wrote:

Source: lsm
Version: 1.0.4-2

I've prepared an NMU and uploaded to DELAYED/7. It is time to get
this done.

Feel free to fix this bug yourself before this time.


Chris, the bug was fixed.

There's a RFS, if I'm waiting for someone to sponsor it, if you don't 
mind, feel free to sponsorship it.


https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064297




Best,
Chris



OpenPGP_0x42F79A5E0A4D5598.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-05-25 Thread Chris Hofstaedtler
Dear Maintainer,

On Mon, Oct 16, 2023 at 08:11:55PM +0200, Helmut Grohne wrote:
> Source: lsm
> Version: 1.0.4-2

I've prepared an NMU and uploaded to DELAYED/7. It is time to get
this done.

Feel free to fix this bug yourself before this time.

Best,
Chris



Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-01-27 Thread Lucas Castro


Em 24/01/2024 03:22, Helmut Grohne escreveu:

On Tue, Jan 23, 2024 at 05:25:21PM -0300, Lucas Castro wrote:

dh_installsystemd look only for maintainer scripts. That means it looks only
for scripts residing in debian/ folder.

I guess you should know about that, therefore you propose to create a
symlink from systemd file provided by upstream.

That's not the reason for proposing the change. The reason is that we
need to move the units from /lib/systemd/system to
/usr/lib/systemd/system in trixie but not bookworm. Encoding this in a
debian/*.install file is not simple, but we updated dh_installsystemd to
do exactly that.


systemd file .service will be moved to the /usr/lib/systemd/system 
folder and close this bug.






Sorry, I'm not going to apply the solution proposed on the next release, but
I take a look what it should be the best approach for this.

I do not insist on using my approach. It merely is the one I considered
most suitable at the time of submitting the bug. Alternatively, you may
employ dh_movetousr or update the location in debian/lsm.install (though
extra work is required in case of backporting for the last option). The
point of this bug is to not ship aliased locations such as /lib.

Helmut



OpenPGP_0x42F79A5E0A4D5598.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-01-24 Thread Helmut Grohne
On Tue, Jan 23, 2024 at 05:25:21PM -0300, Lucas Castro wrote:
> dh_installsystemd look only for maintainer scripts. That means it looks only
> for scripts residing in debian/ folder.
> 
> I guess you should know about that, therefore you propose to create a
> symlink from systemd file provided by upstream.

That's not the reason for proposing the change. The reason is that we
need to move the units from /lib/systemd/system to
/usr/lib/systemd/system in trixie but not bookworm. Encoding this in a
debian/*.install file is not simple, but we updated dh_installsystemd to
do exactly that.

> Sorry, I'm not going to apply the solution proposed on the next release, but
> I take a look what it should be the best approach for this.

I do not insist on using my approach. It merely is the one I considered
most suitable at the time of submitting the bug. Alternatively, you may
employ dh_movetousr or update the location in debian/lsm.install (though
extra work is required in case of backporting for the last option). The
point of this bug is to not ship aliased locations such as /lib.

Helmut



Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-01-23 Thread Lucas Castro

Hello Helmut,

Em 16/10/2023 15:11, Helmut Grohne escreveu:

Source: lsm
Version: 1.0.4-2
Tags: patch
User: helm...@debian.org
Usertags: dep17m2

We want to move aliased files from / to /usr to finalize the /usr-merge
transition via DEP17. lsm is involved, because it installs a systemd
unit. Rather than move the unit, I recommend installing it using
dh_installsystemd, because that'll automatically revert back to the old
location for bookworm-backports and thus honour the moratorium that
still is in effect there. debdiff cannot represent this patch:

 rm debian/lsm.install
 ln -s ../lsm.service debian/lsm.service


I'm planing upload a new version next week.

dh_installsystemd look only for maintainer scripts. That means it looks 
only for scripts residing in debian/ folder.


I guess you should know about that, therefore you propose to create a 
symlink from systemd file provided by upstream.


Sorry, I'm not going to apply the solution proposed on the next release, 
but I take a look what it should be the best approach for this.





Helmut



Regards,

Lucas Castro.



Bug#1054086: lsm: let dh_installsystemd choose the location of units

2024-01-04 Thread Lucas Castro



Em 08/12/2023 18:09, Chris Hofstaedtler escreveu:

Hi Lucas,


Em 16 de outubro de 2023 15:11:55 BRT, Helmut Grohne  
escreveu:

Source: lsm

[..]

still is in effect there. debdiff cannot represent this patch:

rm debian/lsm.install
ln -s ../lsm.service debian/lsm.service

* Lucas Castro :

Sorry about delay for "fixing" that.

ASAP I'll work on that.

Are there any blockers I might be able to help you with, to move
this forward?


I was little busy working on myself workflow. In two week it'll be "fix it".

I just need to discuss about changing the package name.



Thanks,
Chris





Bug#1054086: lsm: let dh_installsystemd choose the location of units

2023-12-08 Thread Chris Hofstaedtler
Hi Lucas,

> Em 16 de outubro de 2023 15:11:55 BRT, Helmut Grohne  
> escreveu:
> >Source: lsm
[..]
> >still is in effect there. debdiff cannot represent this patch:
> >
> >rm debian/lsm.install
> >ln -s ../lsm.service debian/lsm.service

* Lucas Castro :
> Sorry about delay for "fixing" that.
> 
> ASAP I'll work on that.

Are there any blockers I might be able to help you with, to move
this forward?

Thanks,
Chris



Bug#1054086: lsm: let dh_installsystemd choose the location of units

2023-10-25 Thread Lucas Castro
Sorry about delay for "fixing" that.

ASAP I'll work on that.  

Em 16 de outubro de 2023 15:11:55 BRT, Helmut Grohne  
escreveu:
>Source: lsm
>Version: 1.0.4-2
>Tags: patch
>User: helm...@debian.org
>Usertags: dep17m2
>
>We want to move aliased files from / to /usr to finalize the /usr-merge
>transition via DEP17. lsm is involved, because it installs a systemd
>unit. Rather than move the unit, I recommend installing it using
>dh_installsystemd, because that'll automatically revert back to the old
>location for bookworm-backports and thus honour the moratorium that
>still is in effect there. debdiff cannot represent this patch:
>
>rm debian/lsm.install
>ln -s ../lsm.service debian/lsm.service
>
>Helmut
>


Bug#1054086: lsm: let dh_installsystemd choose the location of units

2023-10-16 Thread Helmut Grohne
Source: lsm
Version: 1.0.4-2
Tags: patch
User: helm...@debian.org
Usertags: dep17m2

We want to move aliased files from / to /usr to finalize the /usr-merge
transition via DEP17. lsm is involved, because it installs a systemd
unit. Rather than move the unit, I recommend installing it using
dh_installsystemd, because that'll automatically revert back to the old
location for bookworm-backports and thus honour the moratorium that
still is in effect there. debdiff cannot represent this patch:

rm debian/lsm.install
ln -s ../lsm.service debian/lsm.service

Helmut