Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Sean Whitton writes:
> Hello,
>
> On Sun 10 Dec 2023 at 09:09pm -08, Xiyue Deng wrote:
>
>> So a little further reading from the policy[1] and the lintian bug[2]
>> helped me understand the usage of "Built-Using" a bit better: it's used
>> to include other source package required for building without having to
>> depend on them. So technically it's not mutually exclusive with
>> arch:all as stated in the bug. However, in the case of
>> persp-perspective, I tried with or without it and it doesn't make any
>> difference. What's important is that ${elpa:Depends} correctly added
>> elpa-perspective and elpa-projectile to the dependency list of the
>> binary package. So I think in the end dropping it should be OK.
>>
>> Still, it makes sense to clarify the actual reason to drop it, so I've
>> updated the changelog entry to reflect this fact[3]. PTAL, TIA!
>
> Well, it's more about ensuring that those source package versions aren't
> dropped from the archive by dak, rendering us license-incompliant.
> Thanks for looking into it further. I've made a further change to your
> changelog message. Please take a look.
LGTM. Thanks!
>
> I've also noticed that there has been an upload to the archive,
> 1:0.2.0-4, which is not accounted for in our history. Please merge it
> in. 'gbp import-dsc apt:persp-projectile/sid', and then a manual merge,
> is probably what you want, because of how the patches are unapplied.
Not sure how I missed this, sorry about that. Somehow `apt source`
cannot find persp-projectile, and I see that there is actually a
"debian/1:0.2.0-4" tag created but the change is not merged to master
since I worked on it, so I just merged from the tag and resolved the
conflicts. Also rebuilt and pushed to mentors[1]. PTAL, TIA!
[1] https://mentors.debian.net/package/persp-projectile/
--
Xiyue Deng
signature.asc
Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Hello,
On Sun 10 Dec 2023 at 09:09pm -08, Xiyue Deng wrote:
> So a little further reading from the policy[1] and the lintian bug[2]
> helped me understand the usage of "Built-Using" a bit better: it's used
> to include other source package required for building without having to
> depend on them. So technically it's not mutually exclusive with
> arch:all as stated in the bug. However, in the case of
> persp-perspective, I tried with or without it and it doesn't make any
> difference. What's important is that ${elpa:Depends} correctly added
> elpa-perspective and elpa-projectile to the dependency list of the
> binary package. So I think in the end dropping it should be OK.
>
> Still, it makes sense to clarify the actual reason to drop it, so I've
> updated the changelog entry to reflect this fact[3]. PTAL, TIA!
Well, it's more about ensuring that those source package versions aren't
dropped from the archive by dak, rendering us license-incompliant.
Thanks for looking into it further. I've made a further change to your
changelog message. Please take a look.
I've also noticed that there has been an upload to the archive,
1:0.2.0-4, which is not accounted for in our history. Please merge it
in. 'gbp import-dsc apt:persp-projectile/sid', and then a manual merge,
is probably what you want, because of how the patches are unapplied.
--
Sean Whitton
signature.asc
Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Sean Whitton writes:
> Hello,
>
> On Fri 03 Nov 2023 at 05:01pm -07, Xiyue Deng wrote:
>
>> I thought mentioning dropping Built-Using from arch:all package could be
>> an acceptable reason, which in turn also follows Lintian's suggestion :)
>> But do let me know if I should further clarify.
>
> But why couldn't an arch:all package have Built-Using? Built-Using, per
> Policy, is for license issues. arch:any vs. arch:all isn't
> determinative.
So a little further reading from the policy[1] and the lintian bug[2]
helped me understand the usage of "Built-Using" a bit better: it's used
to include other source package required for building without having to
depend on them. So technically it's not mutually exclusive with
arch:all as stated in the bug. However, in the case of
persp-perspective, I tried with or without it and it doesn't make any
difference. What's important is that ${elpa:Depends} correctly added
elpa-perspective and elpa-projectile to the dependency list of the
binary package. So I think in the end dropping it should be OK.
Still, it makes sense to clarify the actual reason to drop it, so I've
updated the changelog entry to reflect this fact[3]. PTAL, TIA!
[1]
https://www.debian.org/doc/debian-policy/ch-relationships.html#additional-source-packages-used-to-build-the-binary-built-using
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=999785
[3]
https://salsa.debian.org/emacsen-team/persp-projectile/-/commit/a0c39b5d53d96f7e85b163f9cb530efbf34b6166
--
Xiyue Deng
signature.asc
Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Hello, On Fri 03 Nov 2023 at 05:01pm -07, Xiyue Deng wrote: > I thought mentioning dropping Built-Using from arch:all package could be > an acceptable reason, which in turn also follows Lintian's suggestion :) > But do let me know if I should further clarify. But why couldn't an arch:all package have Built-Using? Built-Using, per Policy, is for license issues. arch:any vs. arch:all isn't determinative. -- Sean Whitton signature.asc Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Xiyue Deng writes: > Hi Sean, > > Thanks for the review! I initially thought d/changelog should mainly be > about user-facing changes. But looks like it's better to be thorough. > Please see replies inline below. > > Sean Whitton writes: > >> control: tag -1 + moreinfo >> control: owner -1 ! >> >> Hello Xiyue, >> >> Thank you for working on this. >> A review of 2ea5e050fe78c7a382a613bc60ce5f14da4f130a: >> >> I'm wondering why you've updated git watch to check for the git HEAD, >> since upstream seems to now be tagging releases? >> > > I could have mixed the impression with other repos that don't have it. > Now tracking tags and slightly modernize it using "@ANY_VERSION@". > >> The changelog should mention the switch d/compat -> debhelper-compat. >> > > Done. > >> The typo fix in d/control should be mentioned in d/changelog. >> > > Done. > >> You should say that it's --parallel that you dropped from d/rules. >> > > Done. > >> Your justification for dropping the Built-Using should not be that >> Lintian suggested dropping it. Please determine the real reason :) > > I thought mentioning dropping Built-Using from arch:all package could be > an acceptable reason, which in turn also follows Lintian's suggestion :) > But do let me know if I should further clarify. > > New updates pushed to team repo and reuploaded to mentors. PTAL. TIA! Friendly ping :) -- Xiyue Deng signature.asc Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Hi Sean, Thanks for the review! I initially thought d/changelog should mainly be about user-facing changes. But looks like it's better to be thorough. Please see replies inline below. Sean Whitton writes: > control: tag -1 + moreinfo > control: owner -1 ! > > Hello Xiyue, > > Thank you for working on this. > A review of 2ea5e050fe78c7a382a613bc60ce5f14da4f130a: > > I'm wondering why you've updated git watch to check for the git HEAD, > since upstream seems to now be tagging releases? > I could have mixed the impression with other repos that don't have it. Now tracking tags and slightly modernize it using "@ANY_VERSION@". > The changelog should mention the switch d/compat -> debhelper-compat. > Done. > The typo fix in d/control should be mentioned in d/changelog. > Done. > You should say that it's --parallel that you dropped from d/rules. > Done. > Your justification for dropping the Built-Using should not be that > Lintian suggested dropping it. Please determine the real reason :) I thought mentioning dropping Built-Using from arch:all package could be an acceptable reason, which in turn also follows Lintian's suggestion :) But do let me know if I should further clarify. New updates pushed to team repo and reuploaded to mentors. PTAL. TIA! -- Xiyue Deng signature.asc Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
control: tag -1 + moreinfo control: owner -1 ! Hello Xiyue, Thank you for working on this. A review of 2ea5e050fe78c7a382a613bc60ce5f14da4f130a: I'm wondering why you've updated git watch to check for the git HEAD, since upstream seems to now be tagging releases? The changelog should mention the switch d/compat -> debhelper-compat. The typo fix in d/control should be mentioned in d/changelog. You should say that it's --parallel that you dropped from d/rules. Your justification for dropping the Built-Using should not be that Lintian suggested dropping it. Please determine the real reason :) -- Sean Whitton signature.asc Description: PGP signature
Bug#1054523: RFS: persp-projectile/1:1.0.0+git20210618.4e374d7-1 [RC] [Team] -- integrate perspective.el with projectile
Package: sponsorship-requests
Severity: important
X-Debbugs-CC: debian-emac...@lists.debian.org
Dear mentors,
I am looking for a sponsor for my package "persp-projectile":
* Package name : persp-projectile
Version : 1:1.0.0+git20210618.4e374d7-1
Upstream contact : Bozhidar Batsov
* URL : https://github.com/bbatsov/persp-projectile
* License : GPL-3+
* Vcs : https://salsa.debian.org/emacsen-team/persp-projectile
Section : lisp
The source builds the following binary packages:
elpa-persp-projectile - integrate perspective.el with projectile
To access further information about this package, please visit the following
URL:
https://mentors.debian.net/package/persp-projectile/
Alternatively, you can download the package with 'dget' using this command:
dget -x
https://mentors.debian.net/debian/pool/main/p/persp-projectile/persp-projectile_1.0.0+git20210618.4e374d7-1.dsc
Changes since the last upload:
persp-projectile (1:1.0.0+git20210618.4e374d7-1) unstable; urgency=medium
.
* Team upload.
.
[ David Krauser ]
* Update maintainer email address
.
[ Dhavan Vaidya ]
* d/control: Change Vcs-{Browser,Git} URL to salsa.debian.org
.
[ Nicholas D Steeves ]
* Drop emacs24 from Enhances (package does not exist in bullseye).
.
[ Xiyue Deng ]
* Team upload.
* Sync to latest upstream head.
- Fix compatibility with elpa-perspective. Closes: #919035.
- Refresh patches.
* Update d/watch to check for head.
* Update debhelper-compat to version 13.
* Update Standards-Version to 4.6.2. No change needed.
* Drop unnecessary parameter in d/rules.
* Drop Built-Using from arch:all package as per lintian suggestion.
* Drop unused and update renamed lintian overrides.
* Update year and Upstream-Contact in d/copyright.
* Add d/upstream/metadata.
Regards,
--
Xiyue Deng
