Bug#1056120: mariadb-server: debian-start uses obsolate hardcoded /etc/mysql/debian.cnf

2023-11-23 Thread Otto Kekäläinen
Severity: wishlist
Version 1:10.11.5-3

You are correct in that there are still calls to
'--defaults-file=/etc/mysql/debian.cnf' in the package scripts and
that they have been deprecated.

They are obsolete on new installs. However on old installs that
upgraded from MariaDB 10.x they are still needed. We likely have to
wait for several years before removing those, and additionally there
needs to be scripts that delete/rename the all the legacy
/etc/mysql/debian.cnf files before that.



Bug#1056120: mariadb-server: debian-start uses obsolate hardcoded /etc/mysql/debian.cnf

2023-11-17 Thread Sebastian Fiedler
Package: mariadb-server
Version: 1:10.11.4-1~deb12u1
Severity: normal

Dear Maintainer,

debian-start uses obsolate hardcoded /etc/mysql/debian.cnf. The file
will bee removed in the future. When this file exists, I get
"Access denied for user 'root'@'localhost'" with mariaDB Unix Socket 
Authentication Plugin.

Here is a possible fix:

--- debian-start2023-11-17 10:22:20.02000 +0100
+++ debian-start.new2023-11-17 09:57:04.7 +0100
@@ -17,11 +17,15 @@
   . /etc/default/mariadb
 fi

-MYSQL="/usr/bin/mysql --defaults-file=/etc/mysql/debian.cnf"
-MYADMIN="/usr/bin/mysqladmin --defaults-file=/etc/mysql/debian.cnf"
+if [ -f /etc/mysql/debian.cnf ]; then
+  EXTRAPARAM='--defaults-file=/etc/mysql/debian.cnf'
+fi
+
+MYSQL="/usr/bin/mysql $EXTRAPARAM"
+MYADMIN="/usr/bin/mysqladmin $EXTRAPARAM"
 # Don't run full mysql_upgrade on every server restart, use --version-check to 
do it only once
-MYUPGRADE="/usr/bin/mysql_upgrade --defaults-extra-file=/etc/mysql/debian.cnf 
--version-check --silent"
-MYCHECK="/usr/bin/mysqlcheck --defaults-file=/etc/mysql/debian.cnf"
+MYUPGRADE="/usr/bin/mysql_upgrade $EXTRAPARAM --version-check --silent"
+MYCHECK="/usr/bin/mysqlcheck $EXTRAPARAM"
 MYCHECK_SUBJECT="WARNING: mysqlcheck has found corrupt tables"
 MYCHECK_PARAMS="--all-databases --fast --silent"
 MYCHECK_RCPT="${MYCHECK_RCPT:-root}"


*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***


-- System Information:
Debian Release: 12.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-13-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mariadb-server depends on:
ii  adduser3.134
ii  debconf [debconf-2.0]  1.5.82
ii  galera-4   26.4.13-1
ii  gawk   1:5.2.1-2
ii  iproute2   6.1.0-3
ii  libc6  2.36-9+deb12u3
ii  libdbi-perl1.643-4
ii  libpam0g   1.5.2-6+deb12u1
ii  libssl33.0.11-1~deb12u2
ii  libstdc++6 12.2.0-14
ii  lsof   4.95.0-1
ii  mariadb-client 1:10.11.4-1~deb12u1
ii  mariadb-common 1:10.11.4-1~deb12u1
ii  mariadb-server-core1:10.11.4-1~deb12u1
ii  passwd 1:4.13+dfsg1-1+b1
ii  perl   5.36.0-7
ii  procps 2:4.0.2-3
ii  psmisc 23.6-1
ii  rsync  3.2.7-1
ii  socat  1.7.4.4-2
ii  zlib1g 1:1.2.13.dfsg-1

Versions of packages mariadb-server recommends:
pn  libhtml-template-perl   
pn  mariadb-plugin-provider-bzip2   
pn  mariadb-plugin-provider-lz4 
pn  mariadb-plugin-provider-lzma
pn  mariadb-plugin-provider-lzo 
pn  mariadb-plugin-provider-snappy  
ii  pv  1.6.20-1

Versions of packages mariadb-server suggests:
ii  bsd-mailx [mailx]  8.1.2-0.20220412cvs-1
pn  mariadb-test   
ii  netcat-openbsd 1.219-1

-- Configuration Files:
/etc/mysql/mariadb.conf.d/50-server.cnf changed [not included]

-- debconf information excluded