Bug#1057233: [Pkg-utopia-maintainers] Bug#1057233: pipewire-bin: installs files into /lib/udev/rules.d

2023-12-03 Thread Michael Biebl 

Hi Chris

Am 02.12.23 um 03:45 schrieb Chris Hofstaedtler:

Control: tags -1 + patch

* Chris Hofstaedtler  [231202 02:17]:

your package installs the file /lib/udev/rules.d/90-pipewire-alsa.rules.

[..]

Please find a patch attached, which delegates placement of the rules
file to udev.pc. In a few weeks, udev.pc will change "udevdir" to
/usr/lib/udev/rules.d, and then your package will pick the new path
up on the next upload or binNMU.
Additionaly, backports do not need to revert anything.


If you are going to use udev.pc/systemd.pc, please consider using 
systemd-dev as Build-Depends instead of udev/systemd


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1057233: pipewire-bin: installs files into /lib/udev/rules.d

2023-12-02 Thread Gioele Barabucci 

Upstream pipewire now (post 1.0) defaults to /usr/lib/udev/rules.d.

So if no backports are planned for oldstable (Debian 11, bullseye), just 
waiting for a new pipewire release will be enough and no changes to 
d/rules are needed to fix this bug.


Regards,

--
Gioele Barabucci

Bug#1057233: pipewire-bin: installs files into /lib/udev/rules.d

2023-12-01 Thread Chris Hofstaedtler 
Control: tags -1 + patch

* Chris Hofstaedtler  [231202 02:17]:
> your package installs the file /lib/udev/rules.d/90-pipewire-alsa.rules.
[..]

Please find a patch attached, which delegates placement of the rules
file to udev.pc. In a few weeks, udev.pc will change "udevdir" to
/usr/lib/udev/rules.d, and then your package will pick the new path
up on the next upload or binNMU.
Additionaly, backports do not need to revert anything.

Best,
Chris
diff -Nru pipewire-1.0.0/debian/changelog pipewire-1.0.0/debian/changelog
--- pipewire-1.0.0/debian/changelog	2023-11-27 11:37:05.0 +0100
+++ pipewire-1.0.0/debian/changelog	2023-12-02 02:08:47.0 +0100
@@ -1,3 +1,10 @@
+pipewire (1.0.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Set udevrulesdir based on udev.pc content
+
+ -- Chris   Sat, 02 Dec 2023 02:08:47 +0100
+
 pipewire (1.0.0-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru pipewire-1.0.0/debian/control pipewire-1.0.0/debian/control
--- pipewire-1.0.0/debian/control	2023-11-27 11:37:05.0 +0100
+++ pipewire-1.0.0/debian/control	2023-12-02 02:08:47.0 +0100
@@ -43,7 +43,8 @@
modemmanager-dev,
pkg-config,
python3-docutils,
-   systemd [linux-any]
+   systemd [linux-any],
+   udev [linux-any]
 Build-Conflicts: libfdk-aac-dev
 Standards-Version: 4.6.2
 Vcs-Browser: https://salsa.debian.org/utopia-team/pipewire
diff -Nru pipewire-1.0.0/debian/pipewire-bin.install pipewire-1.0.0/debian/pipewire-bin.install
--- pipewire-1.0.0/debian/pipewire-bin.install	2023-11-27 11:37:05.0 +0100
+++ pipewire-1.0.0/debian/pipewire-bin.install	2023-12-02 02:08:47.0 +0100
@@ -7,7 +7,6 @@
 usr/share/pipewire/pipewire-aes67.conf
 usr/share/pipewire/pipewire-avb.conf
 usr/share/pipewire/minimal.conf
-lib/udev/rules.d
 usr/bin/pipewire
 usr/bin/pipewire-aes67
 usr/bin/pipewire-avb
diff -Nru pipewire-1.0.0/debian/rules pipewire-1.0.0/debian/rules
--- pipewire-1.0.0/debian/rules	2023-11-27 11:37:05.0 +0100
+++ pipewire-1.0.0/debian/rules	2023-12-02 02:08:47.0 +0100
@@ -45,6 +45,13 @@
 LIBFFADO=enabled
 endif
 
+ifneq (,$(filter hurd-i386,$(DEB_HOST_ARCH)))
+UDEVRULESDIR=
+else
+UDEVRULESDIR=$(shell pkg-config --variable=udevdir udev)/rules.d
+endif
+
+
 override_dh_auto_configure:
 	dh_auto_configure -- \
 		-Daudiotestsrc=enabled \
@@ -69,6 +76,7 @@
 		-Dsdl2=$(SDL2) \
 		-Dsession-managers= \
 		-Dtest=enabled \
+		-Dudevrulesdir=$(UDEVRULESDIR) \
 		-Dvideotestsrc=enabled \
 		-Dvulkan=disabled \
 		$(NULL)
@@ -91,6 +99,10 @@
 		--timeout-multiplier $(test_timeout_multiplier) \
 		$(NULL)
 
+override_dh_install:
+	dh_install
+	test -n "$(UDEVRULESDIR)" && dh_install -ppipewire-bin $(UDEVRULESDIR)
+
 override_dh_missing:
 	dh_missing --fail-missing

Bug#1057233: pipewire-bin: installs files into /lib/udev/rules.d

2023-12-01 Thread Chris Hofstaedtler 
Package: pipewire-bin
Version: 1.0.0-1
Severity: normal
User: helm...@debian.org
Usertags: dep17m2

Dear Maintainer,

your package installs the file /lib/udev/rules.d/90-pipewire-alsa.rules.

For the ongoing UsrMerge effort [1], /lib needs to become "empty", IOW no
package should install a file there. Instead, files should be installed
into /usr/lib.

Apparently the path in /lib is hard-coded, either in the upstream build
system or the packaging.

Please change your package to install into /usr/lib/udev/rules.d at your
earliest convenience. Per the wiki, it is useful to first upload to
experimental and wait a few days for the dumat tool to evaluate the
change, and only then upload to unstable.

At a later point during the trixie cycle, I expect this bug will become
release-critical.

Thanks for considering,
Chris

[1] https://wiki.debian.org/UsrMerge