Bug#1059857: discrepancy between upstream and downstream .service files
On Tue, 2 Jan 2024 18:49:59 +0100 Chris Hofstaedtler wrote: > Hi! > > On Tue, Jan 02, 2024 at 02:19:39PM +0100, Michael Biebl wrote: > > today I wanted to enable the iSCSI test in systemd: > > https://salsa.debian.org/systemd-team/systemd/-/blob/debian/master/test/TEST-64-UDEV-STORAGE/test.sh?ref_type=heads#L29-34 > > > > For that I added test dependency on open-iscsi and tgt. > > Unfortunately, this failed: > > ``` > > W: Failed to install '/usr/lib/systemd/system/iscsi-init.service' > > I: Skipping program /usr/lib/systemd/system/iscsi-init.service as it cannot be found and is flagged to be optional > > W: Failed to install '/usr/lib/systemd/system/iscsi-onboot.service' > > I: Skipping program /usr/lib/systemd/system/iscsi-onboot.service as it cannot be found and is flagged to be optional > > W: Failed to install '/usr/lib/systemd/system/iscsi- shutdown.service' > > I: Skipping program /usr/lib/systemd/system/iscsi-shutdown.service as it cannot be found and is flagged to be optional > > W: Failed to install '/usr/lib/systemd/system/iscsi.service' > > F: Failed to install /usr/lib/systemd/system/iscsi.service > > make: Leaving directory '/tmp/autopkgtest.yvEXDQ/build.n6X/real- tree/test/TEST-64-UDEV-STORAGE' > > [13:12:37] --x-- Result of TEST-64-UDEV-STORAGE: 2 --x-- > > ``` > > > > I notice that the Debian open-iscsi package ships custom service files > > with a custom naming: > [..] > > > > Would it be possible to use the upstream service files or at least align > > the names? > > As noted briefly on IRC, TTBOMK each distro has its own service > files, and upstream has yet another set of them. The names referend > in your systemd test output look Fedora-specific to me. > > IMO these things would be interesting to consider (in any order): > *) teach systemd tests about the Debian/Ubuntu setup > *) try to converge more towards the upstream set, if that one is > actually complete. Note that you don't need to rename them, just add aliases - assuming they provide similar enough functionality of course. -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part
Bug#1059857: discrepancy between upstream and downstream .service files
Hi! On Tue, Jan 02, 2024 at 02:19:39PM +0100, Michael Biebl wrote: > today I wanted to enable the iSCSI test in systemd: > https://salsa.debian.org/systemd-team/systemd/-/blob/debian/master/test/TEST-64-UDEV-STORAGE/test.sh?ref_type=heads#L29-34 > > For that I added test dependency on open-iscsi and tgt. > Unfortunately, this failed: > ``` > W: Failed to install '/usr/lib/systemd/system/iscsi-init.service' > I: Skipping program /usr/lib/systemd/system/iscsi-init.service as it cannot > be found and is flagged to be optional > W: Failed to install '/usr/lib/systemd/system/iscsi-onboot.service' > I: Skipping program /usr/lib/systemd/system/iscsi-onboot.service as it cannot > be found and is flagged to be optional > W: Failed to install '/usr/lib/systemd/system/iscsi-shutdown.service' > I: Skipping program /usr/lib/systemd/system/iscsi-shutdown.service as it > cannot be found and is flagged to be optional > W: Failed to install '/usr/lib/systemd/system/iscsi.service' > F: Failed to install /usr/lib/systemd/system/iscsi.service > make: Leaving directory > '/tmp/autopkgtest.yvEXDQ/build.n6X/real-tree/test/TEST-64-UDEV-STORAGE' > [13:12:37] --x-- Result of TEST-64-UDEV-STORAGE: 2 --x-- > ``` > > I notice that the Debian open-iscsi package ships custom service files > with a custom naming: [..] > > Would it be possible to use the upstream service files or at least align > the names? As noted briefly on IRC, TTBOMK each distro has its own service files, and upstream has yet another set of them. The names referend in your systemd test output look Fedora-specific to me. IMO these things would be interesting to consider (in any order): *) teach systemd tests about the Debian/Ubuntu setup *) try to converge more towards the upstream set, if that one is actually complete. Best, Chris
Bug#1059857: discrepancy between upstream and downstream .service files
Source: open-iscsi Version: 2.1.9-3 Severity: normal X-Debbugs-Cc: pkg-systemd-maintain...@lists.alioth.debian.org Hi, today I wanted to enable the iSCSI test in systemd: https://salsa.debian.org/systemd-team/systemd/-/blob/debian/master/test/TEST-64-UDEV-STORAGE/test.sh?ref_type=heads#L29-34 For that I added test dependency on open-iscsi and tgt. Unfortunately, this failed: ``` W: Failed to install '/usr/lib/systemd/system/iscsi-init.service' I: Skipping program /usr/lib/systemd/system/iscsi-init.service as it cannot be found and is flagged to be optional W: Failed to install '/usr/lib/systemd/system/iscsi-onboot.service' I: Skipping program /usr/lib/systemd/system/iscsi-onboot.service as it cannot be found and is flagged to be optional W: Failed to install '/usr/lib/systemd/system/iscsi-shutdown.service' I: Skipping program /usr/lib/systemd/system/iscsi-shutdown.service as it cannot be found and is flagged to be optional W: Failed to install '/usr/lib/systemd/system/iscsi.service' F: Failed to install /usr/lib/systemd/system/iscsi.service make: Leaving directory '/tmp/autopkgtest.yvEXDQ/build.n6X/real-tree/test/TEST-64-UDEV-STORAGE' [13:12:37] --x-- Result of TEST-64-UDEV-STORAGE: 2 --x-- ``` I notice that the Debian open-iscsi package ships custom service files with a custom naming: ./etc/systemd/iscsi-init.service.template ./etc/systemd/iscsi.service.template ./etc/systemd/iscsid.service.template ./etc/systemd/iscsiuio.service.template ./debian/iscsid.service ./debian/iscsiuio.service ./debian/open-iscsi.service Would it be possible to use the upstream service files or at least align the names? Regards, Michael
