Bug#1061266: [PATCH] sgmls: Fix type of signal handlers for C89 compatibility

[Agustin Martin]

El dom, 21 ene 2024 a las 19:45, Florian Weimer () escribió:
>
> Package: linuxdoc-tools
> Version:  0.9.82-1
> Tags: upstream patch
>
> This is another fallout from GCC 14 porting of Fedora.

Hi, Florian,

Thanks for the info. Seems it was fixed in already released 0.9.83.
This is the relevant commit

https://gitlab.com/agmartin/linuxdoc-tools/-/commit/fd6cf2b50d5bd9f013017b53edefe51e0e54f5c4

Please let me know if something is missing.

Regards,

-- 
Agustin

> Without this change, the outcome of two tests are altered due to
> compiler errors:
>
> -#define HAVE_EXTENDED_PRINTF 1
> +/* #define HAVE_EXTENDED_PRINTF 1 */
>
> -/* #define USE_ISASCII 1 */
> +#define USE_ISASCII 1
>
> (Not sure if the second change is a pre-existing bug or not.)
>
> diff --git a/sgmls-1.1/configure b/sgmls-1.1/configure
> index e674d24..898b522 100755
> --- a/sgmls-1.1/configure
> +++ b/sgmls-1.1/configure
> @@ -113,7 +113,7 @@ cat >doit.c <<\EOF
>  #include 
>  #include 
>
> -static int whoops()
> +static void whoops(int signo)
>  {
>_exit(1);
>  }
> @@ -459,7 +459,7 @@ cat >doit.c <<\EOF
>  #include 
>  #include 
>
> -static int whoops()
> +static void whoops(int signo)
>  {
>_exit(1);
>  }
> --
> 2.43.0
>

Bug#1061266: [PATCH] sgmls: Fix type of signal handlers for C89 compatibility

[Florian Weimer]

Package: linuxdoc-tools
Version:  0.9.82-1
Tags: upstream patch

This is another fallout from GCC 14 porting of Fedora.

Without this change, the outcome of two tests are altered due to
compiler errors:

-#define HAVE_EXTENDED_PRINTF 1 
+/* #define HAVE_EXTENDED_PRINTF 1 */

-/* #define USE_ISASCII 1 */
+#define USE_ISASCII 1

(Not sure if the second change is a pre-existing bug or not.)

diff --git a/sgmls-1.1/configure b/sgmls-1.1/configure
index e674d24..898b522 100755
--- a/sgmls-1.1/configure
+++ b/sgmls-1.1/configure
@@ -113,7 +113,7 @@ cat >doit.c <<\EOF
 #include 
 #include 
 
-static int whoops()
+static void whoops(int signo)
 {
   _exit(1);
 }
@@ -459,7 +459,7 @@ cat >doit.c <<\EOF
 #include 
 #include 
 
-static int whoops()
+static void whoops(int signo)
 {
   _exit(1);
 }
-- 
2.43.0