Bug#1062333: discover: NMU diff for 64-bit time_t transition

2024-01-31 Thread John Paul Adrian Glaubitz
Hi,

On Thu, 2024-02-01 at 04:31 +, mwhud...@debian.org wrote:
> Since turning on 64-bit time_t is being handled centrally through a change
> to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
> important that libraries affected by this ABI change all be uploaded close
> together in time.  Therefore I have prepared a 0-day NMU for discover
> which will initially be uploaded to experimental if possible, then to
> unstable after packages have cleared binary NEW.

Isn't a 0-day a bit too tight to give the maintainer some chance to answer?

Since this package is owned by the installer-team, I would suggest sending
a pull request on salsa instead [1].

Adrian

> [1] https://salsa.debian.org/installer-team/discover

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913



Bug#1062333: discover: NMU diff for 64-bit time_t transition

2024-01-31 Thread mwhudson
Source: discover
Version: 2.1.2-10
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
discover as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for discover
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru discover-2.1.2/debian/changelog discover-2.1.2/debian/changelog
--- discover-2.1.2/debian/changelog 2022-01-09 07:48:08.0 +
+++ discover-2.1.2/debian/changelog 2024-02-01 04:30:47.0 +
@@ -1,3 +1,10 @@
+discover (2.1.2-10.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Michael Hudson-Doyle   Thu, 01 Feb 2024 04:30:47 +
+
 discover (2.1.2-10) unstable; urgency=medium
 
   * Modernize packaging a little:
diff -Nru discover-2.1.2/debian/control discover-2.1.2/debian/control
--- discover-2.1.2/debian/control   2022-01-09 07:30:59.0 +
+++ discover-2.1.2/debian/control   2024-02-01 04:30:46.0 +
@@ -10,17 +10,20 @@
 
 Package: discover
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libdiscover2 (= ${binary:Version})
+Depends: ${shlibs:Depends}, ${misc:Depends}, libdiscover2t64 (= 
${binary:Version})
 Suggests: lsb-base
 Conflicts: discover1 (<< 2.0)
 Description: hardware identification system
- Discover is a hardware identification system based on the libdiscover2
+ Discover is a hardware identification system based on the libdiscover2t64
  library.  Discover provides a flexible interface that programs can
  use to report a wide range of information about the hardware that is
  installed on a Linux system.  In addition to reporting information,
  Discover includes support for doing hardware detection at boot time.
 
-Package: libdiscover2
+Package: libdiscover2t64
+Provides: ${t64:Provides}
+Replaces: libdiscover2
+Breaks: libdiscover2 (<< ${source:Version})
 Section: libs
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}, discover-data (>> 2.2004.04)
@@ -32,7 +35,7 @@
 Package: libdiscover-dev
 Section: libdevel
 Architecture: any
-Depends: ${misc:Depends}, libdiscover2 (= ${binary:Version}), libexpat1-dev
+Depends: ${misc:Depends}, libdiscover2t64 (= ${binary:Version}), libexpat1-dev
 Description: hardware identification library development files
  libdiscover is a library enabling identification of various PCI,
  PCMCIA, and USB devices.
diff -Nru discover-2.1.2/debian/libdiscover2.docs 
discover-2.1.2/debian/libdiscover2.docs
--- discover-2.1.2/debian/libdiscover2.docs 2022-01-09 06:08:06.0 
+
+++ discover-2.1.2/debian/libdiscover2.docs 1970-01-01 00:00:00.0 
+
@@ -1,3 +0,0 @@
-AUTHORS
-README
-RELEASE
diff -Nru discover-2.1.2/debian/libdiscover2.install 
discover-2.1.2/debian/libdiscover2.install
--- discover-2.1.2/debian/libdiscover2.install  2022-01-09 07:46:15.0 
+
+++ discover-2.1.2/debian/libdiscover2.install  1970-01-01 00:00:00.0 
+
@@ -1,7 +0,0 @@
-usr/share/discover/dtd/discover.dtd
-usr/share/discover/dtd/conffile.dtd
-usr/share/doc/discover/guide.html
-usr/share/doc/discover/guide.txt
-usr/share/man/man5/discover.conf.5