Bug#1062387: drogon: NMU diff for 64-bit time_t transition

2024-02-28 Thread Pierre-Elliott Bécue 
mwhud...@fastmail.fm wrote on 28/02/2024 at 03:25:55+0100:

> Dear maintainer,
>
> Please find attached a final version of this patch for the time_t
> transition.  This patch is being uploaded to unstable.
>
> Note that this adds a versioned build-dependency on dpkg-dev, to guard
> against accidental backports with a wrong ABI.
>
> Thanks!
>
>
> -- System Information:
> Debian Release: trixie/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
> Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not 
> set
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
>
> [2. text/plain; nmu_drogon.debdiff]...

That's great but you did not reply to my past question.

-- 
PEB


signature.asc
Description: PGP signature

Bug#1062387: drogon: NMU diff for 64-bit time_t transition

2024-02-27 Thread mwhudson 
Dear maintainer,

Please find attached a final version of this patch for the time_t
transition.  This patch is being uploaded to unstable.

Note that this adds a versioned build-dependency on dpkg-dev, to guard
against accidental backports with a wrong ABI.

Thanks!


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-21-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru drogon-1.8.7+ds/debian/changelog drogon-1.8.7+ds/debian/changelog
--- drogon-1.8.7+ds/debian/changelog2023-10-26 19:16:37.0 +
+++ drogon-1.8.7+ds/debian/changelog2024-02-28 02:24:07.0 +
@@ -1,3 +1,10 @@
+drogon (1.8.7+ds-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.  Closes: #1062387
+
+ -- Michael Hudson-Doyle   Wed, 28 Feb 2024 02:24:07 +
+
 drogon (1.8.7+ds-1) unstable; urgency=medium
 
   * Drop .github and .gitmodules from upstream source
diff -Nru drogon-1.8.7+ds/debian/control drogon-1.8.7+ds/debian/control
--- drogon-1.8.7+ds/debian/control  2023-06-13 15:46:48.0 +
+++ drogon-1.8.7+ds/debian/control  2024-02-28 02:24:07.0 +
@@ -2,7 +2,7 @@
 Maintainer: Pierre-Elliott Bécue 
 Section: web
 Priority: optional
-Build-Depends:
+Build-Depends: dpkg-dev (>= 1.22.5),
   chrpath,
   cmake,
   debhelper-compat (=13),
@@ -24,7 +24,10 @@
 Homepage: https://github.com/drogonframework/drogon
 Rules-Requires-Root: no
 
-Package: libdrogon1
+Package: libdrogon1t64
+Provides: ${t64:Provides}
+Replaces: libdrogon1
+Breaks: libdrogon1 (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: C++14/17-based HTTP application framework
@@ -38,7 +41,7 @@
 
 Package: libdrogon-dev
 Architecture: any
-Depends: libdrogon1 (= ${binary:Version}), libtrantor-dev, ${misc:Depends}
+Depends: libdrogon1t64 (= ${binary:Version}), libtrantor-dev, ${misc:Depends}
 Description: C++14/17-based HTTP application framework
  Drogon can be used to easily build various types of web application server
  programs using C++.
@@ -50,7 +53,7 @@
 
 Package: drogon
 Architecture: any
-Depends: libdrogon1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
+Depends: libdrogon1t64 (= ${binary:Version}), ${shlibs:Depends}, 
${misc:Depends}
 Description: C++14/17-based HTTP application framework
  Drogon can be used to easily build various types of web application server
  programs using C++.
diff -Nru drogon-1.8.7+ds/debian/libdrogon1.install 
drogon-1.8.7+ds/debian/libdrogon1.install
--- drogon-1.8.7+ds/debian/libdrogon1.install   2023-06-13 15:46:44.0 
+
+++ drogon-1.8.7+ds/debian/libdrogon1.install   1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*/libdrogon.so.*
diff -Nru drogon-1.8.7+ds/debian/libdrogon1t64.install 
drogon-1.8.7+ds/debian/libdrogon1t64.install
--- drogon-1.8.7+ds/debian/libdrogon1t64.install1970-01-01 
00:00:00.0 +
+++ drogon-1.8.7+ds/debian/libdrogon1t64.install2023-06-13 
15:46:44.0 +
@@ -0,0 +1 @@
+usr/lib/*/libdrogon.so.*
diff -Nru drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides 
drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides
--- drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides  1970-01-01 
00:00:00.0 +
+++ drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides  2024-02-28 
02:23:57.0 +
@@ -0,0 +1 @@
+libdrogon1t64: package-name-doesnt-match-sonames libdrogon1

Bug#1062387: drogon: NMU diff for 64-bit time_t transition

2024-02-10 Thread Pierre-Elliott Bécue 
Hi,

mwhud...@debian.org wrote on 01/02/2024 at 09:46:18+0100:

> Source: drogon
> Version: 1.8.7+ds-1
> Severity: serious
> Tags: patch pending
> Justification: library ABI skew on upgrade
> User: debian-...@lists.debian.org
> Usertags: time-t
>
> Dear maintainer,
>
> As part of the 64-bit time_t transition required to support 32-bit
> architectures in 2038 and beyond
> (https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
> drogon as a source package shipping runtime libraries whose ABI
> either is affected by the change in size of time_t, or could not be
> analyzed via abi-compliance-checker (and therefore to be on the safe
> side we assume is affected).
>
> To ensure that inconsistent combinations of libraries with their
> reverse-dependencies are never installed together, it is necessary to
> have a library transition, which is most easily done by renaming the
> runtime library package.
>
> Since turning on 64-bit time_t is being handled centrally through a change
> to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
> important that libraries affected by this ABI change all be uploaded close
> together in time.  Therefore I have prepared a 0-day NMU for drogon
> which will initially be uploaded to experimental if possible, then to
> unstable after packages have cleared binary NEW.
>
> Please find the patch for this NMU attached.
>
> If you have any concerns about this patch, please reach out ASAP.  Although
> this package will be uploaded to experimental immediately, there will be a
> period of several days before we begin uploads to unstable; so if information
> becomes available that your package should not be included in the transition,
> there is time for us to amend the planned uploads.

I don't really like the new name for the libs, will you change it back
at some point?

-- 
PEB



signature.asc
Description: PGP signature

Bug#1062387: drogon: NMU diff for 64-bit time_t transition

2024-02-01 Thread mwhudson 
Source: drogon
Version: 1.8.7+ds-1
Severity: serious
Tags: patch pending
Justification: library ABI skew on upgrade
User: debian-...@lists.debian.org
Usertags: time-t

Dear maintainer,

As part of the 64-bit time_t transition required to support 32-bit
architectures in 2038 and beyond
(https://wiki.debian.org/ReleaseGoals/64bit-time), we have identified
drogon as a source package shipping runtime libraries whose ABI
either is affected by the change in size of time_t, or could not be
analyzed via abi-compliance-checker (and therefore to be on the safe
side we assume is affected).

To ensure that inconsistent combinations of libraries with their
reverse-dependencies are never installed together, it is necessary to
have a library transition, which is most easily done by renaming the
runtime library package.

Since turning on 64-bit time_t is being handled centrally through a change
to the default dpkg-buildflags (https://bugs.debian.org/1037136), it is
important that libraries affected by this ABI change all be uploaded close
together in time.  Therefore I have prepared a 0-day NMU for drogon
which will initially be uploaded to experimental if possible, then to
unstable after packages have cleared binary NEW.

Please find the patch for this NMU attached.

If you have any concerns about this patch, please reach out ASAP.  Although
this package will be uploaded to experimental immediately, there will be a
period of several days before we begin uploads to unstable; so if information
becomes available that your package should not be included in the transition,
there is time for us to amend the planned uploads.



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.5.0-15-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru drogon-1.8.7+ds/debian/changelog drogon-1.8.7+ds/debian/changelog
--- drogon-1.8.7+ds/debian/changelog2023-10-26 19:16:37.0 +
+++ drogon-1.8.7+ds/debian/changelog2024-02-01 08:43:59.0 +
@@ -1,3 +1,10 @@
+drogon (1.8.7+ds-1.1) experimental; urgency=medium
+
+  * Non-maintainer upload.
+  * Rename libraries for 64-bit time_t transition.
+
+ -- Michael Hudson-Doyle   Thu, 01 Feb 2024 08:43:59 +
+
 drogon (1.8.7+ds-1) unstable; urgency=medium
 
   * Drop .github and .gitmodules from upstream source
diff -Nru drogon-1.8.7+ds/debian/control drogon-1.8.7+ds/debian/control
--- drogon-1.8.7+ds/debian/control  2023-06-13 15:46:48.0 +
+++ drogon-1.8.7+ds/debian/control  2024-02-01 08:43:58.0 +
@@ -24,7 +24,10 @@
 Homepage: https://github.com/drogonframework/drogon
 Rules-Requires-Root: no
 
-Package: libdrogon1
+Package: libdrogon1t64
+Provides: ${t64:Provides}
+Replaces: libdrogon1
+Breaks: libdrogon1 (<< ${source:Version})
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: C++14/17-based HTTP application framework
@@ -38,7 +41,7 @@
 
 Package: libdrogon-dev
 Architecture: any
-Depends: libdrogon1 (= ${binary:Version}), libtrantor-dev, ${misc:Depends}
+Depends: libdrogon1t64 (= ${binary:Version}), libtrantor-dev, ${misc:Depends}
 Description: C++14/17-based HTTP application framework
  Drogon can be used to easily build various types of web application server
  programs using C++.
@@ -50,7 +53,7 @@
 
 Package: drogon
 Architecture: any
-Depends: libdrogon1 (= ${binary:Version}), ${shlibs:Depends}, ${misc:Depends}
+Depends: libdrogon1t64 (= ${binary:Version}), ${shlibs:Depends}, 
${misc:Depends}
 Description: C++14/17-based HTTP application framework
  Drogon can be used to easily build various types of web application server
  programs using C++.
diff -Nru drogon-1.8.7+ds/debian/libdrogon1.install 
drogon-1.8.7+ds/debian/libdrogon1.install
--- drogon-1.8.7+ds/debian/libdrogon1.install   2023-06-13 15:46:44.0 
+
+++ drogon-1.8.7+ds/debian/libdrogon1.install   1970-01-01 00:00:00.0 
+
@@ -1 +0,0 @@
-usr/lib/*/libdrogon.so.*
diff -Nru drogon-1.8.7+ds/debian/libdrogon1t64.install 
drogon-1.8.7+ds/debian/libdrogon1t64.install
--- drogon-1.8.7+ds/debian/libdrogon1t64.install1970-01-01 
00:00:00.0 +
+++ drogon-1.8.7+ds/debian/libdrogon1t64.install2023-06-13 
15:46:44.0 +
@@ -0,0 +1 @@
+usr/lib/*/libdrogon.so.*
diff -Nru drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides 
drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides
--- drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides  1970-01-01 
00:00:00.0 +
+++ drogon-1.8.7+ds/debian/libdrogon1t64.lintian-overrides  2024-02-01 
08:43:58.0 +
@@ -0,0 +1 @@
+libdrogon1t64: package-name-doesnt-match-sonames libdrogon1