Bug#1063819: dh-sysuser: uses deprecated given/when

[Niko Tyni]

On Tue, Feb 13, 2024 at 01:07:59AM +0100, Lorenzo Puliti wrote:
> Package: dh-sysuser
> Version: 1.3.10+really1.4.4
> Severity: normal
> Tags: patch
> X-Debbugs-Cc: Niko Tyni , plore...@disroot.org
> 
> Building runit package I have

>dh_sysuser -O--sourcedirectory=runit-2.1.2/src
> given is deprecated at /usr/bin/dh_sysuser line 37.
> when is deprecated at /usr/bin/dh_sysuser line 38.
> when is deprecated at /usr/bin/dh_sysuser line 39.
> when is deprecated at /usr/bin/dh_sysuser line 46.
>dh_install -O--sourcedirectory=runit-2.1.2/src
>dh_installdocs -O--sourcedirectory=runit-2.1.2/src
>dh_buildinfo -O--sourcedirectory=runit-2.1.2/src
> 
> so I guess it needs an update like in dh-runit's  #1060709
> What I'm not sure is if this need to be fixed in unstable as
> possible or it can wait longer. The autopkgtest covers only
> sysuser-helper, so the package does not fail to build.
> Patch at the bottom.
> 
> Dear Niko, please bump the severity if this is urgent.

No particular urgency from my side, but thanks for asking.

The similar ones I filed at severity:serious for the Perl 5.38
transition were precisely because they were causing build or autopkgtest
failures. Those were technical blockers for getting the new perl into
testing. By your description this one is "just" cosmetic.

Of course it would be nice to fix it but it can wait :)

Thanks for your work on Debian,
-- 
Niko

Bug#1063819: dh-sysuser: uses deprecated given/when

[Lorenzo Puliti]

Package: dh-sysuser
Version: 1.3.10+really1.4.4
Severity: normal
Tags: patch
X-Debbugs-Cc: Niko Tyni , plore...@disroot.org

Building runit package I have

   create-stamp debian/debhelper-build-stamp
   dh_testroot -O--sourcedirectory=runit-2.1.2/src
   dh_prep -O--sourcedirectory=runit-2.1.2/src
   dh_installdirs -O--sourcedirectory=runit-2.1.2/src
   dh_auto_install -O--sourcedirectory=runit-2.1.2/src
   dh_sysuser -O--sourcedirectory=runit-2.1.2/src
given is deprecated at /usr/bin/dh_sysuser line 37.
when is deprecated at /usr/bin/dh_sysuser line 38.
when is deprecated at /usr/bin/dh_sysuser line 39.
when is deprecated at /usr/bin/dh_sysuser line 46.
   dh_install -O--sourcedirectory=runit-2.1.2/src
   dh_installdocs -O--sourcedirectory=runit-2.1.2/src
   dh_buildinfo -O--sourcedirectory=runit-2.1.2/src

so I guess it needs an update like in dh-runit's  #1060709
What I'm not sure is if this need to be fixed in unstable as
possible or it can wait longer. The autopkgtest covers only
sysuser-helper, so the package does not fail to build.
Patch at the bottom.

Dear Niko, please bump the severity if this is urgent.

Regards,
Lorenzo


diff --git a/dh_sysuser b/dh_sysuser
index 74195f9..fbe9c30 100755
--- a/dh_sysuser
+++ b/dh_sysuser
@@ -34,17 +34,17 @@ init();
 
 sub parse_options($conf, $options, $user) {
 foreach my $opt (split(/,/, $options)) {
-given ($opt) {
-when (/^home=(.*)$/)  { $conf->{home} = $1; }
-when (/^home$/)   {
+for ($opt) {
+if (/^home=(.*)$/)  { $conf->{home} = $1; }
+elsif (/^home$/)   {
 my $normal = $user;
 $normal =~ s/^_+//; # strip leading
 $normal =~ s/_+$//; # and trailing underscore
 $normal =~ s/^[Dd]ebian-//; # and discouraged debian- prefix
 $conf->{home} = "/var/lib/$normal";
 }
-when (/^defaults$/)   { "do nothing"; }
-default   { error("unknown option `$opt'"); }
+elsif (/^defaults$/)   { "do nothing"; }
+else   { error("unknown option `$opt'"); }
 }
 }
 }



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0van (SMP w/4 CPU threads; PREEMPT)
Kernel taint flags: TAINT_CPU_OUT_OF_SPEC, TAINT_FIRMWARE_WORKAROUND, 
TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: runit (via /run/runit.stopit)

Versions of packages dh-sysuser depends on:
ii  perl  5.38.2-3

dh-sysuser recommends no packages.

dh-sysuser suggests no packages.

-- no debconf information