Bug#1065203: regression: TypeError: find_username() missing 1 required positional argument: 'ssh_conf'

2024-04-26 Thread Ben Hutchings
Control: tag -1 patch

I've opened an MR to fix this at:
https://salsa.debian.org/debian/dput-ng/-/merge_requests/36

Ben.

-- 
Ben Hutchings
Everything should be made as simple as possible, but not simpler.
  - Albert Einstein



signature.asc
Description: This is a digitally signed message part


Bug#1065203: regression: TypeError: find_username() missing 1 required positional argument: 'ssh_conf'

2024-04-17 Thread Ritesh Raj Sarraf
Package: dput-ng
Version: 1.39
Followup-For: Bug #1065203
X-Debbugs-Cc: r...@debian.org

I've been suffering with same problems, and even more, with dput-ng for
some time now. Only now, that ssh-upload alos fails, do I realize I
should have reported the bug.


```
$ dput  mergerfs_2.33.5-1_source.changes
Uploading mergerfs using ftp to ftp-master (host: ftp.upload.debian.org; 
directory: /pub/UploadQueue/)
running allowed-distribution: check whether a local profile permits uploads to 
the target distribution
running protected-distribution: warn before uploading to distributions where a 
special policy applies
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running gpg: check GnuPG signatures before the upload
Uploading mergerfs_2.33.5-1.dsc
Could not upload file mergerfs_2.33.5-1.dsc: 229 Extended Passive Mode Entered 
(|||13868|).

$ dput  ssh-upload mergerfs_2.33.5-1_source.changes
Uploading mergerfs using scp to ssh-upload (host: ssh.upload.debian.org; 
directory: /srv/upload.debian.org/UploadQueue/)
running allowed-distribution: check whether a local profile permits uploads to 
the target distribution
running protected-distribution: warn before uploading to distributions where a 
special policy applies
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running gpg: check GnuPG signatures before the upload
Traceback (most recent call last):
  File "/usr/bin/dput", line 129, in 
upload_package(changes, args)
  File "/usr/lib/python3/dist-packages/dput/uploader.py", line 323, in 
invoke_dput
with uploader(profile['method'], profile,
  File "/usr/lib/python3.11/contextlib.py", line 137, in __enter__
return next(self.gen)
   ^^
  File "/usr/lib/python3/dist-packages/dput/uploader.py", line 170, in uploader
obj.initialize()
  File "/usr/lib/python3/dist-packages/dput/uploaders/scp.py", line 56, in 
initialize
login = find_username(self._config)
^^^
TypeError: find_username() missing 1 required positional argument: 'ssh_conf'
```


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-updates'), (500, 'stable-security'), (500, 
'oldstable-updates'), (500, 'oldstable-security'), (500, 'oldoldstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (100, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.7.9-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_IN.UTF-8, LC_CTYPE=en_IN.UTF-8 (charmap=UTF-8), LANGUAGE=en_US
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dput-ng depends on:
ii  python3   3.11.6-1
ii  python3-dput  1.39

dput-ng recommends no packages.

Versions of packages dput-ng suggests:
pn  dput-ng-doc  
pn  python3-twitter  
ii  rsync3.2.7-1+b1

-- no debconf information



Bug#1065203: regression: TypeError: find_username() missing 1 required positional argument: 'ssh_conf'

2024-03-01 Thread Yaroslav Halchenko
Package: dput-ng
Version: 1.38~bpo12+1
Severity: important

Used to work fine, today started to fail:

❯ dput neurosmaug git-annex_10.20240227-1~ndall+1_source.changes
Uploading git-annex using scp to neurosmaug (host: neurosmaug; directory: 
/home/neurodebian/deb/builds/ndbuild)
running allowed-distribution: check whether a local profile permits uploads 
to the target distribution
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running gpg: check GnuPG signatures before the upload
Not checking GPG signature due to allow_unsigned_uploads being set.
Traceback (most recent call last):
  File "/usr/bin/dput", line 129, in 
upload_package(changes, args)
  File "/usr/lib/python3/dist-packages/dput/uploader.py", line 323, in 
invoke_dput
with uploader(profile['method'], profile,
  File "/usr/lib/python3.11/contextlib.py", line 137, in __enter__
return next(self.gen)
   ^^
  File "/usr/lib/python3/dist-packages/dput/uploader.py", line 170, in 
uploader
obj.initialize()
  File "/usr/lib/python3/dist-packages/dput/uploaders/scp.py", line 56, in 
initialize
login = find_username(self._config)
^^^
TypeError: find_username() missing 1 required positional argument: 
'ssh_conf'


downgrade to

Version: 1.38~bpo12+1

resolved the issue.

Trickery might be due to "fqdn = neurosmaug" where "neurosmaug" is
defined within ~/.ssh/config like

Host neurosmaug
  User neurodebian
  ForwardAgent no
  HostName some.sensored.example.com
  Port 


Cheers,


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (900, 'testing'), (600, 'unstable'), (300, 'experimental'), (100, 
'stable-updates'), (100, 'stable-security'), (100, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.6.15-amd64 (SMP w/20 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, 
TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dput-ng depends on:
ii  python3   3.11.6-1
ii  python3-dput  1.38~bpo12+1

dput-ng recommends no packages.

Versions of packages dput-ng suggests:
pn  dput-ng-doc  
pn  python3-twitter  
ii  rsync3.2.7-1+b1

-- debconf-show failed