subject:"Bug#1066247\: uhub\: FTBFS\: adcclient.c\:178\:33\: error\: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’\? \[\-Werror=implicit\-function\-declaration\]"

Bug#1066247: uhub: FTBFS: adcclient.c:178:33: error: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? [-Werror=implicit-function-declaration]

2024-04-15 Thread Zixing Liu

Package: uhub
Followup-For: Bug #1066247
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/implicit-declarations.patch: Add missing function
prototypes.  (LP: #2061039).
  * debian/patches/riscv64-fix-ftbfs.patch: Add RISC-V architecture to
CPU list.  Thanks to Eric Long .  (LP: #2061039).


Thanks for considering the patch.


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), 
(100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/10 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru uhub-0.4.1/debian/patches/implicit-declarations.patch 
uhub-0.4.1/debian/patches/implicit-declarations.patch
--- uhub-0.4.1/debian/patches/implicit-declarations.patch   1969-12-31 
17:00:00.0 -0700
+++ uhub-0.4.1/debian/patches/implicit-declarations.patch   2024-04-15 
12:08:31.0 -0600
@@ -0,0 +1,20 @@
+Description: Add missing function prototypes
+ This fixes FTBFS on armhf
+Author: Zixing Liu 
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066247
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/uhub/+bug/2061039
+Forwarded: no
+Last-Update: 2024-04-15
+---
+Index: uhub/src/tools/adcclient.c
+===
+--- uhub.orig/src/tools/adcclient.c
 uhub/src/tools/adcclient.c
+@@ -88,6 +88,7 @@ static void ADC_client_on_login(struct A
+ static int ADC_client_parse_address(struct ADC_client* client, const char* 
arg);
+ static int ADC_client_on_recv_line(struct ADC_client* client, const char* 
line, size_t length);
+ static int ADC_client_send_queue(struct ADC_client* client);
++int ADC_client_connect_internal(struct ADC_client* client);
+ 
+ static void ADC_client_debug(struct ADC_client* client, const char* format, 
...)
+ {
diff -Nru uhub-0.4.1/debian/patches/riscv64-fix-ftbfs.patch 
uhub-0.4.1/debian/patches/riscv64-fix-ftbfs.patch
--- uhub-0.4.1/debian/patches/riscv64-fix-ftbfs.patch   1969-12-31 
17:00:00.0 -0700
+++ uhub-0.4.1/debian/patches/riscv64-fix-ftbfs.patch   2024-04-15 
12:09:00.0 -0600
@@ -0,0 +1,22 @@
+Description: Add RISC-V architecture to CPU list
+Author: Eric Long 
+Origin: 
https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=1020965;filename=riscv64-fix-ftbfs.patch;msg=5
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020965
+Bug-Ubuntu: https://bugs.launchpad.net/debian/+source/uhub/+bug/2061039
+Forwarded: no
+Reviewed-by: Zixing Liu 
+Last-Update: 2022-09-30
+---
+--- a/src/system.h
 b/src/system.h
+@@ -242,6 +242,10 @@
+ #define CPUINFO "s390"
+ #endif
+ 
++#if defined(__riscv)
++#define CPUINFO "RISC-V"
++#endif
++
+ /* Misc */
+ #ifdef MSG_NOSIGNAL
+ #define UHUB_SEND_SIGNAL MSG_NOSIGNAL
diff -Nru uhub-0.4.1/debian/patches/series uhub-0.4.1/debian/patches/series
--- uhub-0.4.1/debian/patches/series2022-09-12 03:10:42.0 -0600
+++ uhub-0.4.1/debian/patches/series2024-04-15 12:09:00.0 -0600
@@ -1,3 +1,5 @@
 fix-build-on-hurd-i386
 openssl1.1.patch
 arm64-fix-ftbfs.patch
+implicit-declarations.patch
+riscv64-fix-ftbfs.patch

Bug#1066247: uhub: FTBFS: adcclient.c:178:33: error: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum

Source: uhub
Version: 0.4.1-3.2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/list.c.o -MF 
> CMakeFiles/utils.dir/src/util/list.c.o.d -o 
> CMakeFiles/utils.dir/src/util/list.c.o -c /<>/src/util/list.c
> /<>/src/tools/adcclient.c: In function ‘event_callback’:
> /<>/src/tools/adcclient.c:178:33: error: implicit declaration of 
> function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? 
> [-Werror=implicit-function-declaration]
>   178 | ADC_client_connect_internal(client);
>   | ^~~
>   | ADC_client_connect
> [  9%] Building C object CMakeFiles/utils.dir/src/util/log.c.o
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/log.c.o -MF 
> CMakeFiles/utils.dir/src/util/log.c.o.d -o 
> CMakeFiles/utils.dir/src/util/log.c.o -c /<>/src/util/log.c
> [ 10%] Building C object CMakeFiles/utils.dir/src/util/memory.c.o
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/memory.c.o -MF 
> CMakeFiles/utils.dir/src/util/memory.c.o.d -o 
> CMakeFiles/utils.dir/src/util/memory.c.o -c /<>/src/util/memory.c
> [ 11%] Building C object CMakeFiles/utils.dir/src/util/misc.c.o
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/misc.c.o -MF 
> CMakeFiles/utils.dir/src/util/misc.c.o.d -o 
> CMakeFiles/utils.dir/src/util/misc.c.o -c /<>/src/util/misc.c
> [ 13%] Building C object CMakeFiles/utils.dir/src/util/rbtree.c.o
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/rbtree.c.o -MF 
> CMakeFiles/utils.dir/src/util/rbtree.c.o.d -o 
> CMakeFiles/utils.dir/src/util/rbtree.c.o -c /<>/src/util/rbtree.c
> [ 14%] Building C object CMakeFiles/utils.dir/src/util/threads.c.o
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/threads.c.o -MF 
> CMakeFiles/utils.dir/src/util/threads.c.o.d -o 
> CMakeFiles/utils.dir/src/util/threads.c.o -c 
> /<>/src/util/threads.c
> [ 15%] Building C object CMakeFiles/utils.dir/src/util/tiger.c.o
> /usr/bin/cc -DSSL_SUPPORT=1 -DSSL_USE_OPENSSL=1 -I/<>/src -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 
> -Wdate-time -D_FORTIFY_SOURCE=2 -O3 -DNDEBUG -fPIC -MD -MT 
> CMakeFiles/utils.dir/src/util/tiger.c.o -MF 
> CMakeFiles/utils.dir/src/util/tiger.c.o.d -o 
> CMakeFiles/utils.dir/src/util/tiger.c.o -c /<>/src/util/tiger.c
> cc1: some warnings being treated as errors
> make[3]: *** [CMakeFiles/adcclient.dir/build.make:79: 
> CMakeFiles/adcclient.dir/src/tools/adcclient.c.o] Error 1


The f

Bug#1066247: uhub: FTBFS: adcclient.c:178:33: error: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? [-Werror=implicit-function-declaration]

Bug#1066247: uhub: FTBFS: adcclient.c:178:33: error: implicit declaration of function ‘ADC_client_connect_internal’; did you mean ‘ADC_client_connect’? [-Werror=implicit-function-declaration]

2 matches

Site Navigation

Mail list logo

Footer information