Bug#1066314: regina-rexx: FTBFS: ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
El vie, 22 mar 2024 a las 12:01, Alen Zekulic () escribió: > > On Sun, Mar 17, 2024 at 21:41:44 +0100, Agustin Martin wrote: > > > Some time ago I played a bit with upgrading regina-rexx to a recent > > upstream version. I think I can find that stuff and try again with > > last upstream version. In case of success, I would like to push > > changes to regina-rexx salsa repo for further inspection. Let me know > > your POV. > > Hi Agustin, > > I have an objection to that! Please do not hesitate to NMU Regina > packages. Hi, Alen, Thanks for your support. I would like to wait some days for further feedback on the cross compilation stuff before actually NMUing. Everything will go to regina-rexx salsa git repo. Regards, -- Agustin
Bug#1066314: regina-rexx: FTBFS: ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
On Sun, Mar 17, 2024 at 21:41:44 +0100, Agustin Martin wrote: > Some time ago I played a bit with upgrading regina-rexx to a recent > upstream version. I think I can find that stuff and try again with > last upstream version. In case of success, I would like to push > changes to regina-rexx salsa repo for further inspection. Let me know > your POV. Hi Agustin, I have an objection to that! Please do not hesitate to NMU Regina packages. Thanks, -- Alen Zekulic signature.asc Description: PGP signature
Bug#1066314: regina-rexx: FTBFS: ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
Control: tags -1 +pending El dom, 17 mar 2024 a las 21:41, Agustin Martin () escribió: > > El vie, 15 mar 2024 a las 18:57, Agustin Martin > () escribió: > > > > Hi, Lucas and Alen. > > > > While it is easy to fix this particular error (see attached patch, > > from upstream repo), other similar error happens afterwards in my > > tests. The problem is that this package is way behind upstream and I > > think priority is to upgrade to a recent upstream version and then fix > > whatever is left. > > Hi, Alen, > > Some time ago I played a bit with upgrading regina-rexx to a recent > upstream version. I think I can find that stuff and try again with > last upstream version. In case of success, I would like to push > changes to regina-rexx salsa repo for further inspection. Let me know > your POV. Hi, Lucas and Alen I have been working on upgrading upstream version from 3.6 to 3.9.5. There have been a lot of upstream changes between both versions and I have tried to quickly look at them in case I find something I do not like. It was a quick look, so something may have gone unnoticed, better if maintainer can look better at it. I have upgraded all the Debian stuff to work with that new version, added some other changes I found interesting, and verified that everything builds in a recent pbuilder sid box, so I think package as I have it fixes this problem, thus the "pending" tag. I have committed everything to https://salsa.debian.org/debian/regina-rexx.git, including upstream and pristine-tar branches. I will leave some time for inspection and, if no one else uploads before and there are no objections, will upload NMU myself. In the meantime I would like to look at [#1027405: regina-rexx FTCBFS: builds for the build architecture] and see how to adjust supplied patch and deal with this problem. Note that regina-rexx package is marked for autoremoval from testing on 26 April. Regards, -- Agustin
Bug#1066314: regina-rexx: FTBFS: ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
El vie, 15 mar 2024 a las 18:57, Agustin Martin () escribió: > > Hi, Lucas and Alen. > > While it is easy to fix this particular error (see attached patch, > from upstream repo), other similar error happens afterwards in my > tests. The problem is that this package is way behind upstream and I > think priority is to upgrade to a recent upstream version and then fix > whatever is left. Hi, Alen, Some time ago I played a bit with upgrading regina-rexx to a recent upstream version. I think I can find that stuff and try again with last upstream version. In case of success, I would like to push changes to regina-rexx salsa repo for further inspection. Let me know your POV. Regards, -- Agustin
Bug#1066314: regina-rexx: FTBFS: ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
>
> This is most likely caused by a change in dpkg 1.22.6, that enabled
> -Werror=implicit-function-declaration. For more information, see
> https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
>
> Relevant part (hopefully):
> > cc -DNDEBUG -g -O2 -Werror=implicit-function-declaration
> > -ffile-prefix-map=/<>=. -fstack-protector-strong
> > -fstack-clash-protection -Wformat -Werror=format-security
+-fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2
-DREGINA_SHARE_DIRECTORY=\"//usr/share/regina-rexx\" -funsigned-char
-DREGINA_VERSION_DATE=\""31 Dec 2011"\" -DREGINA_VERSION_MAJOR=\"3\"
+-DREGINA_VERSION_MINOR=\"6\" -DREGINA_VERSION_SUPP=\"\"
-DHAVE_CONFIG_H-I. -I. -I./contrib-o rexxext.o -c ./rexxext.c
> > ./rexxext.c: In function ‘__regina_rex_getcallstack’:
> > ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’;
> > did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
> >95 | getcallstack( TSD, parms->value );
> > | ^~~~
> > | popcallstack
> > cc1: some warnings being treated as errors
> > make[1]: *** [Makefile:427: rexxext.o] Error 1
Hi, Lucas and Alen.
While it is easy to fix this particular error (see attached patch,
from upstream repo), other similar error happens afterwards in my
tests. The problem is that this package is way behind upstream and I
think priority is to upgrade to a recent upstream version and then fix
whatever is left.
Not tagging 'patch' since this change alone does not fix build.
Regards,
--- regina-rexx.orig/rexxext.c
+++ regina-rexx/rexxext.c
@@ -55,6 +55,8 @@
# endif
#endif
+extern void getcallstack( tsd_t *TSD, streng *stem );
+
streng *rex_userid( tsd_t *TSD, cparamboxptr parms )
{
#if defined(WIN32)
Bug#1066314: regina-rexx: FTBFS: ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did you mean ‘popcallstack’? [-Werror=implicit-function-declaration]
Source: regina-rexx Version: 3.6-2.4 Severity: serious Justification: FTBFS Tags: trixie sid ftbfs User: lu...@debian.org Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef Hi, During a rebuild of all packages in sid, your package failed to build on amd64. This is most likely caused by a change in dpkg 1.22.6, that enabled -Werror=implicit-function-declaration. For more information, see https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration Relevant part (hopefully): > cc -DNDEBUG -g -O2 -Werror=implicit-function-declaration > -ffile-prefix-map=/<>=. -fstack-protector-strong > -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection > -Wdate-time -D_FORTIFY_SOURCE=2 > -DREGINA_SHARE_DIRECTORY=\"//usr/share/regina-rexx\" -funsigned-char > -DREGINA_VERSION_DATE=\""31 Dec 2011"\" -DREGINA_VERSION_MAJOR=\"3\" > -DREGINA_VERSION_MINOR=\"6\" -DREGINA_VERSION_SUPP=\"\" -DHAVE_CONFIG_H > -I. -I. -I./contrib-o rexxext.o -c ./rexxext.c > ./rexxext.c: In function ‘__regina_rex_getcallstack’: > ./rexxext.c:95:7: error: implicit declaration of function ‘getcallstack’; did > you mean ‘popcallstack’? [-Werror=implicit-function-declaration] >95 | getcallstack( TSD, parms->value ); > | ^~~~ > | popcallstack > cc1: some warnings being treated as errors > make[1]: *** [Makefile:427: rexxext.o] Error 1 The full build log is available from: http://qa-logs.debian.net/2024/03/13/regina-rexx_3.6-2.4_unstable.log All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org or: https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.
