Bug#1066359: aview: FTBFS: main.c:30:86: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]
control: tags -1 patch
diff -Nru aview-1.3.0rc1/debian/changelog aview-1.3.0rc1/debian/changelog
--- aview-1.3.0rc1/debian/changelog 2024-04-01 05:32:50.0 +
+++ aview-1.3.0rc1/debian/changelog 2024-04-10 18:19:03.0 +
@@ -1,3 +1,10 @@
+aview (1.3.0rc1-9.2ubuntu1) noble; urgency=medium
+
+ * debian/patches/no-implicit-declarations.patch: add missing includes.
+Closes: #1066359.
+
+ -- Steve Langasek Wed, 10 Apr 2024 18:19:03 +
+
aview (1.3.0rc1-9.2build1) noble; urgency=medium
* No-change rebuild for CVE-2024-3094
diff -Nru aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
--- aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
1970-01-01 00:00:00.0 +
+++ aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch
2024-04-10 18:18:59.0 +
@@ -0,0 +1,15 @@
+Description: add missing includes
+Author: Steve Langasek
+Bug-Debian: https://bugs.debian.org/1066359
+Last-Update: 2024-04-10
+Forwarded: no
+
+Index: aview-1.3.0rc1/main.c
+===
+--- aview-1.3.0rc1.orig/main.c
aview-1.3.0rc1/main.c
+@@ -1,3 +1,4 @@
++#include
+ #include
+ #include
+ #include "image.h"
diff -Nru aview-1.3.0rc1/debian/patches/series
aview-1.3.0rc1/debian/patches/series
--- aview-1.3.0rc1/debian/patches/series2024-02-17 23:14:52.0
+
+++ aview-1.3.0rc1/debian/patches/series2024-04-10 18:18:13.0
+
@@ -2,3 +2,4 @@
01_manpages.patch
02_tmp_creation.patch
03_missing_library.patch
+no-implicit-declarations.patch
G.
On Wed, 13 Mar 2024 12:48:02 +0100 Lucas Nussbaum wrote:
Source: aview
Version: 1.3.0rc1-9.2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I. -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-Werror=implicit-function-declaration -ffile-prefix-map=/<>=.
-fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security
-fcf-protection -I/usr/include -c main.c
> main.c: In function ‘parse_cmdline’:
> main.c:30:86: error: implicit declaration of function ‘exit’
[-Werror=implicit-function-declaration]
>30 | if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) {
showhelp(argv[0]); exit(0); }
> |
^~~~
> main.c:6:1: note: include ‘’ or provide a declaration of ‘exit’
> 5 | #include "config.h"
> +++ |+#include
> 6 |
> main.c:30:86: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
>30 | if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) {
showhelp(argv[0]); exit(0); }
> |
^~~~
> main.c:30:86: note: include ‘’ or provide a declaration of ‘exit’
> main.c:31:66: warning: incompatible implicit declaration of built-in function
‘exit’ [-Wbuiltin-declaration-mismatch]
>31 | if (!strcmp(argv[i], "--version")) { showversion(argv[0]);
exit(0); }
> | ^~~~
> main.c:31:66: note: include ‘’ or provide a declaration of ‘exit’
> main.c:33:7: warning: incompatible implicit declaration of built-in function
‘exit’ [-Wbuiltin-declaration-mismatch]
>33 | exit(-1);
> | ^~~~
> main.c:33:7: note: include ‘’ or provide a declaration of ‘exit’
> main.c: In function ‘main’:
> main.c:49:9: warning: incompatible implicit declaration of built-in function
‘exit’ [-Wbuiltin-declaration-mismatch]
>49 | exit(-1);
> | ^~~~
> main.c:49:9: note: include ‘’ or provide a declaration of ‘exit’
> main.c:52:9: warning: incompatible implicit declaration of built-in function
‘exit’ [-Wbuiltin-declaration-mismatch]
>52 | exit(-1);
> | ^~~~
> main.c:52:9: note: include ‘’ or provide a declaration of ‘exit’
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:187: main.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/aview_1.3.0rc1-9.2_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results
OpenPGP_signature.asc
Description:
Bug#1066359: aview: FTBFS: main.c:30:86: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]
Package: aview Followup-For: Bug #1066359 User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu noble ubuntu-patch Control: tags -1 patch Please find attached a patch for this issue which has been uploaded to Ubuntu. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org diff -Nru aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch --- aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch 1969-12-31 16:00:00.0 -0800 +++ aview-1.3.0rc1/debian/patches/no-implicit-declarations.patch 2024-04-10 11:18:59.0 -0700 @@ -0,0 +1,15 @@ +Description: add missing includes +Author: Steve Langasek +Bug-Debian: https://bugs.debian.org/1066359 +Last-Update: 2024-04-10 +Forwarded: no + +Index: aview-1.3.0rc1/main.c +=== +--- aview-1.3.0rc1.orig/main.c aview-1.3.0rc1/main.c +@@ -1,3 +1,4 @@ ++#include + #include + #include + #include "image.h" diff -Nru aview-1.3.0rc1/debian/patches/series aview-1.3.0rc1/debian/patches/series --- aview-1.3.0rc1/debian/patches/series2024-02-17 15:14:52.0 -0800 +++ aview-1.3.0rc1/debian/patches/series2024-04-10 11:18:13.0 -0700 @@ -2,3 +2,4 @@ 01_manpages.patch 02_tmp_creation.patch 03_missing_library.patch +no-implicit-declarations.patch
Bug#1066359: aview: FTBFS: main.c:30:86: error: implicit declaration of function ‘exit’ [-Werror=implicit-function-declaration]
Source: aview
Version: 1.3.0rc1-9.2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration
Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I. -I. -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=.
> -fstack-protector-strong -fstack-clash-protection -Wformat
> -Werror=format-security -fcf-protection -I/usr/include -c main.c
> main.c: In function ‘parse_cmdline’:
> main.c:30:86: error: implicit declaration of function ‘exit’
> [-Werror=implicit-function-declaration]
>30 | if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) {
> showhelp(argv[0]); exit(0); }
> |
>^~~~
> main.c:6:1: note: include ‘’ or provide a declaration of ‘exit’
> 5 | #include "config.h"
> +++ |+#include
> 6 |
> main.c:30:86: warning: incompatible implicit declaration of built-in function
> ‘exit’ [-Wbuiltin-declaration-mismatch]
>30 | if (!strcmp(argv[i], "--help") || !strcmp(argv[i], "-h")) {
> showhelp(argv[0]); exit(0); }
> |
>^~~~
> main.c:30:86: note: include ‘’ or provide a declaration of ‘exit’
> main.c:31:66: warning: incompatible implicit declaration of built-in function
> ‘exit’ [-Wbuiltin-declaration-mismatch]
>31 | if (!strcmp(argv[i], "--version")) { showversion(argv[0]);
> exit(0); }
> | ^~~~
> main.c:31:66: note: include ‘’ or provide a declaration of ‘exit’
> main.c:33:7: warning: incompatible implicit declaration of built-in function
> ‘exit’ [-Wbuiltin-declaration-mismatch]
>33 | exit(-1);
> | ^~~~
> main.c:33:7: note: include ‘’ or provide a declaration of ‘exit’
> main.c: In function ‘main’:
> main.c:49:9: warning: incompatible implicit declaration of built-in function
> ‘exit’ [-Wbuiltin-declaration-mismatch]
>49 | exit(-1);
> | ^~~~
> main.c:49:9: note: include ‘’ or provide a declaration of ‘exit’
> main.c:52:9: warning: incompatible implicit declaration of built-in function
> ‘exit’ [-Wbuiltin-declaration-mismatch]
>52 | exit(-1);
> | ^~~~
> main.c:52:9: note: include ‘’ or provide a declaration of ‘exit’
> cc1: some warnings being treated as errors
> make[1]: *** [Makefile:187: main.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/03/13/aview_1.3.0rc1-9.2_unstable.log
All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results
A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects
If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
