Bug#1066379: loqui: FTBFS: loqui-core-gtk.gob:256:25: error: implicit declaration of function ‘account_list_dialog_open_for_connect’ [-Werror=implicit-function-declaration]

2024-04-10 Thread Nick Rosbrook
Package: loqui
Followup-For: Bug #1066379
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
Control: tags -1 patch

Dear Maintainer,

This FTBFS is due to a missing include of account_list_dialog.h. In
Ubuntu we applied this patch to fix it.

  * debian/patches: fix implicit declaration of
account_list_dialog_open_for_connect


Thanks for considering the patch.

-Nick
diff -Nru 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch
--- 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch 
1969-12-31 19:00:00.0 -0500
+++ 
loqui-0.7.0/debian/patches/0002-add-missing-include-account_list_dialog.h.patch 
2024-04-10 11:51:39.0 -0400
@@ -0,0 +1,16 @@
+Description: Fix implicit declaration of account_list_dialog_open_for_connect
+ The account_list_dialog.h header needs to be included for this.
+Author: Nick Rosbrook 
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/loqui/+bug/2060834
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1066379
+Last-Update: 2024-04-10
+--- a/src/loqui-core-gtk.gob
 b/src/loqui-core-gtk.gob
+@@ -63,6 +63,7 @@
+ #include "loqui_stock.h"
+ #include "prefs_general_upgrader.h"
+ #include "loqui-notifier-gtk.h"
++#include "account_list_dialog.h"
+ 
+ %}
+ 
diff -Nru loqui-0.7.0/debian/patches/series loqui-0.7.0/debian/patches/series
--- loqui-0.7.0/debian/patches/series   2021-08-14 23:24:56.0 -0400
+++ loqui-0.7.0/debian/patches/series   2024-04-10 11:47:31.0 -0400
@@ -1 +1,2 @@
 0001-Add-missing-Makefile.in.patch
+0002-add-missing-include-account_list_dialog.h.patch


Bug#1066379: loqui: FTBFS: loqui-core-gtk.gob:256:25: error: implicit declaration of function ‘account_list_dialog_open_for_connect’ [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: loqui
Version: 0.7.0-2
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include -I../libloqui -I../libloqui -I.. 
> -I.. -DG_LOG_DOMAIN=\"Loqui\"  -Wdate-time -D_FORTIFY_SOURCE=2 
> -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
> -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz 
> -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libmount 
> -I/usr/include/blkid -I/usr/include/fribidi -I/usr/include/cairo 
> -I/usr/include/pixman-1 -I/usr/include/gdk-pixbuf-2.0 
> -I/usr/include/x86_64-linux-gnu -I/usr/include/webp 
> -I/usr/include/gio-unix-2.0 -I/usr/include/cloudproviders 
> -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 
> -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 
> -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -pthread   -g 
> -DDATADIR=\""/usr/share"\"  -Wall -Wredundant-decls -Wmissing-declarations 
> -Wmissing-prototypes -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c 
> -o loqui-channel-entry-action-group-ui.o loqui-channel-entry-action-group-ui.c
> loqui-core-gtk.gob:256:25: error: implicit declaration of function 
> ‘account_list_dialog_open_for_connect’ [-Werror=implicit-function-declaration]
>   256 | 
> account_list_dialog_open_for_connect(GTK_WINDOW(self->app), 
> loqui_app_get_account_manager(self->app));
>   | ^~~~
> loqui-core-gtk.gob:260:17: warning: ‘gdk_threads_leave’ is deprecated 
> [-Wdeprecated-declarations]
>   260 | gdk_threads_leave();
>   | ^
> /usr/include/gtk-3.0/gdk/gdkthreads.h:48:10: note: declared here
>48 | void gdk_threads_leave(void);
>   |  ^
> In file included from ../libloqui/loqui-gobject-utils.h:24,
>  from ../libloqui/loqui-protocol.h:41,
>  from ../libloqui/loqui_protocol_manager.h:26,
>  from loqui-protocol-selection-dialog.h:37,
>  from loqui-protocol-selection-dialog.c:36:
> ../libloqui/loqui-utils.h:66:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>66 | G_CONST_RETURN gchar *loqui_utils_remove_return_code(gchar *str);
>   | ^
> ../libloqui/loqui-utils.h:95:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>95 | G_CONST_RETURN gchar* loqui_utils_remove_ipv6_prefix_(const gchar 
> *str);
>   | ^
> In file included from ../libloqui/loqui_channel_entry.h:25,
>  from ../libloqui/loqui_account.h:40,
>  from ../libloqui/loqui-protocol.h:42:
> ../libloqui/loqui_user.h:114:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>   114 | G_CONST_RETURN gchar *loqui_user_get_nick(LoquiUser *user);
>   | ^~~  
> ../libloqui/loqui_user.h:119:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>   119 | LOQUI_DEFINE_ACCESSOR_CONST_STRING_PROTOTYPE(LoquiUser, loqui_user, 
> username);
>   | ^
> ../libloqui/loqui_user.h:120:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>   120 | LOQUI_DEFINE_ACCESSOR_CONST_STRING_PROTOTYPE(LoquiUser, loqui_user, 
> hostname);
>   | ^
> ../libloqui/loqui_user.h:121:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>   121 | LOQUI_DEFINE_ACCESSOR_CONST_STRING_PROTOTYPE(LoquiUser, loqui_user, 
> realname);
>   | ^
> ../libloqui/loqui_user.h:122:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>   122 | LOQUI_DEFINE_ACCESSOR_CONST_STRING_PROTOTYPE(LoquiUser, loqui_user, 
> servername);
>   | ^
> ../libloqui/loqui_user.h:123:13: warning: Deprecated pre-processor symbol: 
> replace with "const"
>   123 | LOQUI_DEFINE_ACCESSOR_CONST_STRING_PROTOTYPE(LoquiUser, loqui_user, 
> away_message);
>   |