Bug#1066547: xf86-input-mtrack: FTBFS: src/gestures.c:763:13: error: implicit declaration of function ‘mtdev_empty’; did you mean ‘mtdev_get’? [-Werror=implicit-function-declaration]

2024-04-16 Thread Gianfranco Costamagna

updated diff:

debdiff xf86-input-mtrack_0.3.1-1.dsc xf86-input-mtrack_0.3.1-1.1.dsc
diff -Nru xf86-input-mtrack-0.3.1/debian/changelog 
xf86-input-mtrack-0.3.1/debian/changelog
--- xf86-input-mtrack-0.3.1/debian/changelog2015-06-02 07:09:33.0 
+0200
+++ xf86-input-mtrack-0.3.1/debian/changelog2024-04-16 23:32:48.0 
+0200
@@ -1,3 +1,11 @@
+xf86-input-mtrack (0.3.1-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * Add patch to fix implicit-function-declaration build failures
+(Closes: #1066547)
+
+ -- Gianfranco Costamagna   Tue, 16 Apr 2024 
23:32:48 +0200
+
 xf86-input-mtrack (0.3.1-1) unstable; urgency=medium
 
   * Upload to unstable.

diff -Nru 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
--- 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
 1970-01-01 01:00:00.0 +0100
+++ 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
 2024-04-16 23:32:48.0 +0200
@@ -0,0 +1,24 @@
+Description: Add patch to fix missing includes
+Author: Gianfranco Costamagna 
+Last-Update: 2024-04-16
+
+--- xf86-input-mtrack-0.3.1.orig/include/common.h
 xf86-input-mtrack-0.3.1/include/common.h
+@@ -33,6 +33,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+
+--- xf86-input-mtrack-0.3.1.orig/tools/mtrack-test.c
 xf86-input-mtrack-0.3.1/tools/mtrack-test.c
+@@ -23,6 +23,7 @@
+ #include "mtouch.h"
+ #include 
+ #include 
++#include 
+
+ void xf86Msg(int type, const char *format, ...)
+ {
diff -Nru xf86-input-mtrack-0.3.1/debian/patches/series 
xf86-input-mtrack-0.3.1/debian/patches/series
--- xf86-input-mtrack-0.3.1/debian/patches/series   2012-07-05 
09:57:49.0 +0200
+++ xf86-input-mtrack-0.3.1/debian/patches/series   2024-04-16 
23:32:48.0 +0200
@@ -1,3 +1,4 @@
 #drop-mtrack-test
 #aa
 upsteam-commit
+missing-includes-implicit-function-declaration-fix.patch


OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1066547: xf86-input-mtrack: FTBFS: src/gestures.c:763:13: error: implicit declaration of function ‘mtdev_empty’; did you mean ‘mtdev_get’? [-Werror=implicit-function-declaration]

2024-04-16 Thread Gianfranco Costamagna

control: tags -1 patch pending


Dear maintainer,

I've prepared an NMU for xf86-input-mtrack (versioned as 0.3.1-1.1) and
uploaded it.



diff -Nru xf86-input-mtrack-0.3.1/debian/changelog 
xf86-input-mtrack-0.3.1/debian/changelog
--- xf86-input-mtrack-0.3.1/debian/changelog2024-04-01 10:36:37.0 
+0200
+++ xf86-input-mtrack-0.3.1/debian/changelog2024-04-16 23:32:48.0 
+0200
@@ -1,3 +1,10 @@
+xf86-input-mtrack (0.3.1-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * Add patch to fix implicit-function-declaration build failures (Closes: 
#1066547)
+
+ -- Gianfranco Costamagna   Tue, 16 Apr 2024 
23:32:48 +0200
+
 xf86-input-mtrack (0.3.1-1build5) noble; urgency=medium

   * No-change rebuild for CVE-2024-3094
diff -Nru 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
--- 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
 1970-01-01 01:00:00.0 +0100
+++ 
xf86-input-mtrack-0.3.1/debian/patches/missing-includes-implicit-function-declaration-fix.patch
 2024-04-16 23:32:48.0 +0200
@@ -0,0 +1,24 @@
+Description: Add patch to fix missing includes
+Author: Gianfranco Costamagna 
+Last-Update: 2024-04-16
+
+--- xf86-input-mtrack-0.3.1.orig/include/common.h
 xf86-input-mtrack-0.3.1/include/common.h
+@@ -33,6 +33,7 @@
+ #include 
+ #include 
+ #include 
++#include 
+ #include 
+ #include 
+
+--- xf86-input-mtrack-0.3.1.orig/tools/mtrack-test.c
 xf86-input-mtrack-0.3.1/tools/mtrack-test.c
+@@ -23,6 +23,7 @@
+ #include "mtouch.h"
+ #include 
+ #include 
++#include 
+
+ void xf86Msg(int type, const char *format, ...)
+ {
diff -Nru xf86-input-mtrack-0.3.1/debian/patches/series 
xf86-input-mtrack-0.3.1/debian/patches/series
--- xf86-input-mtrack-0.3.1/debian/patches/series   2012-07-05 
09:57:49.0 +0200
+++ xf86-input-mtrack-0.3.1/debian/patches/series   2024-04-16 
23:32:48.0 +0200
@@ -1,3 +1,4 @@
 #drop-mtrack-test
 #aa
 upsteam-commit
+missing-includes-implicit-function-declaration-fix.patch



Bug#1066547: xf86-input-mtrack: FTBFS: src/gestures.c:763:13: error: implicit declaration of function ‘mtdev_empty’; did you mean ‘mtdev_get’? [-Werror=implicit-function-declaration]

2024-03-13 Thread Lucas Nussbaum
Source: xf86-input-mtrack
Version: 0.3.1-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -DHAVE_CONFIG_H -I.  -I./include/ -I/usr/include/xorg 
> -I/usr/include/pixman-1  -I/usr/include/xorg -fvisibility=hidden 
> -I/usr/include/pixman-1 -I/usr/include/X11/dri -I/usr/include/libdrm  -g -O2 
> -Werror=implicit-function-declaration -ffile-prefix-map=/<>=. 
> -fstack-protector-strong -fstack-clash-protection -Wformat 
> -Werror=format-security -fcf-protection -D_FORTIFY_SOURCE=2 -c -o 
> src/mtrack_test-gestures.o `test -f 'src/gestures.c' || echo 
> './'`src/gestures.c
> src/gestures.c: In function ‘gestures_sleep’:
> src/gestures.c:763:13: error: implicit declaration of function ‘mtdev_empty’; 
> did you mean ‘mtdev_get’? [-Werror=implicit-function-declaration]
>   763 | if (mtdev_empty(>dev)) {
>   | ^~~
>   | mtdev_get
> cc1: some warnings being treated as errors
> make[3]: *** [Makefile:663: src/mtrack_test-gestures.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/xf86-input-mtrack_0.3.1-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na=ign=7=7=only=ftbfs-20240313=lu...@debian.org=1=1=1=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.