Bug#1068046: /etc/firehol/ifupdown-firehol.sh: 71: [: -o: unexpected operator

[Jerome BENOIT]

Hello Jan, thanks for your report.
This is indeed a bashism ... which is not detected by checkbashisms(1).
I am on my way to apply your fix.
Thanks again, Jerome
--
Jerome BENOIT | calculus+at-rezozer^dot*net
https://qa.debian.org/developer.php?login=calcu...@rezozer.net
AE28 AE15 710D FF1D 87E5  A762 3F92 19A6 7F36 C68B

Bug#1068046: /etc/firehol/ifupdown-firehol.sh: 71: [: -o: unexpected operator

[Jan Petykiewicz]

Package: firehol
Version: 3.1.7+ds-3
Severity: normal
X-Debbugs-Cc: jspam+...@mpxd.net

Dear Maintainer,

When running ifup / ifdown, I run into error messages along the lines of

/etc/network/if-up.d/firehol: 71: [: -o: unexpected operator
/etc/network/if-pre-up.d/zz-firehol: 71: [: -o: unexpected operator
/etc/network/if-up.d/firehol: 71: [: -o: unexpected operator

I've worked around them locally by modifying /etc/firehol/ifupdown-firehol.sh to
run using /bin/bash rather than /bin/sh, but there may be a better solution.

Thanks,
Jan


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.7.9-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages firehol depends on:
ii  firehol-common   3.1.7+ds-3
ii  init-system-helpers  1.66

Versions of packages firehol recommends:
ii  fireqos  3.1.7+ds-3

Versions of packages firehol suggests:
pn  firehol-doc
pn  firehol-tools  
pn  ulogd2 

-- Configuration Files:
/etc/default/firehol changed [not included]
/etc/firehol/firehol.conf changed [not included]
/etc/firehol/ifupdown-firehol.sh changed [not included]

-- no debconf information