Bug#1069048: All NICs tried with same retries and timeouts?
Hi, Narcis Garcia wrote: > Could you review this patch for pre-wget phase, so it considers that a > NIC succeeds whet it acquires default gateway address? Checking if a NIC has a default gateway interface is not the right way to check if that nick should be in use. There are some configurations where it's ok that there would be *NO* default gateway. This is a perfectly valid DHCP setup. The only way to check if it worked, is simply what's done right now: check if dhclient gets an IP address. This part isn't even in the patch itself, the only thing that this patch does, is listing the cards with the link up, to pass it to the next step (ie: dhcp), which this patch doesn't touch (it's written properly already, and works with multiple network interface in the DEVICES= variable in /conf/param.conf). So there's IMO nothing more to do in this patch. Cheers, Thomas Goirand (zigo)
Bug#1069048: All NICs tried with same retries and timeouts?
Yes, you explained and I understood this time. Thank you for patience. Could you review this patch for pre-wget phase, so it considers that a NIC succeeds whet it acquires default gateway address? This way, 10 active NICs with only one of them with assignation of default gateway, will do the job. Thank you. -- Narcis Garcia __ I'm using this dedicated address because personal addresses aren't masked enough at this mail public archive. Public archive administrator should remove and omit any @, dot and mailto combinations against automated addresses collectors.
Bug#1069048: All NICs tried with same retries and timeouts?
Hi, If there's 10 NICs with a working dhcpd, only one will be configured (the first one), so that the live OS can fetch the squashfs. The fact that all 10 NICs will be configured with an IP address depends on what you put in the live image. By default, I believe all will be configured when the system is up, but *not* at the squashfs wget phase. So, what I'm fixing with this patch, is just the pre-wget phase, so that it tries all NICs. When the first one succeeds, the scripts don't attempt to get DHCP from another NIC at this stage. That's not different from the past behavior though. I hope you understood and I explained well enough this time! :) Cheers, Thomas Goirand (zigo)
Bug#1069048: All NICs tried with same retries and timeouts?
"the first NIC that gets an IP address from DHCP will be used" You mean second NIC that gets IP too, right? And also third one, yes? And if ten NICs get IP configuration from DHCP, they all will be configured; yes? "All NICs will be tried one by one, with the default 15 seconds timeout" You mean all NICs will be tried although first one succeeded already, am I right? -- Narcis Garcia __ I'm using this dedicated address because personal addresses aren't masked enough at this mail public archive. Public archive administrator should remove and omit any @, dot and mailto combinations against automated addresses collectors.
Bug#1069048: All NICs tried with same retries and timeouts?
Hi, With my patch, the first NIC that gets an IP address from DHCP will be used. All NICs will be tried one by one, with the default 15 seconds timeout. The order of NICs stays the same as before, as in: the first NIC that gets a link up will be tried first. So there's no regression possible. Cheers, Thomas Goirand (zigo)
Bug#1069048: All NICs tried with same retries and timeouts?
Hi Thomas, And I'm asking about your patch contribution, when no NIC fails: Will 5 linked NICs get network configuration from all respective DHCP-served networks, or only first succeeded one? -- Narcis Garcia __ I'm using this dedicated address because personal addresses aren't masked enough at this mail public archive. Public archive administrator should remove and omit any @, dot and mailto combinations against automated addresses collectors.
Bug#1069048: All NICs tried with same retries and timeouts?
Hi Narcis, The current behavior is that live-boot will attempt DHCP from the first NIC that is detected with link up. Cheers, Thomas Goirand (zigo)
Bug#1069048: All NICs tried with same retries and timeouts?
What is the behaviour if computer has 5 NICs and all of them are linked to a DHCP-served network? Will all of them get network configuration or only first succeeded one? -- Narcis Garcia __ I'm using this dedicated address because personal addresses aren't masked enough at this mail public archive. Public archive administrator should remove and omit any @, dot and mailto combinations against automated addresses collectors.
