Bug#1069346: please don't auto-enable the shipped timers

2024-05-07 Thread Daniel Swarbrick

Hi Evgeni,

This is possibly behaviour that has been carried over from when the 
textfile collectors were part of the prometheus-node-exporter package, 
prior to upstream splitting them out into their own git repo.


If you look closely, you will see that the systemd timers (with the 
exception of the apt collector) contain Condition... clauses, which will 
prevent them from starting if the relevant hardware is not found on the 
host. So yes, they are /enabled/ in the sense that systemd will process 
them at boot, but they won't /start/ if not applicable (even if 
attempted to be started manually) - and obviously if the timers do not 
start, then the service units won't be automatically triggered either. 
At most, you should get one log entry per timer, stating that it was not 
started, e.g.:


May 08 07:50:53 vega systemd[1]: 
prometheus-node-exporter-ipmitool-sensor.timer - Run ipmitool sensor 
metrics collection every minute was skipped because of an unmet 
condition check (ConditionDirectoryNotEmpty=/sys/class/ipmi).


Regards,
Daniel



OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1069346: please don't auto-enable the shipped timers

2024-04-20 Thread Evgeni Golov
Package: prometheus-node-exporter-collectors
Version: 0.0~git20230203.6f710f8-1

Ohai,

I know it's custom in Debian to auto-enable services when they are
installed, however I think that the broad variety of timers present in
the collectors package deserves a different treatment, as people usually
don't want all collectors enabled on a given machine (vs when they
install the "foo" daemon package, they usually want "food" running).

TIA
Evgeni

PS: filed against the version in stable, as that's what I have
installed, but I didn't see anything in packaging git or changelog that
says the newer versions behave differently.