Bug#1069755: libntlm0: broken symlink: README -> README.md
On Fri, 2024-05-03 at 13:35 +0200, Simon Josefsson wrote: > I wonder why no QA tool reported this? As implied by the usertags I used, the adequate tool found it: http://bonedaddy.net/pabs3/log/2013/02/23/inadequate-software/ In addition, piuparts has a test for broken symlinks too, and as well as that it runs adequate, which also found the broken symlink: https://piuparts.debian.org/sid/pass/libntlm0_1.8-2.log > Seems like a simple thing for lintian to discover? For this specific case lintian could do something, but in the general case that is impossible, because symlinks can point at files owned by another package, which could be in depends, or recommends or suggests, or even be something the sysadmin is expected to download later. > Or did you use some tool to discover this that isn't linked from the PTS? The piuparts pages are only linked from the PTS when there is an error, but invalid symlinks and most adequate issues don't count as errors. Perhaps it should change to always link piuparts in the right panel and to raise minor TODO items when symlink and adequate issues are present. > A patch like the one below seems to fix this. But maybe we should raise > a lintian wishlist bug report too. Feel free to raise any extra bugs. Please XCC me if you do. -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
Bug#1069755: libntlm0: broken symlink: README -> README.md
Paul Wise writes: > Package: libntlm0 > Version: 1.8-2 > Severity: normal > File: /usr/share/doc/libntlm0/README > User: debian...@lists.debian.org > Usertags: adequate broken-symlink > > libntlm0 1.8-2 introduced a broken symlink: > > /usr/share/doc/libntlm0/README -> README.md > > This appears to be because upstream switched README to a symlink to > README.md and debian/libntlm0.docs was not updated to use README.md. Thanks for catching this. I wonder why no QA tool reported this? Seems like a simple thing for lintian to discover? Or did you use some tool to discover this that isn't linked from the PTS? A patch like the one below seems to fix this. But maybe we should raise a lintian wishlist bug report too. /Simon From 4144c80941d5d099b2ff6678750bae5419c74b6a Mon Sep 17 00:00:00 2001 From: Simon Josefsson Date: Fri, 3 May 2024 13:31:03 +0200 Subject: [PATCH] docs: Ship README.md. Closes: #1069755. --- debian/changelog | 6 ++ debian/libntlm0.docs | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/debian/changelog b/debian/changelog index 8e2d40a..0ae4286 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +libntlm (1.8-3) UNRELEASED; urgency=medium + + * docs: Ship README.md. Closes: #1069755. + + -- Simon Josefsson Fri, 03 May 2024 13:31:01 +0200 + libntlm (1.8-2) unstable; urgency=medium * Upload to unstable. diff --git a/debian/libntlm0.docs b/debian/libntlm0.docs index 05c2865..41b2efb 100644 --- a/debian/libntlm0.docs +++ b/debian/libntlm0.docs @@ -1,4 +1,4 @@ AUTHORS NEWS -README +README.md THANKS -- 2.34.1 signature.asc Description: PGP signature
Bug#1069755: libntlm0: broken symlink: README -> README.md
Package: libntlm0 Version: 1.8-2 Severity: normal File: /usr/share/doc/libntlm0/README User: debian...@lists.debian.org Usertags: adequate broken-symlink libntlm0 1.8-2 introduced a broken symlink: /usr/share/doc/libntlm0/README -> README.md This appears to be because upstream switched README to a symlink to README.md and debian/libntlm0.docs was not updated to use README.md. -- System Information: Debian Release: trixie/sid APT prefers testing-debug APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental'), (500, 'stable-updates'), (500, 'stable-security-debug'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), (500, 'buildd-proposed-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 6.7.9-amd64 (SMP w/4 CPU threads; PREEMPT) Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages libntlm0:amd64 depends on: ii libc6 2.37-18 libntlm0:amd64 recommends no packages. libntlm0:amd64 suggests no packages. -- bye, pabs https://wiki.debian.org/PaulWise signature.asc Description: This is a digitally signed message part
