Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2006-03-09 Thread Brendan O'Dea 
tags 291391 + pending
thanks

On Wed, Mar 08, 2006 at 09:17:44PM -0800, Russ Allbery wrote:
Brendan, here's what I applied upstream (line numbers will be much
different):

Many thanks Russ,

Applied, pending upload.

--bod


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2006-03-08 Thread Russ Allbery 
Brendan O'Dea [EMAIL PROTECTED] writes:
 On Tue, Mar 07, 2006 at 12:02:53AM -0800, Andrew Pimlott wrote:

 This old bug just tripped me.  It appears trivial to fix with this
 patch.  I don't know roff, but this seems to have the right effect, and
 you notice the tip-off bv (bar vertical, box vertical?).  Someone
 who knows roff could tell if this is the right fix (is tchrist still
 active?), but this change seems harmless.
 
 --- /usr/share/perl/5.8.8/Pod/Man.pm 2006-03-07 00:01:39.0 -0800
 +++ -2006-03-07 00:02:16.902649000 -0800
 @@ -74,11 +74,10 @@
 ..
 .\ Set up some character translations and predefined strings.  \*(-- will
 .\ give an unbreakable dash, \*(PI will give pi, \*(L will give a left
 -.\ double quote, and \*(R will give a right double quote.  | will give a
 -.\ real vertical bar.  \*(C+ will give a nicer C++.  Capital omega is used 
 to
 +.\ double quote, and \*(R will give a right double quote.
 +.\ \*(C+ will give a nicer C++.  Capital omega is used to
 .\ do unbreakable dashes and therefore won't be available.  \*(C` and \*(C'
 .\ expand to `' in nroff, nothing in troff, for use with C.
 -.tr \(*W-|\(bv\*(Tr
 .ds C+ C\v'-.1v'\h'-1p'\s-2+\h'-1p'+\s0\v'.1v'\h'-1p'
 .ie n \{\
 .ds -- \(*W-

 Russ Allbery maintains podlators now.

 This may well be fixed in the most recent version for cases of literal
 text (which I presume is the case you're trying to fix).

 Russ, similarly to - is literal text, should (is?) | now left
 unchanged?

\(bv is actually bar vertical not box vertical; see groff_char(7).  I
don't know the original motivation for translating | into \(bv, but it's
been there for years, probably since Tom's original pod2man.  I presume he
thought it was a good idea, at least at the time.  However, that time was
before Unicode was even invented.

In the new Unicode world, I think molesting unsuspecting ASCII characters
is much less of a good idea than it originally was; back then, this sort
of transformation only affected the troff output, but now, you get Unicode
in man output.  I think this patch is correct, and I'm going to apply it
upstream.  Brendan, the Perl maintainers are still debating over whether
to include Pod::Simple and the new podlators in stable, so in the meantime
I'd just go ahead and apply this patch to the Debian Perl package.

I'm a little suspicious of the \*(W fiddling as well, but I'm not sure I
understand exactly why that's being done.  The comment says that it's
turning \*(-- into an unbreakable dash, but I don't understand why that's
being done by outputting a Greek capital omega followed by a dash and then
using .tr to change the omega back to a dash.  If anyone understands what
the motivation might be here, please explain it to me?

-- 
Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2006-03-08 Thread Andrew Pimlott 
On Wed, Mar 08, 2006 at 08:18:46PM -0800, Russ Allbery wrote:
 I'm a little suspicious of the \*(W fiddling as well, but I'm not sure I
 understand exactly why that's being done.  The comment says that it's
 turning \*(-- into an unbreakable dash, but I don't understand why that's
 being done by outputting a Greek capital omega followed by a dash and then
 using .tr to change the omega back to a dash.  If anyone understands what
 the motivation might be here, please explain it to me?

To clarify, I only meant to remove the special treatment of the vertical
bar.  I had no idea that line was also doing something else, so any
other effect it had was unintentional.

Andrew


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2006-03-08 Thread Russ Allbery 
Andrew Pimlott [EMAIL PROTECTED] writes:
 On Wed, Mar 08, 2006 at 08:18:46PM -0800, Russ Allbery wrote:

 I'm a little suspicious of the \*(W fiddling as well, but I'm not sure
 I understand exactly why that's being done.  The comment says that it's
 turning \*(-- into an unbreakable dash, but I don't understand why
 that's being done by outputting a Greek capital omega followed by a
 dash and then using .tr to change the omega back to a dash.  If anyone
 understands what the motivation might be here, please explain it to me?

 To clarify, I only meant to remove the special treatment of the vertical
 bar.  I had no idea that line was also doing something else, so any
 other effect it had was unintentional.

Oh, thanks for mentioning this.  I took a closer look at your patch and
realized that it actually would cause -- handling to leave a Greek omega
behind.  It may be that we want to move all of that stuff, but if so more
lines have to be removed.

Brendan, here's what I applied upstream (line numbers will be much
different):

@@ -1303,11 +1303,11 @@ sub preamble_template {
 ..
 .\ Set up some character translations and predefined strings.  \*(-- will
 .\ give an unbreakable dash, \*(PI will give pi, \*(L will give a left
-.\ double quote, and \*(R will give a right double quote.  | will give a
-.\ real vertical bar.  \*(C+ will give a nicer C++.  Capital omega is used to
-.\ do unbreakable dashes and therefore won't be available.  \*(C` and \*(C'
-.\ expand to `' in nroff, nothing in troff, for use with C.
-.tr \(*W-|\(bv\*(Tr
+.\ double quote, and \*(R will give a right double quote.  \*(C+ will
+.\ give a nicer C++.  Capital omega is used to do unbreakable dashes and
+.\ therefore won't be available.  \*(C` and \*(C' expand to `' in nroff,
+.\ nothing in troff, for use with C.
+.tr \(*W-
 .ds C+ C\v'-.1v'\h'-1p'\s-2+\h'-1p'+\s0\v'.1v'\h'-1p'
 .ie n \{\
 .ds -- \(*W-

I don't think the \*(Tr stuff was doing anything; it looked like a way to
add other transforms later, but the Tr string was never defined.

-- 
Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2006-03-07 Thread Andrew Pimlott 
This old bug just tripped me.  It appears trivial to fix with this
patch.  I don't know roff, but this seems to have the right effect, and
you notice the tip-off bv (bar vertical, box vertical?).  Someone
who knows roff could tell if this is the right fix (is tchrist still
active?), but this change seems harmless.

Andrew

--- /usr/share/perl/5.8.8/Pod/Man.pm2006-03-07 00:01:39.0 -0800
+++ -   2006-03-07 00:02:16.902649000 -0800
@@ -74,11 +74,10 @@
 ..
 .\ Set up some character translations and predefined strings.  \*(-- will
 .\ give an unbreakable dash, \*(PI will give pi, \*(L will give a left
-.\ double quote, and \*(R will give a right double quote.  | will give a
-.\ real vertical bar.  \*(C+ will give a nicer C++.  Capital omega is used to
+.\ double quote, and \*(R will give a right double quote.
+.\ \*(C+ will give a nicer C++.  Capital omega is used to
 .\ do unbreakable dashes and therefore won't be available.  \*(C` and \*(C'
 .\ expand to `' in nroff, nothing in troff, for use with C.
-.tr \(*W-|\(bv\*(Tr
 .ds C+ C\v'-.1v'\h'-1p'\s-2+\h'-1p'+\s0\v'.1v'\h'-1p'
 .ie n \{\
 .ds -- \(*W-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2006-03-07 Thread Brendan O'Dea 
On Tue, Mar 07, 2006 at 12:02:53AM -0800, Andrew Pimlott wrote:
This old bug just tripped me.  It appears trivial to fix with this
patch.  I don't know roff, but this seems to have the right effect, and
you notice the tip-off bv (bar vertical, box vertical?).  Someone
who knows roff could tell if this is the right fix (is tchrist still
active?), but this change seems harmless.

--- /usr/share/perl/5.8.8/Pod/Man.pm   2006-03-07 00:01:39.0 -0800
+++ -  2006-03-07 00:02:16.902649000 -0800
@@ -74,11 +74,10 @@
 ..
 .\ Set up some character translations and predefined strings.  \*(-- will
 .\ give an unbreakable dash, \*(PI will give pi, \*(L will give a left
-.\ double quote, and \*(R will give a right double quote.  | will give a
-.\ real vertical bar.  \*(C+ will give a nicer C++.  Capital omega is used to
+.\ double quote, and \*(R will give a right double quote.
+.\ \*(C+ will give a nicer C++.  Capital omega is used to
 .\ do unbreakable dashes and therefore won't be available.  \*(C` and \*(C'
 .\ expand to `' in nroff, nothing in troff, for use with C.
-.tr \(*W-|\(bv\*(Tr
 .ds C+ C\v'-.1v'\h'-1p'\s-2+\h'-1p'+\s0\v'.1v'\h'-1p'
 .ie n \{\
 .ds -- \(*W-

Russ Allbery maintains podlators now.

This may well be fixed in the most recent version for cases of literal
text (which I presume is the case you're trying to fix).

Russ, similarly to - is literal text, should (is?) | now left
unchanged?

--bod


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2005-01-22 Thread Brendan O'Dea 
reassign 291391 groff
thanks

On Thu, Jan 20, 2005 at 02:27:57PM +, Scott James Remnant wrote:
pod2man inserts a block of groffese to turn the ordinary, every day '|'
character (U+007C VERTICAL LINE = VERTICAL BAR) into the extra-ordinary
'???' character (U+2502 BOX DRAWINGS LIGHT VERTICAL).

This means, for instance, that '$|' gets turned into '$???', '||' into
'??', and so on.

pod2man doesn't appear to be doing anything special with vertical bars,
but it appears that groff is (for utf8 at any rate).  See attached
test.pod and outputs from the following:

  pod2man test.pod test.roff
  groff -Tlatin1 -man test.roff test.latin1
  groff -Tutf8 -man test.roff test.utf8

Note that the | is unmolested in all but the last (test.utf8).

--bod
=head1 NAME

test

=head1 DESCRIPTION

Test for Bug#291391.

Bar here: |

and here: |

=cut


test.roff
Description: Troff document
TEST(1)   User Contributed Perl Documentation  TEST(1)



NNAAMMEE
   test

DDEESSCCRRIIPPTTIIOONN
   Test for Bug#291391.

   Bar here: |

   and here: |



perl v5.8.4   2005-01-23   TEST(1)
TEST(1)   User Contributed Perl Documentation  TEST(1)



NNAAMMEE
   test

DDEESSCCRRIIPPTTIIOONN
   Test for Bug#291391.

   Bar here: │

   and here: │



perl v5.8.4   2005‐01‐23   
TEST(1)

Bug#291391: pod2man turns VERTICAL BAR (pipe) into BOX DRAWINGS LIGHT VERTICAL

2005-01-20 Thread Scott James Remnant 
Package: perl
Version: 5.8.4-2ubuntu0.2
Severity: normal

pod2man inserts a block of groffese to turn the ordinary, every day '|'
character (U+007C VERTICAL LINE = VERTICAL BAR) into the extra-ordinary
'' character (U+2502 BOX DRAWINGS LIGHT VERTICAL).

This means, for instance, that '$|' gets turned into '$', '||' into
'', and so on.

-- System Information:
Debian Release: testing/unstable
Architecture: i386 (i686)
Kernel: Linux 2.6.8.1-3-686
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8

Versions of packages perl depends on:
ii  libc6  2.3.2.ds1-13ubuntu2.2 GNU C Library: Shared libraries an
ii  libdb4.2   4.2.52-16ubuntu2  Berkeley v4.2 Database Libraries [
ii  libgdbm3   1.8.3-2   GNU dbm database routines (runtime
ii  perl-base  5.8.4-2ubuntu0.2  The Pathologically Eclectic Rubbis
ii  perl-modules   5.8.4-2ubuntu0.2  Core Perl modules.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]