Bug#292110: munin-node: postfix_mailstats uses incorrect offset for determining reject code

2005-01-25 Thread Jimmy Olsen 
tags 292110 +fixed-upstream
thanks,

Once upon a time, Micah Anderson [EMAIL PROTECTED] sagely scribed:
 
 The plugin says:
 
   $rejects-{$codes[13]} ++;
   
 That should be a 10, I've attached a patch that changes this.

I've modified the plugin so it catches both cases.

Changes have been made to CVS 1.2 and 1.3.


-jo :-)


signature.asc
Description: Digital signature

Bug#292110: munin-node: postfix_mailstats uses incorrect offset for determining reject code

2005-01-24 Thread Micah Anderson 
Package: munin-node
Version: 1.0.5-1
Severity: normal
Tags: patch

The newer postfix logs produce the error 450 for a reject at a
different location, the subscript for looking for this in the plugin
is 13, it should now be 10, if you will look at this example log line:

Jan 24 06:25:44 buffy postfix/smtpd[9269]: NOQUEUE: reject: MAIL from 
K56-ip-415.indo.net.id[202.159.125.156]: 450 
[EMAIL PROTECTED]: Sender address rejected: Domain not found; from=[EMAIL 
PROTECTED] proto=ESMTP helo=riseup.net

and you count (starting at 0) from the beginning, you will find that
the 450 is printed on element 10, not thirteen. The plugin says:

$rejects-{$codes[13]} ++;

That should be a 10, I've attached a patch that changes this.

Micah



-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (990, 'testing'), (600, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7-1-k7
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages munin-node depends on:
ii  libnet-server-perl0.87-2 An extensible, general perl server
ii  perl  5.8.4-5Larry Wall's Practical Extraction 
ii  procps1:3.2.1-2  The /proc file system utilities

-- no debconf information
--- /usr/share/munin/plugins/postfix_mailstats  2005-01-05 16:52:26.0 
-0600
+++ /tmp/postfix_mailstats  2005-01-25 00:17:23.0 -0600
@@ -209,7 +209,7 @@
elsif ($line =~ /reject:/)
{
my @codes = split (/\s+/, $line);
-   $rejects-{$codes[13]} ++;
+   $rejects-{$codes[10]} ++;
}
 }
 close(LOGFILE);