Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-31 Thread Andreas Jochens
On 05-Mar-31 09:39, Nathan Scott wrote:
 On Wed, Mar 30, 2005 at 08:16:29AM +0200, Andreas Jochens wrote:
  
  I still get the attached error message even with all your patches 
  applied.
  
  Sorry for my delayed answer and thank you for your help.
 
 No problem.  This patch should resolve those errors, any further
 problems with this applied?

There were three more problems in check.c, command.c and type.c.

When those are fixed, the compilation succeeds. The attached
patch against the current 'unstable' version of xfsprogs
includes your patches and similar fixes for check.c, 
command.c and type.c.

Regards
Andreas Jochens

diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agf.c ./db/agf.c
--- ../tmp-orig/xfsprogs-2.6.26/db/agf.c2003-05-01 08:00:49.0 
+0200
+++ ./db/agf.c  2005-03-30 08:11:34.0 +0200
@@ -31,7 +31,6 @@
  */
 
 #include xfs/libxfs.h
-#include agf.h
 #include command.h
 #include type.h
 #include faddr.h
@@ -41,6 +40,7 @@
 #include bit.h
 #include output.h
 #include init.h
+#include agf.h
 
 static int agf_f(int argc, char **argv);
 static void agf_help(void);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agf.h ./db/agf.h
--- ../tmp-orig/xfsprogs-2.6.26/db/agf.h2003-04-29 08:08:41.0 
+0200
+++ ./db/agf.h  2005-03-30 08:11:34.0 +0200
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  agf_flds[];
 extern const struct field  agf_hfld[];
 
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agfl.c ./db/agfl.c
--- ../tmp-orig/xfsprogs-2.6.26/db/agfl.c   2003-05-01 08:00:49.0 
+0200
+++ ./db/agfl.c 2005-03-30 08:11:34.0 +0200
@@ -31,7 +31,6 @@
  */
 
 #include xfs/libxfs.h
-#include agfl.h
 #include command.h
 #include type.h
 #include faddr.h
@@ -41,6 +40,7 @@
 #include bit.h
 #include output.h
 #include init.h
+#include agfl.h
 
 static int agfl_bno_size(void *obj, int startoff);
 static int agfl_f(int argc, char **argv);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agfl.h ./db/agfl.h
--- ../tmp-orig/xfsprogs-2.6.26/db/agfl.h   2003-04-29 08:08:41.0 
+0200
+++ ./db/agfl.h 2005-03-30 08:11:34.0 +0200
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  agfl_flds[];
 extern const struct field  agfl_hfld[];
 
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agi.c ./db/agi.c
--- ../tmp-orig/xfsprogs-2.6.26/db/agi.c2003-05-01 08:00:49.0 
+0200
+++ ./db/agi.c  2005-03-30 08:11:35.0 +0200
@@ -31,7 +31,6 @@
  */
 
 #include xfs/libxfs.h
-#include agi.h
 #include command.h
 #include type.h
 #include faddr.h
@@ -41,6 +40,7 @@
 #include bit.h
 #include output.h
 #include init.h
+#include agi.h
 
 static int agi_f(int argc, char **argv);
 static void agi_help(void);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agi.h ./db/agi.h
--- ../tmp-orig/xfsprogs-2.6.26/db/agi.h2003-04-29 08:08:41.0 
+0200
+++ ./db/agi.h  2005-03-30 08:11:34.0 +0200
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  agi_flds[];
 extern const struct field  agi_hfld[];
 
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/bmap.c ./db/bmap.c
--- ../tmp-orig/xfsprogs-2.6.26/db/bmap.c   2003-05-01 08:00:49.0 
+0200
+++ ./db/bmap.c 2005-03-31 09:33:00.113033944 +0200
@@ -33,6 +33,9 @@
 #include xfs/libxfs.h
 #include command.h
 #include type.h
+#include fprint.h
+#include faddr.h
+#include field.h
 #include bmap.h
 #include io.h
 #include inode.h
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/bmapbt.h ./db/bmapbt.h
--- ../tmp-orig/xfsprogs-2.6.26/db/bmapbt.h 2003-04-29 08:08:41.0 
+0200
+++ ./db/bmapbt.h   2005-03-30 08:11:34.0 +0200
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  bmapbta_flds[];
 extern const struct field  bmapbta_hfld[];
 extern const struct field  bmapbta_key_flds[];
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/bmroot.h ./db/bmroot.h
--- ../tmp-orig/xfsprogs-2.6.26/db/bmroot.h 2003-04-29 08:08:42.0 
+0200
+++ ./db/bmroot.h   2005-03-30 08:11:34.0 +0200
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  bmroota_flds[];
 extern const struct field  bmroota_key_flds[];
 extern const struct field  bmrootd_flds[];
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/bnobt.h ./db/bnobt.h
--- ../tmp-orig/xfsprogs-2.6.26/db/bnobt.h  2003-04-29 08:08:42.0 
+0200
+++ ./db/bnobt.h2005-03-30 08:11:34.0 +0200
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  bnobt_flds[];
 extern const struct field  bnobt_hfld[];
 extern const struct field  bnobt_key_flds[];

Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-29 Thread Nathan Scott
Hi Andreas,

On Tue, Mar 29, 2005 at 11:12:51AM +1000, Nathan Scott wrote:
 On Tue, Mar 29, 2005 at 10:17:35AM +1000, Nathan Scott wrote:
  OK, this should fix that (on top of the earlier patch).  Any
  further failures?
 
 From a quick review of the other sources, looks like dquot.c may
 also cause you trouble - if so, let me know - I guess this patch
 will resolve that if it does.

I plan to upload another xfsprogs shortly, could you let me
know how the gcc4 compile went here, and if OK, I'll include
these changes in the new version for you.

thanks!

-- 
Nathan


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-29 Thread Andreas Jochens
On 05-Mar-30 09:58, Nathan Scott wrote:
 Hi Andreas,
 
 On Tue, Mar 29, 2005 at 11:12:51AM +1000, Nathan Scott wrote:
  On Tue, Mar 29, 2005 at 10:17:35AM +1000, Nathan Scott wrote:
   OK, this should fix that (on top of the earlier patch).  Any
   further failures?
  
  From a quick review of the other sources, looks like dquot.c may
  also cause you trouble - if so, let me know - I guess this patch
  will resolve that if it does.
 
 I plan to upload another xfsprogs shortly, could you let me
 know how the gcc4 compile went here, and if OK, I'll include
 these changes in the new version for you.

I still get the attached error message even with all your patches 
applied.

Sorry for my delayed answer and thank you for your help.

Regards
Andreas Jochens

gcc  -O1 -g -DNDEBUG -funsigned-char -fno-strict-aliasing -Wall 
-DVERSION=\2.6.26\ -DLOCALEDIR=\/usr/share/locale\ 
-DPACKAGE=\xfsprogs\ -I../include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64  
-DENABLE_READLINE   -c -o bmap.o bmap.c
In file included from ../include/xfs/linux.h:44,
 from ../include/xfs/platform_defs.h:51,
 from ../include/xfs/libxfs.h:38,
 from bmap.c:33:
../include/xfs/swab.h:112: warning: type qualifiers ignored on function 
return type
../include/xfs/swab.h:125: warning: type qualifiers ignored on function 
return type
../include/xfs/swab.h:138: warning: type qualifiers ignored on function 
return type
In file included from bmap.c:38:
inode.h:33: error: array type has incomplete element type
inode.h:34: error: array type has incomplete element type
inode.h:35: error: array type has incomplete element type
inode.h:36: error: array type has incomplete element type
inode.h:37: error: array type has incomplete element type
inode.h:38: error: array type has incomplete element type
make[2]: *** [bmap.o] Error 1



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-28 Thread Nathan Scott
On Thu, Mar 24, 2005 at 09:41:56AM +0100, Andreas Jochens wrote:
 On 05-Mar-24 12:13, Nathan Scott wrote:
  Could you try a gcc-4 compile with this patch please Andreas?
 
 I applied the patch, but compilation with gcc-4.0 still leads to the
 following error:
 
 In file included from agi.c:34:
 agi.h:33: error: array type has incomplete element type
 agi.h:34: error: array type has incomplete element type
 make[2]: *** [agi.o] Error 1
 make[1]: *** [default] Error 2
 make[1]: Leaving directory `/srv/dbuild/tmp/xfsprogs-2.6.26'
 make: *** [built] Error 2

OK, this should fix that (on top of the earlier patch).  Any
further failures?

thanks.

-- 
Nathan


===
Index: xfsprogs/db/agi.c
===

--- a/xfsprogs/db/agi.c 2005-03-29 08:16:54.0 +1000
+++ b/xfsprogs/db/agi.c 2005-03-29 08:15:16.0 +1000
@@ -31,7 +31,6 @@
  */
 
 #include xfs/libxfs.h
-#include agi.h
 #include command.h
 #include type.h
 #include faddr.h
@@ -41,6 +40,7 @@
 #include bit.h
 #include output.h
 #include init.h
+#include agi.h
 
 static int agi_f(int argc, char **argv);
 static void agi_help(void);


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-28 Thread Nathan Scott
On Tue, Mar 29, 2005 at 10:17:35AM +1000, Nathan Scott wrote:
 OK, this should fix that (on top of the earlier patch).  Any
 further failures?

From a quick review of the other sources, looks like dquot.c may
also cause you trouble - if so, let me know - I guess this patch
will resolve that if it does.

thanks.

-- 
Nathan


===
Index: xfsprogs/db/dquot.c
===

--- a/xfsprogs/db/dquot.c   2005-03-29 10:14:17.0 +1000
+++ b/xfsprogs/db/dquot.c   2005-03-29 10:12:30.0 +1000
@@ -34,7 +34,6 @@
 #include bit.h
 #include bmap.h
 #include command.h
-#include dquot.h
 #include type.h
 #include faddr.h
 #include fprint.h
@@ -43,6 +42,7 @@
 #include io.h
 #include init.h
 #include output.h
+#include dquot.h
 
 static int dquot_f(int argc, char **argv);
 static voiddquot_help(void);



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-24 Thread Andreas Jochens
On 05-Mar-24 12:13, Nathan Scott wrote:
 Could you try a gcc-4 compile with this patch please Andreas?

I applied the patch, but compilation with gcc-4.0 still leads to the
following error:

In file included from agi.c:34:
agi.h:33: error: array type has incomplete element type
agi.h:34: error: array type has incomplete element type
make[2]: *** [agi.o] Error 1
make[1]: *** [default] Error 2
make[1]: Leaving directory `/srv/dbuild/tmp/xfsprogs-2.6.26'
make: *** [built] Error 2

Regards
Andreas Jochens


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-23 Thread Nathan Scott
On Wed, Mar 23, 2005 at 08:25:07AM +0100, Andreas Jochens wrote:
 On 05-Mar-23 15:20, Nathan Scott wrote:
 thank you for your fast reply to my bug report.

No problem.

 This issue has been discussed on the gcc list. The new error message
 'array type has incomplete element type' was introduced intentionally
 to mark invalid C code. The construct 'extern struct s a[];' is 
 not allowed by the C standard if 'struct s' has not been defined, i.e. 
 if the size of 'struct s' is not known in that context.
 
 As far as I understand, there is no intention
 to disable this error message in later versions of gcc-4.0 again.

OK, discussed with some of the other XFS guys, and a fix will
follow shortly (slightly different to yours though).

thanks Andreas.

-- 
Nathan


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-23 Thread Nathan Scott
On Tue, Mar 22, 2005 at 07:50:59PM +0100, Andreas Jochens wrote:
 I attached the wrong patch to my bug report, sorry. 
 
 The correct patch is the following one.
 

Could you try a gcc-4 compile with this patch please Andreas?

thanks.

-- 
Nathan


===
Index: xfsprogs/db/agf.c
===

--- a/xfsprogs/db/agf.c 2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/agf.c 2005-03-24 12:07:12.0 +1100
@@ -31,7 +31,6 @@
  */
 
 #include xfs/libxfs.h
-#include agf.h
 #include command.h
 #include type.h
 #include faddr.h
@@ -41,6 +40,7 @@
 #include bit.h
 #include output.h
 #include init.h
+#include agf.h
 
 static int agf_f(int argc, char **argv);
 static void agf_help(void);

===
Index: xfsprogs/db/agf.h
===

--- a/xfsprogs/db/agf.h 2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/agf.h 2005-03-24 12:05:18.0 +1100
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  agf_flds[];
 extern const struct field  agf_hfld[];
 

===
Index: xfsprogs/db/agfl.c
===

--- a/xfsprogs/db/agfl.c2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/agfl.c2005-03-24 12:12:34.0 +1100
@@ -31,7 +31,6 @@
  */
 
 #include xfs/libxfs.h
-#include agfl.h
 #include command.h
 #include type.h
 #include faddr.h
@@ -41,6 +40,7 @@
 #include bit.h
 #include output.h
 #include init.h
+#include agfl.h
 
 static int agfl_bno_size(void *obj, int startoff);
 static int agfl_f(int argc, char **argv);

===
Index: xfsprogs/db/agfl.h
===

--- a/xfsprogs/db/agfl.h2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/agfl.h2005-03-24 12:10:51.0 +1100
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  agfl_flds[];
 extern const struct field  agfl_hfld[];
 

===
Index: xfsprogs/db/agi.h
===

--- a/xfsprogs/db/agi.h 2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/agi.h 2005-03-24 12:05:27.0 +1100
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  agi_flds[];
 extern const struct field  agi_hfld[];
 

===
Index: xfsprogs/db/bmapbt.h
===

--- a/xfsprogs/db/bmapbt.h  2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/bmapbt.h  2005-03-24 12:10:58.0 +1100
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  bmapbta_flds[];
 extern const struct field  bmapbta_hfld[];
 extern const struct field  bmapbta_key_flds[];

===
Index: xfsprogs/db/bmroot.h
===

--- a/xfsprogs/db/bmroot.h  2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/bmroot.h  2005-03-24 12:11:01.0 +1100
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  bmroota_flds[];
 extern const struct field  bmroota_key_flds[];
 extern const struct field  bmrootd_flds[];

===
Index: xfsprogs/db/bnobt.h
===

--- a/xfsprogs/db/bnobt.h   2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/bnobt.h   2005-03-24 12:11:04.0 +1100
@@ -30,8 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
 extern const struct field  bnobt_flds[];
 extern const struct field  bnobt_hfld[];
 extern const struct field  bnobt_key_flds[];

===
Index: xfsprogs/db/cntbt.h
===

--- a/xfsprogs/db/cntbt.h   2005-03-24 12:16:36.0 +1100
+++ b/xfsprogs/db/cntbt.h   2005-03-24 12:11:07.0 +1100
@@ -30,8 +30,6 @@
  * 

Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-22 Thread Andreas Jochens
I attached the wrong patch to my bug report, sorry. 

The correct patch is the following one.

Regards
Andreas Jochens

diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agf.h ./db/agf.h
--- ../tmp-orig/xfsprogs-2.6.26/db/agf.h2003-04-29 08:08:41.0 
+0200
+++ ./db/agf.h  2005-03-20 14:09:40.0 +0100
@@ -30,10 +30,5 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  agf_flds[];
-extern const struct field  agf_hfld[];
-
 extern voidagf_init(void);
 extern int agf_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agfl.h ./db/agfl.h
--- ../tmp-orig/xfsprogs-2.6.26/db/agfl.h   2003-04-29 08:08:41.0 
+0200
+++ ./db/agfl.h 2005-03-20 14:09:47.0 +0100
@@ -30,10 +30,5 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  agfl_flds[];
-extern const struct field  agfl_hfld[];
-
 extern voidagfl_init(void);
 extern int agfl_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/agi.h ./db/agi.h
--- ../tmp-orig/xfsprogs-2.6.26/db/agi.h2003-04-29 08:08:41.0 
+0200
+++ ./db/agi.h  2005-03-20 14:10:22.0 +0100
@@ -30,10 +30,5 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  agi_flds[];
-extern const struct field  agi_hfld[];
-
 extern voidagi_init(void);
 extern int agi_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/dquot.h ./db/dquot.h
--- ../tmp-orig/xfsprogs-2.6.26/db/dquot.h  2003-04-29 08:08:43.0 
+0200
+++ ./db/dquot.h2005-03-20 14:11:14.0 +0100
@@ -30,10 +30,4 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  disk_dquot_flds[];
-extern const struct field  dqblk_flds[];
-extern const struct field  dqblk_hfld[];
-
 extern voiddquot_init(void);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/field.c ./db/field.c
--- ../tmp-orig/xfsprogs-2.6.26/db/field.c  2003-05-01 08:00:50.0 
+0200
+++ ./db/field.c2005-03-20 14:10:32.0 +0100
@@ -54,6 +54,10 @@
 #include dir2.h
 #include dir2sf.h
 
+extern const struct field agf_flds[], agfl_flds[], agi_flds[], inode_a_flds[],
+ inode_core_flds[], inode_u_flds[], disk_dquot_flds[], dqblk_flds[],
+ inode_flds[], sb_flds[], timestamp_flds[];
+
 const ftattr_t ftattrtab[] = {
{ FLDT_AEXTNUM, aextnum, fp_num, %d, SI(bitsz(xfs_aextnum_t)),
  FTARG_SIGNED, NULL, NULL },
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/inode.h ./db/inode.h
--- ../tmp-orig/xfsprogs-2.6.26/db/inode.h  2003-04-29 08:08:45.0 
+0200
+++ ./db/inode.h2005-03-20 14:10:06.0 +0100
@@ -30,13 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-extern const struct field  inode_a_flds[];
-extern const struct field  inode_core_flds[];
-extern const struct field  inode_flds[];
-extern const struct field  inode_hfld[];
-extern const struct field  inode_u_flds[];
-extern const struct field  timestamp_flds[];
-
 extern int fp_dinode_fmt(void *obj, int bit, int count, char *fmtstr,
  int size, int arg, int base, int array);
 extern int inode_a_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/sb.h ./db/sb.h
--- ../tmp-orig/xfsprogs-2.6.26/db/sb.h 2004-06-18 10:08:40.0 +0200
+++ ./db/sb.h   2005-03-20 14:11:29.0 +0100
@@ -30,11 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  sb_flds[];
-extern const struct field  sb_hfld[];
-
 extern voidsb_init(void);
 extern int sb_logcheck(void);
 extern int sb_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.26/db/type.c ./db/type.c
--- ../tmp-orig/xfsprogs-2.6.26/db/type.c   2003-05-01 08:00:51.0 
+0200
+++ ./db/type.c 2005-03-20 14:10:41.0 +0100
@@ -64,6 +64,9 @@
 static const typ_t *findtyp(char *name);
 static int type_f(int argc, char **argv);
 
+extern const struct field agf_hfld[], agfl_hfld[], agi_hfld[], dqblk_hfld[], 
+ inode_hfld[], sb_hfld[];
+
 const typ_t*cur_typ;
 
 static const cmdinfo_t type_cmd =


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-22 Thread Nathan Scott
On Tue, Mar 22, 2005 at 07:50:59PM +0100, Andreas Jochens wrote:
 I attached the wrong patch to my bug report, sorry. 
 
 The correct patch is the following one.
 ...
 -struct field;
 -
 -extern const struct fieldagf_flds[];
 -extern const struct fieldagf_hfld[];
 ...

Andreas, this really looks like a compiler bug to me; have
you discussed this one with the gcc folks?  Seems certain
that they will suddenly start failing to compile a number
of programs due to this, so I'd be surprised if they don't
fix this behaviour.. so I'm hesitant to change XFS source
for this one, since the code is not wrong AFAICT.

cheers.

-- 
Nathan


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#300544: xfsprogs: FTBFS (amd64/gcc-4.0): array type has incomplete element type

2005-03-20 Thread Andreas Jochens
Package: xfsprogs
Severity: normal
Tags: patch

When building 'xfsprogs' on amd64 with the latest version of gcc-4.0,
I get the following error:

In file included from agf.c:34:
agf.h:35: error: array type has incomplete element type
agf.h:36: error: array type has incomplete element type
make[2]: *** [agf.o] Error 1
make[1]: *** [default] Error 2
make[1]: Leaving directory `/xfsprogs-2.6.20'
make: *** [built] Error 2

With the attached patch 'xfsprogs' can be compiled
on amd64 using the latest version of gcc-4.0.

This patch includes the patch from #297876.

Regards
Andreas Jochens

diff -urN ../tmp-orig/xfsprogs-2.6.20/db/agf.h ./db/agf.h
--- ../tmp-orig/xfsprogs-2.6.20/db/agf.h2003-04-29 08:08:41.0 
+0200
+++ ./db/agf.h  2005-03-20 14:09:40.230846096 +0100
@@ -30,10 +30,5 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  agf_flds[];
-extern const struct field  agf_hfld[];
-
 extern voidagf_init(void);
 extern int agf_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/agfl.h ./db/agfl.h
--- ../tmp-orig/xfsprogs-2.6.20/db/agfl.h   2003-04-29 08:08:41.0 
+0200
+++ ./db/agfl.h 2005-03-20 14:09:47.709409934 +0100
@@ -30,10 +30,5 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  agfl_flds[];
-extern const struct field  agfl_hfld[];
-
 extern voidagfl_init(void);
 extern int agfl_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/agi.h ./db/agi.h
--- ../tmp-orig/xfsprogs-2.6.20/db/agi.h2003-04-29 08:08:41.0 
+0200
+++ ./db/agi.h  2005-03-20 14:10:22.978636714 +0100
@@ -30,10 +30,5 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  agi_flds[];
-extern const struct field  agi_hfld[];
-
 extern voidagi_init(void);
 extern int agi_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/dquot.h ./db/dquot.h
--- ../tmp-orig/xfsprogs-2.6.20/db/dquot.h  2003-04-29 08:08:43.0 
+0200
+++ ./db/dquot.h2005-03-20 14:11:14.590724306 +0100
@@ -30,10 +30,4 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  disk_dquot_flds[];
-extern const struct field  dqblk_flds[];
-extern const struct field  dqblk_hfld[];
-
 extern voiddquot_init(void);
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/field.c ./db/field.c
--- ../tmp-orig/xfsprogs-2.6.20/db/field.c  2003-05-01 08:00:50.0 
+0200
+++ ./db/field.c2005-03-20 14:10:32.658777643 +0100
@@ -54,6 +54,10 @@
 #include dir2.h
 #include dir2sf.h
 
+extern const struct field agf_flds[], agfl_flds[], agi_flds[], inode_a_flds[],
+ inode_core_flds[], inode_u_flds[], disk_dquot_flds[], dqblk_flds[],
+ inode_flds[], sb_flds[], timestamp_flds[];
+
 const ftattr_t ftattrtab[] = {
{ FLDT_AEXTNUM, aextnum, fp_num, %d, SI(bitsz(xfs_aextnum_t)),
  FTARG_SIGNED, NULL, NULL },
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/inode.h ./db/inode.h
--- ../tmp-orig/xfsprogs-2.6.20/db/inode.h  2003-04-29 08:08:45.0 
+0200
+++ ./db/inode.h2005-03-20 14:10:06.364827331 +0100
@@ -30,13 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-extern const struct field  inode_a_flds[];
-extern const struct field  inode_core_flds[];
-extern const struct field  inode_flds[];
-extern const struct field  inode_hfld[];
-extern const struct field  inode_u_flds[];
-extern const struct field  timestamp_flds[];
-
 extern int fp_dinode_fmt(void *obj, int bit, int count, char *fmtstr,
  int size, int arg, int base, int array);
 extern int inode_a_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/sb.h ./db/sb.h
--- ../tmp-orig/xfsprogs-2.6.20/db/sb.h 2004-06-18 10:08:40.0 +0200
+++ ./db/sb.h   2005-03-20 14:11:29.300898990 +0100
@@ -30,11 +30,6 @@
  * http://oss.sgi.com/projects/GenInfo/SGIGPLNoticeExplan/
  */
 
-struct field;
-
-extern const struct field  sb_flds[];
-extern const struct field  sb_hfld[];
-
 extern voidsb_init(void);
 extern int sb_logcheck(void);
 extern int sb_size(void *obj, int startoff, int idx);
diff -urN ../tmp-orig/xfsprogs-2.6.20/db/type.c ./db/type.c
--- ../tmp-orig/xfsprogs-2.6.20/db/type.c   2003-05-01 08:00:51.0 
+0200
+++ ./db/type.c 2005-03-20 14:10:41.960991127 +0100
@@ -64,6 +64,9 @@
 static const typ_t *findtyp(char *name);
 static int type_f(int argc, char **argv);
 
+extern const struct field agf_hfld[], agfl_hfld[], agi_hfld[], dqblk_hfld[], 
+ inode_hfld[], sb_hfld[];
+
 const typ_t*cur_typ;
 
 static const cmdinfo_t type_cmd =
diff -urN ../tmp-orig/xfsprogs-2.6.20/debian/control ./debian/control
---