Bug#306179: erc: fails to load when using erc-autoaway [PATCH]

[Daniel Brockman]

Michael Olson [EMAIL PROTECTED] writes:

 Thanks for the patch!  I've included these changes in CVS, and the
 next (5.0.3) release will have it.

Thanks!

 I'll close the bug when I release next, since that's the bug-closing
 method that I am the most familiar with :^) .

I think that's also the best bug-closing method. :-)

-- 
Daniel Brockman [EMAIL PROTECTED]


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#306179: erc: fails to load when using erc-autoaway [PATCH]

[Michael Olson]

Daniel Brockman [EMAIL PROTECTED] writes:

 Steps to reproduce:

   1.  emacs21 -q

   2.  (custom-set-variables '(erc-autoaway-mode t nil (erc-autoaway))
 '(erc-autoaway-use-emacs-idle t))

   3.  C-x C-e

 This patch fixes the problem:

Thanks for the patch!  I've included these changes in CVS, and the
next (5.0.3) release will have it.  I'll close the bug when I release
next, since that's the bug-closing method that I am the most familiar
with :^) .

 By the way, Bug #301952 (erc 5.0 is out) can probably be considered
 fixed.

Yeah, it was filed just after I put together the package.  I'll close
it.

-- 
Michael Olson -- FSF Associate Member #652 -- http://www.mwolson.org/
Jabber: mwolson_at_hcoop.net -- IRC: mwolson on freenode.net: #muse, #pulug
  /` |\ | | |
 |_] | \| |_|   Interests: anime, Debian GNU/Linux, XHTML, wiki, Emacs Lisp


pgpLGxdpH4dw3.pgp
Description: PGP signature

Bug#306179: erc: fails to load when using erc-autoaway [PATCH]

[Daniel Brockman]

Package: erc
Version: 5.0.2-1
Severity: normal

Steps to reproduce:

  1.  emacs21 -q

  2.  (custom-set-variables '(erc-autoaway-mode t nil (erc-autoaway))
'(erc-autoaway-use-emacs-idle t))

  3.  C-x C-e

This patch fixes the problem:

--- erc-5.0.2.orig/erc-autoaway.el
+++ erc-5.0.2/erc-autoaway.el
@@ -117,6 +117,19 @@
   :group 'erc-autoaway
   :type 'regexp)
 
+(defun erc-autoaway-reestablish-idletimer ()
+  Reestablish the emacs idletimer.
+You have to call this function each time you change
+`erc-autoaway-idle-seconds', if `erc-autoaway-use-emacs-idle' is set.
+  (interactive)
+  (when erc-autoaway-idletimer
+(cancel-timer erc-autoaway-idletimer))
+  (setq erc-autoaway-idletimer
+   (run-with-idle-timer erc-autoaway-idle-seconds
+t
+'erc-autoaway-set-away
+erc-autoaway-idle-seconds)))
+
 (defcustom erc-autoaway-idle-seconds 1800
   *Number of seconds after which ERC will set you automatically away.
 If you are changing this variable using lisp instead of customizing it,
@@ -148,19 +161,6 @@
 (erc-autoaway-set-back line))
   (setq erc-autoaway-last-sent-time (erc-current-time)))
 
-(defun erc-autoaway-reestablish-idletimer ()
-  Reestablish the emacs idletimer.
-You have to call this function each time you change
-`erc-autoaway-idle-seconds', if `erc-autoaway-use-emacs-idle' is set.
-  (interactive)
-  (when erc-autoaway-idletimer
-(cancel-timer erc-autoaway-idletimer))
-  (setq erc-autoaway-idletimer
-   (run-with-idle-timer erc-autoaway-idle-seconds
-t
-'erc-autoaway-set-away
-erc-autoaway-idle-seconds)))
-
 (defun erc-autoaway-set-back (line)
   Discard the away state globally.
   (when (erc-away-p)


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7-drlion-8
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages erc depends on:
ii  emacs21   21.4a-1The GNU Emacs editor
ii  make  3.80-9 The GNU version of the make util

-- no debconf information

By the way, Bug #301952 (erc 5.0 is out) can probably be considered fixed.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]