Bug#310842: cacti: Fix for poller silently failing

2005-06-14 Thread sean finney
tags 310842 = confirmed sarge fixed patch
thanks

hey mark,

On Tue, Jun 14, 2005 at 12:00:15PM +0100, Mark Sheppard wrote:
> Package: cacti
> Version: 0.8.6d-1
> Tags: patch
> Followup-For: Bug #310842
> 
> I've finally got round to looking at this properly.  Turns out that

awesome!  thanks for figuring this out, i was really lost on this one.
i will include this patch in the next upload, though i will leave this
bug open and appropriately tagged for anyone who's using sarge and runs
across this.



sean

-- 


signature.asc
Description: Digital signature


Bug#310842: cacti: Fix for poller silently failing

2005-06-14 Thread Mark Sheppard
Package: cacti
Version: 0.8.6d-1
Tags: patch
Followup-For: Bug #310842

I've finally got round to looking at this properly.  Turns out that
the problem is that there's a few rows in my poller_item table that
contain bad information.  They have the following fields which are
wrong:

  host_id   0
  hostname  "None"
  snmp_community""
  snmp_version  0
  snmp_timeout  0

Procssing one of these causes cmd.php to hang, so script_server.php
never receives any input.  The attached patch causes cmd.cgi to skip
items with a host_id of 0 which fixes the problem.  It also logs a
warning message mentioning that.  (The patch also includes a couple of
minor corrections to some messages and comments).

Cheers,
Mark.


-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.4.26-1-686-smp
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)

Versions of packages cacti depends on:
ii  apache   1.3.33-6versatile, high-performance HTTP s
ii  debconf  1.4.30.13   Debian configuration management sy
ii  libphp-adodb 4.52-1  The 'adodb' database abstraction l
ii  logrotate3.7-5   Log rotation utility
ii  mysql-client 4.0.24-10   mysql database client binaries
ii  php4 4:4.3.10-15 server-side, HTML-embedded scripti
ii  php4-cli 4:4.3.10-15 command-line interpreter for the p
ii  php4-mysql   4:4.3.10-15 MySQL module for php4
ii  php4-snmp4:4.3.10-15 SNMP module for php4
ii  rrdtool  1.0.49-1Time-series data storage and displ
ii  snmp 5.1.2-6.1   NET SNMP (Simple Network Managemen
ii  ucf  1.17Update Configuration File: preserv

-- debconf information excluded


cacti.patch
Description: Binary data