Bug#312346: visitors: Visitors has out of date list of User Agent strings

2005-06-07 Thread Simon Waters
Package: visitors
Version: 0.4a-1
Severity: wishlist


visitors doesn't know about new web browsers like Firefox.

Attached patch to add some extra User Agents - not this patch will
not fully work without additional changes to the parser. However it
shouldn't break anything, just introduce unusuable categories.

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.27-2-686-smp
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)

Versions of packages visitors depends on:
ii  libc6   2.3.2.ds1-22 GNU C Library: Shared libraries an

-- no debconf information
@@ -1040,13 +1030,23 @@
 	/* Note that the order matters. For example Safari
 	 * send an user agent where there is the string Gecko
 	 * so it must be before Gecko. */
+
+	/* Note that the parser looks for first ( so we can't easily count
+	 * Useragents that report without brackets like;
+	 *  asteria,
+	 *  contype,
+	 *  Windows-MP,
+	 *  Gigabot,
+	 *  etc - we should modify to find fifth '' perhaps? */
+ 
 	char *browserslist[] = {
 		Opera, NULL,
 		MSIE, Explorer,
 		Safari, NULL,
 		Konqueror, NULL,
 		Galeon, NULL,
-		Gecko, Netscape/Mozilla,
+		Firefox, NULL,
+		Gecko, Other Gecko,
 		Wget, NULL,
 		Lynx, NULL,
 		Links , Links,
@@ -1056,6 +1056,15 @@
 		NATSU-MICAN, NULL,
 		www.googlebot.com, GoogleBot,
 		www.google.com/bot, GoogleBot,
+		msnbot, MSNbot,
+		Slurp, Yahoo Slurp,
+		Jeeves, Ask Jeeves,
+		ZyBorg, NULL,
+		asteria, NULL,
+		contype, Explorer,
+		Gigabot, NULL,
+		Windows-Media-Player, Windows-MP,
+		NSPlayer, NULL,
 		, Unknown,
 		NULL, NULL,
 	};


Bug#312346: visitors: Visitors has out of date list of User Agent strings

2005-06-07 Thread Romain Francoise
Simon Waters [EMAIL PROTECTED] writes:

 visitors doesn't know about new web browsers like Firefox.

It does -- it just puts Firefox in the Netscape/Mozilla category.

 Attached patch to add some extra User Agents - not this patch will
 not fully work without additional changes to the parser. However it
 shouldn't break anything, just introduce unusuable categories.

Thanks, I'll forward this to the upstream author.

-- 
  ,''`.
 : :' :Romain Francoise [EMAIL PROTECTED]
 `. `' http://people.debian.org/~rfrancoise/
   `-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]