Bug#316219: [Pkg-shadow-devel] Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-07-01 Thread Martin Quinson
On Thu, Jun 30, 2005 at 02:19:24PM +0200, Christian Perrier wrote:
 Quoting Bastian Blank ([EMAIL PROTECTED]):
  On Thu, Jun 30, 2005 at 12:14:25PM +0200, Christian Perrier wrote:
  
   We can obviously do this,
   however, I think that we should move the conditional config based on
   the debconf question to the top of the config script.
  
  You have to ask it if not flagged as seen in this case. Also this
  violates debconf is no registry.
 
 
 Well, I'm not sure that the debconf is not a registry karma actually
 really means something. I have to think about this. Anyway, we will
 fix this after the 4.0.3-36 release.

The same way we removed the enable md5 question a while ago (actually,
Karl did it before we arrived), shouldn't we remove this question as well?

Is there any situation where shadow is a bad thing? I mean, does someone
somewhere on the earth really need this feature?

Bye, Mt.


signature.asc
Description: Digital signature


Bug#316219: [Pkg-shadow-devel] Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-07-01 Thread Christian Perrier
 The same way we removed the enable md5 question a while ago (actually,
 Karl did it before we arrived), shouldn't we remove this question as well?
 
 Is there any situation where shadow is a bad thing? I mean, does someone
 somewhere on the earth really need this feature?


The template mentions that shadow passwords can be nasty in NIS
environments.




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-06-30 Thread Bastian Blank
tags 316219 patch
thanks

I attached a patch to do that.

Bastian

-- 
You can't evaluate a man by logic alone.
-- McCoy, I, Mudd, stardate 4513.3
diff -ur shadow-4.0.3.orig/config.h.in shadow-4.0.3/config.h.in
diff -ur shadow-4.0.3.orig/debian/changelog shadow-4.0.3/debian/changelog
--- shadow-4.0.3.orig/debian/changelog  2005-06-30 09:46:29.897999185 +0200
+++ shadow-4.0.3/debian/changelog   2005-06-30 09:29:46.603806355 +0200
@@ -1,3 +1,9 @@
+shadow (1:4.0.3-35.0.0waldi.1) UNRELEASED; urgency=low
+
+  * Enable shadow on firsttime installation.
+
+ -- Bastian Blank [EMAIL PROTECTED]  Thu, 30 Jun 2005 09:29:33 +0200
+
 shadow (1:4.0.3-35) unstable; urgency=low
 
   * Re-apply the debian/patches/036_CAN-2004-1001_passwd_check patch
diff -ur shadow-4.0.3.orig/debian/passwd.preinst 
shadow-4.0.3/debian/passwd.preinst
--- shadow-4.0.3.orig/debian/passwd.preinst 2005-06-30 09:46:29.881001537 
+0200
+++ shadow-4.0.3/debian/passwd.preinst  2005-06-30 09:29:17.920774693 +0200
@@ -29,7 +30,9 @@
if dpkg --compare-versions $2 lt 1:4.0.3 ; then
remove_md5 /etc/pam.d/passwd 23a5d1465bbc1e39ca6e0c32f22a75c9
fi
-   fi
+   else
+   shadowconfig on
+   fi

 ;;
 
diff -ur shadow-4.0.3.orig/debian/rules shadow-4.0.3/debian/rules
--- shadow-4.0.3.orig/debian/rules  2005-06-30 09:46:29.883001260 +0200
+++ shadow-4.0.3/debian/rules   2005-06-30 09:36:34.132424195 +0200
@@ -2,7 +2,7 @@
 
 config_options := --disable-shared --without-libcrack --mandir=/usr/share/man 
--with-libpam
 
-DEB_HOST_GNU_SYSTEM := $(shell dpkg-architecture -qDEB_HOST_GNU_SYSTEM)
+DEB_HOST_ARCH_OS := $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
 DEB_BUILD_GNU_TYPE = $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 DEB_HOST_GNU_TYPE = $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 ifneq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE))
@@ -104,7 +104,7 @@
install -c -m 444 debian/pam.d/chsh debian/passwd/etc/pam.d/chsh
install -c -m 444 debian/pam.d/passwd debian/passwd/etc/pam.d/passwd
install -c -m 444 debian/login.defs debian/login/etc/login.defs
-   install -c -m 444 debian/securetty.$(DEB_HOST_GNU_SYSTEM) 
debian/login/etc/securetty
+   install -c -m 444 debian/securetty.$(DEB_HOST_ARCH_OS) 
debian/login/etc/securetty
install -d debian/passwd/usr/share/passwd
install -c -m 444 debian/shells debian/passwd/usr/share/passwd/shells
install -d debian/passwd/sbin


signature.asc
Description: Digital signature


Bug#316219: [Pkg-shadow-devel] Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-06-30 Thread Christian Perrier

 diff -ur shadow-4.0.3.orig/debian/passwd.preinst 
 shadow-4.0.3/debian/passwd.preinst
 --- shadow-4.0.3.orig/debian/passwd.preinst   2005-06-30 09:46:29.881001537 
 +0200
 +++ shadow-4.0.3/debian/passwd.preinst2005-06-30 09:29:17.920774693 
 +0200
 @@ -29,7 +30,9 @@
   if dpkg --compare-versions $2 lt 1:4.0.3 ; then
   remove_md5 /etc/pam.d/passwd 23a5d1465bbc1e39ca6e0c32f22a75c9
   fi
 - fi
 + else
 + shadowconfig on
 + fi


Means that we enforce shadow passwords. We can obviously do this,
however, I think that we should move the conditional config based on
the debconf question to the top of the config script.

That way, we will have a behaviour which remains consistent with what
the user may be prompted for by debconf.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#316219: [Pkg-shadow-devel] Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-06-30 Thread Bastian Blank
On Thu, Jun 30, 2005 at 12:14:25PM +0200, Christian Perrier wrote:
 Means that we enforce shadow passwords.

Nope, it only enforce shadow if $2 is empty which only happens on
firsttime installation or after someone purged the package.

 We can obviously do this,
 however, I think that we should move the conditional config based on
 the debconf question to the top of the config script.

You have to ask it if not flagged as seen in this case. Also this
violates debconf is no registry.

Bastian

-- 
Killing is wrong.
-- Losira, That Which Survives, stardate unknown


signature.asc
Description: Digital signature


Bug#316219: [Pkg-shadow-devel] Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-06-30 Thread Christian Perrier
Quoting Bastian Blank ([EMAIL PROTECTED]):
 On Thu, Jun 30, 2005 at 12:14:25PM +0200, Christian Perrier wrote:
  Means that we enforce shadow passwords.
 
 Nope, it only enforce shadow if $2 is empty which only happens on
 firsttime installation or after someone purged the package.

Right, I missed the context.

 
  We can obviously do this,
  however, I think that we should move the conditional config based on
  the debconf question to the top of the config script.
 
 You have to ask it if not flagged as seen in this case. Also this
 violates debconf is no registry.


Well, I'm not sure that the debconf is not a registry karma actually
really means something. I have to think about this. Anyway, we will
fix this after the 4.0.3-36 release.




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-06-29 Thread Bastian Blank
Package: passwd
Version: 1:4.0.3-35
Severity: wishlist

Please enable shadow by default on firsttime installation.

Currently shadow is enabled by base-config, which leads to disabled
shadow on automatic bootstrapping as base-config is not needed for
anything else and therefor not installed.

Bastian

-- 
The sooner our happiness together begins, the longer it will last.
-- Miramanee, The Paradise Syndrome, stardate 4842.6


signature.asc
Description: Digital signature


Bug#316219: [Pkg-shadow-devel] Bug#316219: passwd - please enable shadow by default on firsttime installation

2005-06-29 Thread Martin Quinson
tag 316219 confirmed
thanks

I just created chroot (using pbuilder), and indeed, shadow is not enabled in
there.

Bye, Mt.

On Wed, Jun 29, 2005 at 01:35:17PM +0200, Bastian Blank wrote:
 Package: passwd
 Version: 1:4.0.3-35
 Severity: wishlist
 
 Please enable shadow by default on firsttime installation.
 
 Currently shadow is enabled by base-config, which leads to disabled
 shadow on automatic bootstrapping as base-config is not needed for
 anything else and therefor not installed.
 
 Bastian
 
 -- 
 The sooner our happiness together begins, the longer it will last.
   -- Miramanee, The Paradise Syndrome, stardate 4842.6




signature.asc
Description: Digital signature