Bug#317246: Patch: Handle another case for package name/version
Troy Davis wrote: > Greetings, > > Since I originally submitted my short patch for dh-make-perl, I explained > the situation to the author of WWW::Search::Ebay, and as a result he started > including a standard META.yml with his modules. That solved all > problems--the last time I used dh-make-perl to make WWW::Search::Ebay, it > went fine from start to finish. > > close 317246 thanks Thanks Troy. I had passed this upstream to the author of Module::Depends informally (ie, not CC'ed to this bug), but had no response. I will close this bug now if WWW::Search::Ebay is now fixed. Thanks for the report. James begin:vcard fn:James Bromberger n:Bromberger;James adr:;;;London;Greater London;;United Kingdom email;internet:[EMAIL PROTECTED] tel;cell:+447952042920 note:GPG: 3F2C F8FD B2D5 AA35 C81A F914 A5F2 7028 0917 A9E4 x-mozilla-html:FALSE url:http://www.james.rcpt.to version:2.1 end:vcard
Bug#317246: Patch: Handle another case for package name/version
Greetings, Since I originally submitted my short patch for dh-make-perl, I explained the situation to the author of WWW::Search::Ebay, and as a result he started including a standard META.yml with his modules. That solved all problems--the last time I used dh-make-perl to make WWW::Search::Ebay, it went fine from start to finish. -- Troy -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#317246: Patch: Handle another case for package name/version
reassign 317246 libmodule-depends-perl tags 317246 - patch retitle 317246 thanks Hi, I am also reassigning this bug report to libmodule-depends-perl - WWW::Search::Ebay has a quite nonstandard Makefile.PL, so getting the right information out of it is not simple. I just patched dh-make-perl with the patch provided by Troy Davis, this bug's submitter, but now the build process dies when trying to get the Depends: information from libmodule-depends-perl: Found: WWW-Search-Ebay 2.215 (libwww-search-ebay-perl arch=all) Error: Can't call method "write" without a package or object reference at /tmp/WWW-Search-Ebay-2.215/Makefile.PL line 29. Compilation failed in require at /usr/share/perl5/Module/Depends/Intrusive.pm line 76. Now, this module is using Module::Install, but calling it straight from its own tree - This means, it's using its own version. Anyway, Module::Install provides a simple to parse structure, and they seem to stick with the "real" one. Greetings, -- Gunnar Wolf - [EMAIL PROTECTED] - (+52-55)1451-2244 / 5623-0154 PGP key 1024D/8BB527AF 2001-10-23 Fingerprint: 0C79 D2D1 2C4E 9CE4 5973 F800 D80E F35A 8BB5 27AF -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#317246: Patch: Handle another case for package name/version
Word-wrapping broke the long lines in the patch. The patch is attached proper to this message. -- Troy patch Description: Binary data
Bug#317246: Patch: Handle another case for package name/version
Package: dh-make-perl
Version: 0.17
Tags: patch
I install and update the perl module WWW::Search::Ebay with dh-make-perl.
dh-make-perl has never been able to automatically figure out the package's
name and version (always producing a .deb named "lib-perl_0-1_all.deb"), so
I'm submitting my two-line change that aids this.
WWW::Search::Ebay defines its name and version in Makefile.PL in this way:
---snip---
# $rcs = ' $Id: Makefile.PL,v 1.25 2005/05/19 03:05:51 Daddy Exp $ ';
use inc::Module::Install;
name('WWW-Search-Ebay');
author('Martin Thurn <[EMAIL_ADDRESS_OBSCURED]>');
license('perl');
version(2.207);
---snip---
Here is my two-line addition to deal with this. I hope this is useful
for others.
--- /old/dh-make-perl 2005-05-18 09:45:27.0 -0500
+++ /new/dh-make-perl 2005-07-06 20:31:04.0 -0500
@@ -375,7 +375,9 @@
close(MF);
$name = $4 if $file =~ /(['"]?)DISTNAME\1\s*(=>|,)\s*(['"]?)(\S+)\3/s;
$name = $4 if ! $name && $file =~
/(['"]?)NAME\1\s*(=>|,)\s*(['"]?)(\S+)\3/s;
+$name = $2 if ! $name && $file =~ /name\((['"]?)(\S+)\1\);/s;
$ver = $4 if $file =~ /(['"]?)VERSION\1\s*(=>|,)\s*(['"]?)(\S+)\3/s;
+$ver = $1 if ! $ver && $file =~ /version\((\S+)\)/s;
$vfrom = $4 if $file =~
/(['"]?)VERSION_FROM\1\s*(=>|,)\s*(['"]?)(\S+)\3/s;
$dir = dirname($makefile) || './';
$name =~ s/,.*$//;
--
Troy
