Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-20 Thread Vincent Lefevre
On 2005-07-19 23:41:05 -0400, Eric Dorland wrote:
 * Vincent Lefevre ([EMAIL PROTECTED]) wrote:
  I can see nothing there that this can break extensions.
 
 Firefox is not a shared library. I don't remember any guarantee
 things wouldn't break between releases. 

AFAIK, there is an API, and extensions provide compatibility
information, so that possible breakage can be detected. Otherwise
things are not supposed to break (except minor ones or for security
reasons). Here I was not sure of the source of the problem.

 Anyway, this whole thing is moot, the breakage was not known until
 after the release. 1.0.6 has just been released to fix the API.

That's why I reported the bug. I didn't think at that time it
wasn't intentional.

 Firefox is not a library, new versions can and will break things.
 You can bet your ass Firefox 1.1 will break things.

But for the extensions provided by Debian packages, this should be
tested and tracked with dependencies, IMHO. Or at least in the
ChangeLog of the Firefox package. The goal is that the user can
be warned *before* upgrading his system.

  The user needs to know if an upgrade will break packages.
 
 This is unstable, things break. If you can't handle it, don't use
 unstable. 

Things break, but they are not supposed to break, even in unstable.

-- 
Vincent Lefèvre [EMAIL PROTECTED] - Web: http://www.vinc17.org/
100% accessible validated (X)HTML - Blog: http://www.vinc17.org/blog/
Work: CR INRIA - computer arithmetic / SPACES project at LORIA


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-19 Thread Eric Dorland
* Vincent Lefevre ([EMAIL PROTECTED]) wrote:
 On 2005-07-17 12:09:46 +0200, Mike Hommey wrote:
  If i got it correctly, this bug got introduced because of the changes to
  the security model for XUL applications... so, for once, we can't really
  blame the it should have been a bug-fix release only, since it is what
  it was, except that security fixes has side effects.
 
 The Debian changelog just says:
 
   * New upstream release, fixes security issues. (Closes: #318061)
   * debian/rules: Disable freetype in the build for the time being. This
 *might* break printing in some cases.
   * gfx/idl/nsIFreeType2.idl, gfx/src/freetype/nsFreeType.cpp,
 gfx/src/freetype/nsFreeType.h, gfx/src/ps/nsFontMetricsPS.cpp,
 gfx/src/ps/nsFontMetricsPS.h, gfx/src/x11shared/nsFontFreeType.cpp,
 gfx/src/x11shared/nsFontFreeType.h,
 layout/svg/renderer/src/libart/nsSVGLibartGlyphMetricsFT.cpp: Patch
 from bz#234035 to try to get building with the new freetype. (Closes:
 #314243)
 
 I can see nothing there that this can break extensions.

Firefox is not a shared library. I don't remember any guarantee
things wouldn't break between releases. 

 And if due to the change of the security model for XUL applications,
 it is known to break some extensions, I really think that the conflict
 should be marked in the packages (in mozilla-firefox, since this is
 where the change happens). Hence the bug.

Umm, that makes no sense. I'm not going to track all the extensions
every release to see if they break, that's their maintainers job.

Anyway, this whole thing is moot, the breakage was not known until
after the release. 1.0.6 has just been released to fix the API.

 In a similar way, if a library changes its ABI, one doesn't expect the
 packages that use it to silently break just because of the upgrade.

Firefox is not a library, new versions can and will break things. You
can bet your ass Firefox 1.1 will break things.

 The user needs to know if an upgrade will break packages.

This is unstable, things break. If you can't handle it, don't use
unstable. 

-- 
Eric Dorland [EMAIL PROTECTED]
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6

-BEGIN GEEK CODE BLOCK-
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
--END GEEK CODE BLOCK--


signature.asc
Description: Digital signature


Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-17 Thread Vincent Lefevre
On 2005-07-17 12:09:46 +0200, Mike Hommey wrote:
 If i got it correctly, this bug got introduced because of the changes to
 the security model for XUL applications... so, for once, we can't really
 blame the it should have been a bug-fix release only, since it is what
 it was, except that security fixes has side effects.

The Debian changelog just says:

  * New upstream release, fixes security issues. (Closes: #318061)
  * debian/rules: Disable freetype in the build for the time being. This
*might* break printing in some cases.
  * gfx/idl/nsIFreeType2.idl, gfx/src/freetype/nsFreeType.cpp,
gfx/src/freetype/nsFreeType.h, gfx/src/ps/nsFontMetricsPS.cpp,
gfx/src/ps/nsFontMetricsPS.h, gfx/src/x11shared/nsFontFreeType.cpp,
gfx/src/x11shared/nsFontFreeType.h,
layout/svg/renderer/src/libart/nsSVGLibartGlyphMetricsFT.cpp: Patch
from bz#234035 to try to get building with the new freetype. (Closes:
#314243)

I can see nothing there that this can break extensions.

And if due to the change of the security model for XUL applications,
it is known to break some extensions, I really think that the conflict
should be marked in the packages (in mozilla-firefox, since this is
where the change happens). Hence the bug.

In a similar way, if a library changes its ABI, one doesn't expect the
packages that use it to silently break just because of the upgrade.

The user needs to know if an upgrade will break packages.

-- 
Vincent Lefèvre [EMAIL PROTECTED] - Web: http://www.vinc17.org/
100% accessible validated (X)HTML - Blog: http://www.vinc17.org/blog/
Work: CR INRIA - computer arithmetic / SPACES project at LORIA


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-17 Thread Mike Hommey
On Sun, Jul 17, 2005 at 02:12:26PM +0200, Vincent Lefevre [EMAIL PROTECTED] 
wrote:
 On 2005-07-17 12:09:46 +0200, Mike Hommey wrote:
  If i got it correctly, this bug got introduced because of the changes to
  the security model for XUL applications... so, for once, we can't really
  blame the it should have been a bug-fix release only, since it is what
  it was, except that security fixes has side effects.
 
 The Debian changelog just says:
 
   * New upstream release, fixes security issues. (Closes: #318061)
   * debian/rules: Disable freetype in the build for the time being. This
 *might* break printing in some cases.
   * gfx/idl/nsIFreeType2.idl, gfx/src/freetype/nsFreeType.cpp,
 gfx/src/freetype/nsFreeType.h, gfx/src/ps/nsFontMetricsPS.cpp,
 gfx/src/ps/nsFontMetricsPS.h, gfx/src/x11shared/nsFontFreeType.cpp,
 gfx/src/x11shared/nsFontFreeType.h,
 layout/svg/renderer/src/libart/nsSVGLibartGlyphMetricsFT.cpp: Patch
 from bz#234035 to try to get building with the new freetype. (Closes:
 #314243)
 
 I can see nothing there that this can break extensions.
 
 And if due to the change of the security model for XUL applications,
 it is known to break some extensions, I really think that the conflict
 should be marked in the packages (in mozilla-firefox, since this is
 where the change happens). Hence the bug.
 
 In a similar way, if a library changes its ABI, one doesn't expect the
 packages that use it to silently break just because of the upgrade.

You don't expect the package to have conflicts with all current packages
depending on it either. And it doesn't affect all extensions.

Mike


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-17 Thread Eric Dorland
* Vincent Lefevre ([EMAIL PROTECTED]) wrote:
 Package: mozilla-firefox
 Version: 1.0.5-1
 Severity: serious
 Justification: Policy 7.3
 
 There seem to be very important incompatibilities between
 mozilla-firefox 1.0.5-1 (to which I've just upgraded) and
 mozilla-tabextensions 1.14.2005051901-1.
 
 I've done some tests with a new profile, trying it with and without
 the tabextensions. The two bugs I've just reported are due to this
 extension. I recall them here:
 
 1) Bookmarks not visible until I click on Manage Bookmarks.
 
 Just after Firefox starts up, the Bookmark menu contains only the
 following items:
   * Bookmark This Page...
   * Manage Bookmarks...
 
 I need to click on Manage Bookmarks... and close the window to
 make the bookmarks appear in the Bookmarks menu.
 
 2) Since the upgrade to 1.0.5-1, URLs can no longer be opened in new
 tabs from a page, i.e. when I click on a link with the middle button
 or when I click on Open Link in New Tab from the contextual menu.
 
 But if I click with the middle button on a bookmark, the corresponding
 URL is opened in a new tab as expected.
 
 
 I don't know if these bugs need to be closed or reassigned to
 mozilla-tabextensions.
 
 The Find As You Type feature doesn't work either (no problems with
 no extensions). I suspect that the whole interface gets seriously
 broken due to this extension. So, this package should conflict with
 mozilla-tabextensions (= 1.14.2005051901-1).

It's not entirely clear, are you saying that you only have these
problems with mozilla-tabextensions? If that's the case then this bug
report should be with mozilla-tabextensions. Putting a conflict on it
is just silly. The API provided to extension writers is not very
stable, so it tends to break on new version. Extension packages should
probably have pretty tight dependencies to avoid these sorts of
problems. 

-- 
Eric Dorland [EMAIL PROTECTED]
ICQ: #61138586, Jabber: [EMAIL PROTECTED]
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6

-BEGIN GEEK CODE BLOCK-
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
--END GEEK CODE BLOCK--


signature.asc
Description: Digital signature


Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-17 Thread Andreas Metzler
On 2005-07-17 Eric Dorland [EMAIL PROTECTED] wrote:
 * Vincent Lefevre ([EMAIL PROTECTED]) wrote:
  Package: mozilla-firefox
  Version: 1.0.5-1
[...] 
  There seem to be very important incompatibilities between
  mozilla-firefox 1.0.5-1 (to which I've just upgraded) and
  mozilla-tabextensions 1.14.2005051901-1.
[...] 
 It's not entirely clear, are you saying that you only have these
 problems with mozilla-tabextensions? If that's the case then this bug
 report should be with mozilla-tabextensions. Putting a conflict on it
 is just silly. The API provided to extension writers is not very
 stable, so it tends to break on new version. Extension packages should
 probably have pretty tight dependencies to avoid these sorts of
 problems. 

Afaiui firefox unintentionally changed its ABI.

http://www.mozillazine.org/talkback.html?article=6950

| Just days after the releases of Mozilla Firefox 1.0.5 and Mozilla
| Thunderbird 1.0.5, it appears likely that 1.0.6 versions of the two
| applications could be coming as early as next week. It is understood
| that API changes in 1.0.5 unintentionally broke some extensions.
| 
| In comment 45 of bug 300028, Rafael Ebron said yesterday, We received
| feedback on 1.0.5 from distributors and extension developers on API
| changes that affected them (not a security issue), so we're looking at a
| 1.0.6 to fix it. It is known that the Enigmail PGP extension for
| Thunderbird does not work in version 1.0.5.
cu andreas


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-17 Thread Vincent Lefevre
On 2005-07-17 11:10:40 +0300, Andreas Metzler wrote:
 On 2005-07-17 Eric Dorland [EMAIL PROTECTED] wrote:
  It's not entirely clear, are you saying that you only have these
  problems with mozilla-tabextensions?

On my side, I've noticed problems with mozilla-tabextensions only.
I don't know if the other extensions still work, but at least, they
don't seem to make problems with the standard use of Firefox. But...

 | Just days after the releases of Mozilla Firefox 1.0.5 and Mozilla
 | Thunderbird 1.0.5, it appears likely that 1.0.6 versions of the two
 | applications could be coming as early as next week. It is understood
 | that API changes in 1.0.5 unintentionally broke some extensions.

I've just read that in a French newsgroup. So, this is really a bug
in Firefox (as it should have been a bug-fix release only).

-- 
Vincent Lefèvre [EMAIL PROTECTED] - Web: http://www.vinc17.org/
100% accessible validated (X)HTML - Blog: http://www.vinc17.org/blog/
Work: CR INRIA - computer arithmetic / SPACES project at LORIA


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-17 Thread Mike Hommey
On Sun, Jul 17, 2005 at 11:28:56AM +0200, Vincent Lefevre [EMAIL PROTECTED] 
wrote:
 On 2005-07-17 11:10:40 +0300, Andreas Metzler wrote:
  On 2005-07-17 Eric Dorland [EMAIL PROTECTED] wrote:
   It's not entirely clear, are you saying that you only have these
   problems with mozilla-tabextensions?
 
 On my side, I've noticed problems with mozilla-tabextensions only.
 I don't know if the other extensions still work, but at least, they
 don't seem to make problems with the standard use of Firefox. But...
 
  | Just days after the releases of Mozilla Firefox 1.0.5 and Mozilla
  | Thunderbird 1.0.5, it appears likely that 1.0.6 versions of the two
  | applications could be coming as early as next week. It is understood
  | that API changes in 1.0.5 unintentionally broke some extensions.
 
 I've just read that in a French newsgroup. So, this is really a bug
 in Firefox (as it should have been a bug-fix release only).

If i got it correctly, this bug got introduced because of the changes to
the security model for XUL applications... so, for once, we can't really
blame the it should have been a bug-fix release only, since it is what
it was, except that security fixes has side effects.

Mike


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#318672: mozilla-firefox: should probably conflict with mozilla-tabextensions 1.14.2005051901-1

2005-07-16 Thread Vincent Lefevre
Package: mozilla-firefox
Version: 1.0.5-1
Severity: serious
Justification: Policy 7.3

There seem to be very important incompatibilities between
mozilla-firefox 1.0.5-1 (to which I've just upgraded) and
mozilla-tabextensions 1.14.2005051901-1.

I've done some tests with a new profile, trying it with and without
the tabextensions. The two bugs I've just reported are due to this
extension. I recall them here:

1) Bookmarks not visible until I click on Manage Bookmarks.

Just after Firefox starts up, the Bookmark menu contains only the
following items:
  * Bookmark This Page...
  * Manage Bookmarks...

I need to click on Manage Bookmarks... and close the window to
make the bookmarks appear in the Bookmarks menu.

2) Since the upgrade to 1.0.5-1, URLs can no longer be opened in new
tabs from a page, i.e. when I click on a link with the middle button
or when I click on Open Link in New Tab from the contextual menu.

But if I click with the middle button on a bookmark, the corresponding
URL is opened in a new tab as expected.


I don't know if these bugs need to be closed or reassigned to
mozilla-tabextensions.

The Find As You Type feature doesn't work either (no problems with
no extensions). I suspect that the whole interface gets seriously
broken due to this extension. So, this package should conflict with
mozilla-tabextensions (= 1.14.2005051901-1).

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (900, 'testing'), (900, 'stable'), (200, 'unstable')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-20050618
Locale: LANG=POSIX, LC_CTYPE=en_US.ISO8859-1 (charmap=ISO-8859-1)

Versions of packages mozilla-firefox depends on:
ii  debianutils2.14.1Miscellaneous utilities specific t
ii  fontconfig 2.3.2-1   generic font configuration library
ii  libatk1.0-01.10.1-2  The ATK accessibility toolkit
ii  libc6  2.3.2.ds1-22  GNU C Library: Shared libraries an
ii  libfontconfig1 2.3.2-1   generic font configuration library
ii  libfreetype6   2.1.7-2.4 FreeType 2 font engine, shared lib
ii  libgcc11:4.0.0-9 GCC support library
ii  libglib2.0-0   2.6.5-1   The GLib library of C routines
ii  libgtk2.0-02.6.8-1   The GTK+ graphical user interface 
ii  libidl00.8.5-1   library for parsing CORBA IDL file
ii  libjpeg62  6b-10 The Independent JPEG Group's JPEG 
ii  libkrb53   1.3.6-3   MIT Kerberos runtime libraries
ii  libpango1.0-0  1.8.1-1   Layout and rendering of internatio
ii  libpng12-0 1.2.8rel-1PNG library - runtime
ii  libstdc++6 4.0.1-2   The GNU Standard C++ Library v3
ii  libx11-6   4.3.0.dfsg.1-14   X Window System protocol client li
ii  libxext6   4.3.0.dfsg.1-14   X Window System miscellaneous exte
ii  libxft22.1.7-1   FreeType-based font drawing librar
ii  libxp6 4.3.0.dfsg.1-14   X Window System printing extension
ii  libxt6 4.3.0.dfsg.1-14   X Toolkit Intrinsics
ii  psmisc 21.6-1Utilities that use the proc filesy
ii  xlibs  4.3.0.dfsg.1-14   X Keyboard Extension (XKB) configu
ii  zlib1g 1:1.2.2-4.sarge.1 compression library - runtime

mozilla-firefox recommends no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]