Bug#321064: Clearing of passwords does not happen

2005-08-25 Thread Simon Morlat
Hello,

For now I have no idea. I'll try reproduce the bug with valgrind.

Simon

Le Vendredi 5 Août 2005 13:05, Martin Samuelsson a écrit :
 Samuel Mimram @ 2005-08-04 (Thursday), 19:12 (+0200)

  In the preferences dialog under the SIP tab there is a button to:
  Clear all stored authentication information
  However, when using it nothing happens. All information is still present
  in ~/.gnome2/linphone
  Clicking the same dialog twice results in a crash.
 
  Thanks for the report. I did not manage to make linphone crash by
  clicking twice. Could you give me a gdb stack trace?

 I'm providing one below. Although I don't know if it has enough
 information. Please let me know if there's anything else I should do.

 Thanks,

 (gdb) r
 Starting program: /usr/bin/linphone
 [Thread debugging using libthread_db enabled]
 [New Thread -1223708544 (LWP 6739)]
 [New Thread -1227625552 (LWP 6749)]

 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread -1223708544 (LWP 6739)]
 0xb75cdd89 in free () from /lib/tls/libc.so.6
 (gdb) bt full
 #0  0xb75cdd89 in free () from /lib/tls/libc.so.6
 No symbol table info available.
 #1  0xb7731ac4 in g_free () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 #2  0xb76c43d8 in linphone_auth_info_destroy (obj=0x81dd700) at
 authentication.c:63 No locals.
 #3  0xb76c498a in linphone_core_clear_all_auth_info (lc=0x8068bc0) at
 authentication.c:184 info = (LinphoneAuthInfo *) 0xfff9
 elem = (GList *) 0x8122748
 i = 1
 #4  0xb79412a6 in g_cclosure_marshal_VOID__VOID () from
 /usr/lib/libgobject-2.0.so.0 No symbol table info available.
 #5  0xb792f736 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #6  0xb7940dcf in g_signal_emit_by_name () from
 /usr/lib/libgobject-2.0.so.0 No symbol table info available.
 #7  0xb793fe9c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #8  0xb7940126 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #9  0xb7ab5af5 in gtk_button_clicked () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #10 0xb7ab697a in _gtk_button_paint () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #11 0xb79412a6 in g_cclosure_marshal_VOID__VOID () from
 /usr/lib/libgobject-2.0.so.0 No symbol table info available.
 #12 0xb792f9c9 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #13 0xb792f736 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #14 0xb7940651 in g_signal_emit_by_name () from
 /usr/lib/libgobject-2.0.so.0 No symbol table info available.
 #15 0xb793fe9c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #16 0xb7940126 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #17 0xb7ab5a65 in gtk_button_released () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #18 0xb7ab6823 in _gtk_button_paint () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #19 0xb7b7c47e in _gtk_marshal_BOOLEAN__BOXED () from
 /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available.
 #20 0xb792f9c9 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #21 0xb792f736 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #22 0xb7940855 in g_signal_emit_by_name () from
 /usr/lib/libgobject-2.0.so.0 No symbol table info available.
 #23 0xb793fc8c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #24 0xb7940126 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
 No symbol table info available.
 #25 0xb7c6bcf7 in gtk_widget_send_expose () from
 /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available.
 #26 0xb7b7af92 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #27 0xb7b79de6 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #28 0xb7a188e5 in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0
 No symbol table info available.
 #29 0xb772b5c2 in g_main_depth () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 #30 0xb772c638 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 #31 0xb772c970 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 #32 0xb772cf13 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
 No symbol table info available.
 #33 0xb7b79693 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
 No symbol table info available.
 #34 0x08050c6a in main (argc=0, argv=0x0) at main.c:65
 p = (void *) 0xfff9
 (gdb)



Bug#321064: Clearing of passwords does not happen

2005-08-25 Thread Martin Samuelsson
Simon Morlat @ 2005-08-24 (Wednesday), 23:27 (+0200)
 Hello,

Hi there,
 
 For now I have no idea. I'll try reproduce the bug with valgrind.

That's an idea I never though of, and silly enough it still chrashes for
me when running it through valgrind. :/

I'm not an total expert on valgrind either, but my expection was that a
memory access error shouldn't result in a chrash...

Spending a few minutes actually stepping through with gdb made me find
something suspicious. Applying the attached patch fixes the problem for
me, but I guess it's time to do an audit if more things are coded the
way that they assume g_list_free() should NULL the pointer.
--
/Martin
--- linphone-1.0.1/coreapi/authentication.c 2005-03-10 17:59:41.0 
+0100
+++ linphone-1.0.1-nocrash/coreapi/authentication.c 2005-08-25 
15:37:23.974222897 +0200
@@ -185,6 +185,7 @@
linphone_auth_info_write_config(lc-config,NULL,i);
}
g_list_free(lc-auth_info);
+   lc-auth_info = NULL;
 }
 
 gboolean linphone_core_find_or_ask_for_auth_info(LinphoneCore *lc,const char 
*username,const char* realm, gboolean force_ask)


Bug#321064: Clearing of passwords does not happen

2005-08-25 Thread Simon Morlat
Hello,

Great investigation !
In the 1.1.0 release I use the bug was fixed (I did not remember), that 's why 
it could not happen, even with valgrind.
Thanks

Simon

Le Jeudi 25 Août 2005 16:18, Martin Samuelsson a écrit :
 Simon Morlat @ 2005-08-24 (Wednesday), 23:27 (+0200)

  Hello,

 Hi there,

  For now I have no idea. I'll try reproduce the bug with valgrind.

 That's an idea I never though of, and silly enough it still chrashes for
 me when running it through valgrind. :/

 I'm not an total expert on valgrind either, but my expection was that a
 memory access error shouldn't result in a chrash...

 Spending a few minutes actually stepping through with gdb made me find
 something suspicious. Applying the attached patch fixes the problem for
 me, but I guess it's time to do an audit if more things are coded the
 way that they assume g_list_free() should NULL the pointer.
 --
 /Martin



Bug#321064: Clearing of passwords does not happen

2005-08-05 Thread Martin Samuelsson
Samuel Mimram @ 2005-08-04 (Thursday), 19:12 (+0200)
 In the preferences dialog under the SIP tab there is a button to:
 Clear all stored authentication information
 However, when using it nothing happens. All information is still present
 in ~/.gnome2/linphone
 Clicking the same dialog twice results in a crash.
 
 Thanks for the report. I did not manage to make linphone crash by clicking 
 twice. Could you give me a gdb stack 
 trace?

I'm providing one below. Although I don't know if it has enough information.
Please let me know if there's anything else I should do.

Thanks,

(gdb) r
Starting program: /usr/bin/linphone
[Thread debugging using libthread_db enabled]
[New Thread -1223708544 (LWP 6739)]
[New Thread -1227625552 (LWP 6749)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1223708544 (LWP 6739)]
0xb75cdd89 in free () from /lib/tls/libc.so.6
(gdb) bt full
#0  0xb75cdd89 in free () from /lib/tls/libc.so.6
No symbol table info available.
#1  0xb7731ac4 in g_free () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#2  0xb76c43d8 in linphone_auth_info_destroy (obj=0x81dd700) at 
authentication.c:63
No locals.
#3  0xb76c498a in linphone_core_clear_all_auth_info (lc=0x8068bc0) at 
authentication.c:184
info = (LinphoneAuthInfo *) 0xfff9
elem = (GList *) 0x8122748
i = 1
#4  0xb79412a6 in g_cclosure_marshal_VOID__VOID () from 
/usr/lib/libgobject-2.0.so.0
No symbol table info available.
#5  0xb792f736 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#6  0xb7940dcf in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#7  0xb793fe9c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#8  0xb7940126 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#9  0xb7ab5af5 in gtk_button_clicked () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#10 0xb7ab697a in _gtk_button_paint () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#11 0xb79412a6 in g_cclosure_marshal_VOID__VOID () from 
/usr/lib/libgobject-2.0.so.0
No symbol table info available.
#12 0xb792f9c9 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#13 0xb792f736 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#14 0xb7940651 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#15 0xb793fe9c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#16 0xb7940126 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#17 0xb7ab5a65 in gtk_button_released () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#18 0xb7ab6823 in _gtk_button_paint () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#19 0xb7b7c47e in _gtk_marshal_BOOLEAN__BOXED () from 
/usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#20 0xb792f9c9 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#21 0xb792f736 in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#22 0xb7940855 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#23 0xb793fc8c in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#24 0xb7940126 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#25 0xb7c6bcf7 in gtk_widget_send_expose () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#26 0xb7b7af92 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#27 0xb7b79de6 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#28 0xb7a188e5 in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0
No symbol table info available.
#29 0xb772b5c2 in g_main_depth () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#30 0xb772c638 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#31 0xb772c970 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#32 0xb772cf13 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#33 0xb7b79693 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#34 0x08050c6a in main (argc=0, argv=0x0) at main.c:65
p = (void *) 0xfff9
(gdb)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#321064: Clearing of passwords does not happen

2005-08-04 Thread Samuel Mimram

Hi,

Martin Samuelsson wrote:

Package: linphone
Version: 1.0.1-5

In the preferences dialog under the SIP tab there is a button to:
Clear all stored authentication information

However, when using it nothing happens. All information is still present
in ~/.gnome2/linphone

Clicking the same dialog twice results in a crash.


Thanks for the report. I did not manage to make linphone crash by 
clicking twice. Could you give me a gdb stack trace?


Regards,

Sam.


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#321064: Clearing of passwords does not happen

2005-08-03 Thread Martin Samuelsson
Package: linphone
Version: 1.0.1-5

In the preferences dialog under the SIP tab there is a button to:
Clear all stored authentication information

However, when using it nothing happens. All information is still present
in ~/.gnome2/linphone

Clicking the same dialog twice results in a crash.
--
/Martin


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]