Bug#322926: merging changes files breaks wrappers (like debuild)
On Sun, Dec 04, 2005 at 12:42:40AM +0300, Nikita V. Youshchenko wrote: Devscripts may handle this situation by just picking not $package_$version_$arch.changes, but instead find the file that matches $package_$version_*.changes pattern. In one of the the previous mails, I wrote that there should be only one such file; now when I realized the way how both $package_$version_source.changes and $package_$version_$arch.changes could be there. But taking the file that matches the pattern and has the largest ctime, should do the job in all cases. Surely mtime, not ctime? Julian -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#322926: merging changes files breaks wrappers (like debuild)
On Sun, Dec 04, 2005 at 12:42:40AM +0300, Nikita V. Youshchenko wrote: Devscripts may handle this situation by just picking not $package_$version_$arch.changes, but instead find the file that matches $package_$version_*.changes pattern. In one of the the previous mails, I wrote that there should be only one such file; now when I realized the way how both $package_$version_source.changes and $package_$version_$arch.changes could be there. But taking the file that matches the pattern and has the largest ctime, should do the job in all cases. Surely mtime, not ctime? Looks so :) pgpRUrMV2R8qX.pgp Description: PGP signature
Bug#322926: merging changes files breaks wrappers (like debuild)
Hi,
If dpkg-cross is installed, it provides it's own dpkg-buildpackage,
which potentially replaces the *_${arch}.changes file with
*_source+${arch}.changes. When debuild calls helpers like lintian or
debsign, these will fail because debuild assumes the
*_${arch}.changes filename.
[...]
I tried to reproduce the situation where 'source+arch' appears, but failed.
And, as far as I can read the code, dpkg-cross version of dpkg-buildpackage
should not do this.
First, before doing any .changes processing, it checks if there are exactly
two files that match pattern ${package}_${version}_*.changes; if there is
only one (which should be the case when not cross-compiling), it does not
touch .changes.
Second, if there are two matching files, the 'arch part' of the name of
merged changes file is built from 'arch parts' of existing .changes files.
This procedure can't add 'source' there unless it was already there on
original files.
So could the bug submitter please help to reproduce the situation?
As for debuld, if it wishes to support cross-compiling case, when
just-created .changes file may be merged with previous-existing .changes
file for other architecurre(s), it could get .changes file not with
$changes=${pkg}_${sversion}_${arch}.changes
but instead check for a file that matches the pattern
${pkg}_${sversion}_*.changes
There should be exactly one such file, either one created by
dpkg-buildpackage, or the result of merge.
Nikita
pgp90xvN6U1wd.pgp
Description: PGP signature
Bug#322926: merging changes files breaks wrappers (like debuild)
I tried to reproduce the situation where 'source+arch' appears, but
failed.
And, as far as I can read the code, dpkg-cross version of
dpkg-buildpackage should not do this.
First, before doing any .changes processing, it checks if there are
exactly two files that match pattern ${package}_${version}_*.changes; if
there is only one (which should be the case when not cross-compiling),
it does not touch .changes.
Second, if there are two matching files, the 'arch part' of the name of
merged changes file is built from 'arch parts' of existing .changes
files. This procedure can't add 'source' there unless it was already
there on original files.
I probably understood how 'sources' come in.
If one first runs 'dpkg-buildpackage -S', a .changes file will be created
with 'sources' in the arch part of the name. Later, if 'dpkg-buildpackage'
is run to create binary packages, it creates a .changes file with real
arch part of the name; so there are two .changes files, and they are
merged.
Probably a good workaround will be not to include 'source' in the merged
file name in such case. Committed this workaround to dpkg-cross CVS. This
will be in dpkg-cross 1.26
Don't know what to do with this bug now. Probably submitter or debuild
maintainer should decide if this is enough to close it.
Nikita
pgpEAP5dqMk1p.pgp
Description: PGP signature
Bug#322926: merging changes files breaks wrappers (like debuild)
On Sat, Dec 03, 2005 at 11:41:14PM +0300, Nikita V. Youshchenko wrote: I probably understood how 'sources' come in. If one first runs 'dpkg-buildpackage -S', a .changes file will be created with 'sources' in the arch part of the name. Later, if 'dpkg-buildpackage' is run to create binary packages, it creates a .changes file with real arch part of the name; so there are two .changes files, and they are merged. Probably a good workaround will be not to include 'source' in the merged file name in such case. Committed this workaround to dpkg-cross CVS. This will be in dpkg-cross 1.26 Don't know what to do with this bug now. Probably submitter or debuild maintainer should decide if this is enough to close it. Please could you look at bug #217546? I think this is probably the same thing, which you have now fixed, but I am not certain. Thanks! Julian (as devscripts/debuild maintainer) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#322926: merging changes files breaks wrappers (like debuild)
On Sat, Aug 20, 2005 at 11:32:07PM +0400, Nikita V. Youshchenko wrote:
Package: dpkg-cross, devscripts, dpkg-dev
Severity: normal
If dpkg-cross is installed, it provides it's own dpkg-buildpackage,
which potentially replaces the *_${arch}.changes file with
*_source+${arch}.changes. When debuild calls helpers like lintian or
debsign, these will fail because debuild assumes the
*_${arch}.changes filename.
[...]
Thank you for the bug report.
Dpkg-cross still needs to be adopted to post-sarge changes in dpkg.
I'm at last back from all summer trips, and hope to do this work on
the ongoing weeks. While doing it, I will look what can be done do
with this issue.
Any further thoughts on this?
I will make dpkg-cross version of buildpackage to behave exactly as
dpkg-dev version does.
This will be either in the next upload, or in one after next.
Curently, dpkg-cross is already ported to post-sarge, but I'm currently in
progress of updateing gcc-40 cross-compiler build procedure. I need to
test how new dpkg-cross actually cross-compiles, and to do this, I need
newer cross-gcc debs first.
I hope to have an upload soon (actually, I've already suceed to build new
cross-gcc debs, but there are some glitches with them, and I still need to
test cross-compiling with dpkg-cross).
Nikita
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#322926: merging changes files breaks wrappers (like debuild)
On Sat, Aug 20, 2005 at 11:32:07PM +0400, Nikita V. Youshchenko wrote:
Package: dpkg-cross, devscripts, dpkg-dev
Severity: normal
If dpkg-cross is installed, it provides it's own dpkg-buildpackage,
which potentially replaces the *_${arch}.changes file with
*_source+${arch}.changes. When debuild calls helpers like lintian or
debsign, these will fail because debuild assumes the
*_${arch}.changes filename.
[...]
Thank you for the bug report.
Dpkg-cross still needs to be adopted to post-sarge changes in dpkg.
I'm at last back from all summer trips, and hope to do this work on the
ongoing weeks. While doing it, I will look what can be done do with this
issue.
Any further thoughts on this?
Julian
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#322926: merging changes files breaks wrappers (like debuild)
Package: dpkg-cross, devscripts, dpkg-dev
Severity: normal
If dpkg-cross is installed, it provides it's own dpkg-buildpackage,
which potentially replaces the *_${arch}.changes file with
*_source+${arch}.changes. When debuild calls helpers like lintian or
debsign, these will fail because debuild assumes the
*_${arch}.changes filename.
Either dpkg-buildpackage should communicate the name back to
debuild, or (better) dpkg-buildpackage should be able to call
helpers itself so that debuild could call it passing a hook script
as a wrapper:
dpkg-buildpackage --post-build-hooks debuild-hooks
I am assigning this bug to
- dpkg-cross because it's the source of the problem
- devscripts and dpkg-dev so that you all can work out an optimal
solution. :)
Thank you for the bug report.
Dpkg-cross still needs to be adopted to post-sarge changes in dpkg.
I'm at last back from all summer trips, and hope to do this work on the
ongoing weeks. While doing it, I will look what can be done do with this
issue.
Nikita
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#322926: merging changes files breaks wrappers (like debuild)
Package: dpkg-cross, devscripts, dpkg-dev
Severity: normal
If dpkg-cross is installed, it provides it's own dpkg-buildpackage,
which potentially replaces the *_${arch}.changes file with
*_source+${arch}.changes. When debuild calls helpers like lintian or
debsign, these will fail because debuild assumes the
*_${arch}.changes filename.
Either dpkg-buildpackage should communicate the name back to
debuild, or (better) dpkg-buildpackage should be able to call
helpers itself so that debuild could call it passing a hook script
as a wrapper:
dpkg-buildpackage --post-build-hooks debuild-hooks
I am assigning this bug to
- dpkg-cross because it's the source of the problem
- devscripts and dpkg-dev so that you all can work out an optimal
solution. :)
Thanks.
-- System Information:
Debian Release: 3.1
APT prefers stable
APT policy: (700, 'stable'), (600, 'testing'), (98, 'unstable'), (1,
'experimental')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-cirrus
Locale: LANG=en_GB, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Versions of packages dpkg-cross depends on:
ii binutils 2.16.1-2 The GNU assembler, linker and bina
ii dpkg-dev 1.13.10Package building tools for Debian
ii file 4.12-1 Determines file type using magic
dpkg-cross recommends no packages.
-- no debconf information
--
.''`. martin f. krafft [EMAIL PROTECTED]
: :' :proud Debian developer and author: http://debiansystem.info
`. `'`
`- Debian - when you have better things to do than fixing a system
Invalid/expired PGP (sub)keys? Use subkeys.pgp.net as keyserver!
have you drugged your kids today?
signature.asc
Description: Digital signature (GPG/PGP)
