Bug#324040: bash: Error during completion of LVM LV and PV names (forwarded from Paul Brook)

[Ian Macdonald]

On Mon 05 Sep 2005 at 13:54:32 +0200, you wrote:

 X-Loop: [EMAIL PROTECTED]
 Reply-To: Paul Brook [EMAIL PROTECTED], [EMAIL PROTECTED]
 X-Debian-PR-Message: report 324040
 X-Debian-PR-Package: bash
 X-Debian-PR-Keywords: patch
 X-Mailer: reportbug 3.15
 Delivered-To: [EMAIL PROTECTED]
 X-Virus-Scanned: by amavisd-new at cs.tu-berlin.de (including spamassassin)
 X-Spam-Status: No, hits=0 tagged_above=0 required=3 tests=
 X-Spam-Level: 
 Resent-From: Paul Brook [EMAIL PROTECTED]
 Resent-To: debian-bugs-dist@lists.debian.org
 Resent-CC: Matthias Klose [EMAIL PROTECTED]
 Resent-Date: Fri, 19 Aug 2005 22:48:09 UTC
 Resent-Message-ID: [EMAIL PROTECTED]
 Resent-Sender: Debian BTS [EMAIL PROTECTED]
 From: Paul Brook [EMAIL PROTECTED]
 To: Debian Bug Tracking System [EMAIL PROTECTED]
 Subject: Bug#324040: bash: Error during completion of LVM LV and PV names
 Date: Fri, 19 Aug 2005 23:40:42 +0100
 
 Package: bash
 Version: 3.0-15
 Severity: normal
 Tags: patch
 
 
 Command completion for LVM Physical Volume and Logical Volume names is
 broken. For example lvdisplay /dev/tab gives:
 
 awk:  ^ syntax error
 awk: {if ($2 ~ /^/dev//) print $2}
 awk:   ^ unterminated regexp
 awk: cmd. line:1: {if ($2 ~ /^/dev//) print $2}
 awk: cmd. line:1:  ^ unexpected newline or end of 
 string
 
 Device names typically contain forward slash characters (/).
 These need escaping before embedding them in awk patterns.
 
 Patch attached.
 
 Paul
 
 -- System Information:
 Debian Release: testing/unstable
   APT prefers unstable
   APT policy: (500, 'unstable')
 Architecture: i386 (i686)
 Shell:  /bin/sh linked to /bin/bash
 Kernel: Linux 2.6.13-rc6-w
 Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)
 
 Versions of packages bash depends on:
 ii  base-files  3.1.6Debian base system miscellaneous 
 f
 ii  libc6   2.3.2.ds1-22 GNU C Library: Shared libraries 
 an
 ii  libncurses5 5.4-8Shared libraries for terminal 
 hand
 ii  passwd  1:4.0.3-37   change and administer password 
 and
 
 bash recommends no packages.
 
 -- no debconf information

 --- bash_completion.old   2005-08-19 23:19:02.0 +0100
 +++ bash_completion   2005-08-19 23:27:43.0 +0100
 @@ -6762,13 +6762,13 @@
  _physicalvolumes()
  {
   COMPREPLY=( $( pvscan | \
 - awk '/PV/ {if ($2 ~ /^'$cur'/) print $2}' ) )
 + awk '/PV/ {if ($2 ~ /^'${cur//\//\\\/}'/) print $2}' ) )
  }
  
  _logicalvolumes()
  {
   COMPREPLY=( $( lvscan 2/dev/null | \
 - awk -F' '{if ($2 ~ /^'$cur'/) print $2}' ) )
 + awk -F' '{if ($2 ~ /^'${cur//\//\\\/}'/) print $2}' ) )
  }
  
  _units()

This problem was fixed in the previous release.

Ian
-- 
Ian Macdonald   | A man said to the Universe:  Sir, I
[EMAIL PROTECTED] | exist!  However, replied the Universe,  
http://www.caliban.org/ | the fact has not created in me a sense of 
| obligation.   -- Stephen Crane 
| 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#324040: bash: Error during completion of LVM LV and PV names

[Paul Brook]

Package: bash
Version: 3.0-15
Severity: normal
Tags: patch


Command completion for LVM Physical Volume and Logical Volume names is
broken. For example lvdisplay /dev/tab gives:

awk:  ^ syntax error
awk: {if ($2 ~ /^/dev//) print $2}
awk:   ^ unterminated regexp
awk: cmd. line:1: {if ($2 ~ /^/dev//) print $2}
awk: cmd. line:1:  ^ unexpected newline or end of 
string

Device names typically contain forward slash characters (/).
These need escaping before embedding them in awk patterns.

Patch attached.

Paul

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13-rc6-w
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)

Versions of packages bash depends on:
ii  base-files  3.1.6Debian base system miscellaneous f
ii  libc6   2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libncurses5 5.4-8Shared libraries for terminal hand
ii  passwd  1:4.0.3-37   change and administer password and

bash recommends no packages.

-- no debconf information
--- bash_completion.old 2005-08-19 23:19:02.0 +0100
+++ bash_completion 2005-08-19 23:27:43.0 +0100
@@ -6762,13 +6762,13 @@
 _physicalvolumes()
 {
COMPREPLY=( $( pvscan | \
-   awk '/PV/ {if ($2 ~ /^'$cur'/) print $2}' ) )
+   awk '/PV/ {if ($2 ~ /^'${cur//\//\\\/}'/) print $2}' ) )
 }
 
 _logicalvolumes()
 {
COMPREPLY=( $( lvscan 2/dev/null | \
-   awk -F' '{if ($2 ~ /^'$cur'/) print $2}' ) )
+   awk -F' '{if ($2 ~ /^'${cur//\//\\\/}'/) print $2}' ) )
 }
 
 _units()