Bug#330812: source the script

2005-11-07 Thread Justin Pryzby
Why not source the script?  Error in the script should IMHO be
detected and cause the initscript to fail.

-- 
Clear skies,
Justin


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#330812: source the script

2005-11-07 Thread Drew Parsons
On Mon, 2005-11-07 at 18:24 -0500, Justin Pryzby wrote:
 Why not source the script?  Error in the script should IMHO be
 detected and cause the initscript to fail.
 

If I understand Eduard's case properly, I think I don't want to do that
because I specifically do *not* want to run the script in the case where
the local admin has deliberately made it non-executable.  The issue at
hand is disabling daemons from running, while having them installed.

Drew



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#330812: source the script

2005-11-07 Thread Stephen Gran
This one time, at band camp, Drew Parsons said:
 On Mon, 2005-11-07 at 18:24 -0500, Justin Pryzby wrote:
  Why not source the script?  Error in the script should IMHO be
  detected and cause the initscript to fail.
 
 If I understand Eduard's case properly, I think I don't want to do that
 because I specifically do *not* want to run the script in the case where
 the local admin has deliberately made it non-executable.  The issue at
 hand is disabling daemons from running, while having them installed.

It occurs to me that the simplest thing to do here is to just do the
simplest thing.  If the fear is that file may not be executable, then
test for that.

XPSERVERLIST=`[ ! -x /etc/init.d/xprint ] || /etc/init.d/xprint 
get_xpserverlist`

Take care,
-- 
 -
|   ,''`.Stephen Gran |
|  : :' :[EMAIL PROTECTED] |
|  `. `'Debian user, admin, and developer |
|`- http://www.debian.org |
 -


signature.asc
Description: Digital signature


Bug#330812: source the script

2005-11-07 Thread Drew Parsons
On Tue, 2005-11-08 at 00:44 +, Stephen Gran wrote:
 This one time, at band camp, Drew Parsons said:
  On Mon, 2005-11-07 at 18:24 -0500, Justin Pryzby wrote:
   Why not source the script?  Error in the script should IMHO be
   detected and cause the initscript to fail.
  
  If I understand Eduard's case properly, I think I don't want to do that
  because I specifically do *not* want to run the script in the case where
  the local admin has deliberately made it non-executable.  The issue at
  hand is disabling daemons from running, while having them installed.
 
 It occurs to me that the simplest thing to do here is to just do the
 simplest thing.  If the fear is that file may not be executable, then
 test for that.
 
 XPSERVERLIST=`[ ! -x /etc/init.d/xprint ] || /etc/init.d/xprint 
 get_xpserverlist`
 

This seems reasonable to me.  As far as I can see it satisfactorily
manages both Eduard's and Justin's comments.

Drew



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]