Bug#345973: New cups configuration splitout breaks Kprinter

2006-01-04 Thread Christopher Martin
Package: cupsys
Version: 1.1.23-13
Severity: important

I'm filing my mailing list message as a bug, since it didn't receive a 
response when sent to the mailing list directly.

In summary, the splitting out of the Port and Listen settings has broken 
Kprinter. Details below.

Thanks,
Christopher Martin

 On Tuesday 20 December 2005 15:28, Martin Pitt wrote:
  No, it is a pain, because cupsd.conf is a big conffile that gets
  changed in cups from time to time. No need to bother users with dpkg
  questions if they only changed Ports/Listen parameters.
 
  Packages should not modify conffiles of other packages, i. e. kprint
  modify /etc/cups/cupsd.conf. They may, however, change other package's
  configuration files, so splitting out these settings into separate
  files actually helps these packages.

 I'm not sure I understand the distinction you're making here. In any
 case, kprinter configures CUPS by modifying /etc/cups/cupsd.conf; it can
 alter many settings, including those related to Port and Browsing. Now
 that these the Port and Browsing settings have been split out, trying to
 configure CUPS using kprinter results in an error, where kprinter
 complains about unknown items include, and decides to leave them to be
 safe. The problem is that if you use kprinter to configure CUPS, you will
 wind up two sets of Port/Browsing settings; one in cupsd.conf (put there
 by kprinter), and one from the included files. If this works at all, it
 will cause user confusion about which setting to change, leading them to
 think they may be making CUPS secure when it isn't, overriding the
 settings they think they set with debconf, etc. In other words, this
 change has made kprinter broken and dangerous.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#345973: New cups configuration splitout breaks Kprinter

2006-01-04 Thread Roger Leigh
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Christopher Martin [EMAIL PROTECTED] writes:

 Package: cupsys
 Version: 1.1.23-13
 Severity: important

 I'm filing my mailing list message as a bug, since it didn't receive a 
 response when sent to the mailing list directly.

 In summary, the splitting out of the Port and Listen settings has broken 
 Kprinter. Details below.

This looks like a serious bug in kprinter: it doesn't know how to
correctly parse the CUPS configuration file.  While the CUPS split
configuration shows up the bug, it is not a bug in CUPS, in my
opinion.

This should probably be reassigned to kprinter.  If kprinter is now
actively dangerous, the severity can also be raised.


Regards,
Roger

- -- 
Roger Leigh
Printing on GNU/Linux?  http://gimp-print.sourceforge.net/
Debian GNU/Linuxhttp://www.debian.org/
GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Processed by Mailcrypt 3.5.8+ http://mailcrypt.sourceforge.net/

iD8DBQFDu/dnVcFcaSW/uEgRAi4nAJ0d6nga7M01a4M/IPrVKDvir2Sc9gCgvebx
++dVDa5S9YaQ7Fdfefw2OFs=
=YSLr
-END PGP SIGNATURE-


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#345973: New cups configuration splitout breaks Kprinter

2006-01-04 Thread Christopher Martin
On Wednesday 04 January 2006 11:27, you wrote:
 Christopher Martin [EMAIL PROTECTED] writes:
  Package: cupsys
  Version: 1.1.23-13
  Severity: important
 
  I'm filing my mailing list message as a bug, since it didn't receive a
  response when sent to the mailing list directly.
 
  In summary, the splitting out of the Port and Listen settings has
  broken Kprinter. Details below.

 This looks like a serious bug in kprinter: it doesn't know how to
 correctly parse the CUPS configuration file.  While the CUPS split
 configuration shows up the bug, it is not a bug in CUPS, in my
 opinion.

 This should probably be reassigned to kprinter.  If kprinter is now
 actively dangerous, the severity can also be raised.

Kprinter basically reads in the existing settings, then completely rewrites 
cupsd.conf with any user-specified changes. Already a dodgy way of doing 
things, granted, but not trivial to patch.

Given this, consider the complexity involved in it following the Include 
files in cupsd.conf. It would have to remember that certain settings 
belonged to each include, and ensure that when written out, these settings 
were written to the relevant include, not the main cupsd.conf. Now imagine 
that a user has commented out a setting in one of the includes. Kprinter, 
when writing its settings, places the setting (which as far as it knows 
wasn't set anywhere) in cupsd.conf. The user now uncomments the settings in 
one of the included files. Which setting counts? Does the user realize what 
they've done?

I understand that you'd rather reassign this bug and tell KDE to re-write 
their printer tools, but I'm not sure that this will yield results. This 
bug is an attempt to at least make the CUPS team aware of what's happened, 
i.e. the full implications of the recent changes, and ask for suggestions 
as much as anything else; if you can think of a solution, then great.

Cheers,
Christopher Martin


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]