Bug#346511: ext3 online resizing doesn't work

[Tore Anderson]

Package: linux-2.6
Version: 2.6.15-1

  I can't get online resizing of ext3 to work.  The kernel spits out

EXT3-fs: Unrecognized mount option resize=1572864 or missing value

  when I try to remount the filesystem, supplying the resize option.
 Documentation/filesystems/ext3.txt says it should be there, and from
 what I can understand of fs/ext3/super.c and its parse_options() the
 resize option is supposed to be understood by the kernel.  Am I doing
 something wrong?  I have created the file system using mkfs -E resize.
 Resizing JFS (using the exact same procedure) works just fine.

-- 
Tore Anderson



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#346511: ext3 online resizing doesn't work

[Tore Anderson]

* Tore Anderson

   I can't get online resizing of ext3 to work.

  After some more debugging it seems that the resize option isn't
 correctly parsed by fs/ext3/super.c.  Patch attached.  However, I'm not
 too sure if it is correct, right now my mount process is hanging in
 blocking I/O state, and there's almost no disk activity.  I started it
 two and a half hour ago...  The only thing the kernel had to say about
 it was:

EXT3-fs warning (device dm-3): ext3_group_extend: will only finish group 
(4194305 blocks, 1 new)

  I suspect ext2online(8) is the only supported way of doing online
 resizing, and that the resize= mount option is intentionally broken
 because of that.  Perhaps it's a relic from the early days of the code
 in question...  But I don't know.

-- 
Tore Anderson
Fix parsing of the resize=nblocks ext3 (re)mount option.

Signed-off-by: Tore Anderson [EMAIL PROTECTED]

diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 4e67306..1eb16f5 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -681,8 +681,8 @@ static match_table_t tokens = {
{Opt_quota, quota},
{Opt_usrquota, usrquota},
{Opt_barrier, barrier=%u},
+   {Opt_resize, resize=%u},
{Opt_err, NULL},
-   {Opt_resize, resize},
 };
 
 static unsigned long get_sb_block(void **data)

Bug#346511: ext3 online resizing doesn't work

[Tore Anderson]

* Bastian Blank

 Stock linux does not support online resizing of ext3.

  It does (since 2.6.10).  I've successfully extended mounted ext3 file
 systems using ext2online from ext2resize 1.1.19-3 on an unmodified
 2.6.15-1-k7.  

  However the more I've looked into it, the more certain I've become
 that it is Documentation/filesystems/ext3.txt that is incorrect - the
 resize=nblocks mount option is probably disabled due to the fact that
 it's not working properly;  using ext2online(8) is currently the only
 way to do it.  Or so it seems to me.

  I just submitted a patch upstream that corrects the documentation, so
 it's probably going to be fixed in the next upstream release, but it's
 fine by me to close the bug already now anyway.

Kind regards
-- 
Tore Anderson



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]