Bug#349305: solution for kernel oops found
* Gasper Zejn <[EMAIL PROTECTED]> [2006-02-06 14:19]: > diff -ur sl-modem-2.9.9d+e-pre2.original/drivers/amrmo_init.c > -#define CLASS_DEVICE_CREATE(class, dev, device, fmt, rest) > class_device_create(class, dev, device, fmt, rest) > +#define CLASS_DEVICE_CREATE(class, dev, device, fmt, rest) > class_device_create(class, NULL, dev, device, fmt, rest) I can confirm both the Oops at boot time as well as the fact that the above patch fixed the problem for me. I'm on a Thinkpad R50p, short system info is below. Wolfgang nautis:~# uname -a Linux nautis 2.6.15-1-686 #1 Wed Jan 18 15:04:35 UTC 2006 i686 GNU/Linux nautis:~# lspci -v | less [snip] :00:1f.6 Modem: Intel Corporation 82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller (rev 01) (prog-if 00 [Generic]) Subsystem: IBM: Unknown device 0525 Flags: bus master, medium devsel, latency 0, IRQ 11 I/O ports at 2400 [size=256] I/O ports at 2000 [size=128] Capabilities: [50] Power Management version 2 [snap] nautis:~# dpkg-query --list "sl-modem*" ii sl-modem-daemon2.9.9d+e-pre2-2SmartLink software modem daemon ii sl-modem-modules-2 2.9.9d+e-pre2-2+10 Smart Link modem modules for Linux (kernel 2.6.15-1-686) ii sl-modem-source2.9.9d+e-pre2-2SmartLink software modem driver - module building source -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#349305: solution for kernel oops found
Package: sl-modem-source Version: 2.9.9d+e-pre2 Tags: patch This is the diff: diff -ur sl-modem-2.9.9d+e-pre2.original/drivers/amrmo_init.c sl-modem-2.9.9d+e-pre2/drivers/amrmo_init.c --- sl-modem-2.9.9d+e-pre2.original/drivers/amrmo_init.c 2006-02-06 14:13:49.0 +0100 +++ sl-modem-2.9.9d+e-pre2/drivers/amrmo_init.c 2006-02-06 14:14:22.0 +0100 @@ -287,7 +287,7 @@ #define CLASS_CREATE(owner, name) class_simple_create(owner, name) static struct class_simple *amrmo_class; #else -#define CLASS_DEVICE_CREATE(class, dev, device, fmt, rest) class_device_create(class, dev, device, fmt, rest) +#define CLASS_DEVICE_CREATE(class, dev, device, fmt, rest) class_device_create(class, NULL, dev, device, fmt, rest) #define CLASS_DESTROY(class) class_destroy(class) #define CLASS_DEVICE_DESTROY(class, dev) class_device_destroy(class, dev) #define CLASS_CREATE(owner, name) class_create(owner, name) I followed the recipe here [1] (especially the last post) and the modem works as expected when I modified amrmo_init.c. Kind regards, Gasper Z. [1] http://www.linux-on-laptops.com/forum/showthread.php?s=c919a4241b4dfc4e92b2d20e639060a9&p=417#post417 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]