Bug#350381: dependency on lsb-base

2006-01-29 Thread Marco d'Itri
Package: pcmciautils
Severity: minor

Please remove from the init script the code which works around a missing
lsb-base package. udev and module-init-tools depend on it so it will
always be available (and you should not feel bad to depend on a
Priority: required package anyway).

Please also clean up statements like [ x$VERBOSE = xno ], the x has
never been needed on Linux systems.

It may also be a good idea to refactor the udev rules file to have a
single check for ACTION==add.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#350381: dependency on lsb-base

2006-01-29 Thread Colin Watson
On Sun, Jan 29, 2006 at 12:26:43PM +0100, Marco d'Itri wrote:
 Package: pcmciautils
 Severity: minor
 
 Please remove from the init script the code which works around a missing
 lsb-base package. udev and module-init-tools depend on it so it will
 always be available (and you should not feel bad to depend on a
 Priority: required package anyway).

No, I cannot do this because the same init script is used in the
installer which doesn't have the lsb-base functions available. pcmcia is
the only case where this happens so it's not worth adding shims to the
installer just for it.

 Please also clean up statements like [ x$VERBOSE = xno ], the x has
 never been needed on Linux systems.

Done in my tree.

 It may also be a good idea to refactor the udev rules file to have a
 single check for ACTION==add.

I'm in a rush right now, but I'll have a look at this next time I have
some spare time.

Thanks,

-- 
Colin Watson   [EMAIL PROTECTED]


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]