Bug#354953: Similar problems with dpkg-parsechangelog

[Davor Ocelic]

On Sat, Mar 04, 2006 at 05:36:21PM -0500, Joey Hess wrote:
> Davor Ocelic wrote:
> > Basically the same problem occurs at a place where debhelper would want
> > to call dpkg-parsechangelog.
> 
> Where, here?
> 
> my $version=`dpkg-parsechangelog -l$isnative_changelog`;
> ($dh{VERSION})=$version=~m/Version:\s*(.*)/m;
> # Did the changelog parse fail?
> if (! defined $dh{VERSION}) {
> error("changelog parse failure");
> }
> 
> Seems fine.

No, in the debian/rules file:

# Figure out the `current debhelper version.
VERSION=$(shell expr "`dpkg-parsechangelog 2>/dev/null |grep Version:`" : 
'.*Version: \(.*\)')


> > Maybe a good solution would be not to redirect stderr to /dev/null; this
> > way, all messages would be clearly visible, and I think they wouldn't
> > print anything to stderr in normal course of operation anyway.
> 
> I don't know what stderr redirection you're referring to.

I am primarily referring to the case above, but also other cases that
satisfy the above assumption of "not printing anything on stderr in 
normal course of operation". Try invoking

  grep -r 'dev\/null' *  | grep -v which | grep 2

to see some of such cases.

Regards,
-doc


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#354953: Similar problems with dpkg-parsechangelog

[Joey Hess]

Davor Ocelic wrote:
> Basically the same problem occurs at a place where debhelper would want
> to call dpkg-parsechangelog.

Where, here?

my $version=`dpkg-parsechangelog -l$isnative_changelog`;
($dh{VERSION})=$version=~m/Version:\s*(.*)/m;
# Did the changelog parse fail?
if (! defined $dh{VERSION}) {
error("changelog parse failure");
}

Seems fine.

> Maybe a good solution would be not to redirect stderr to /dev/null; this
> way, all messages would be clearly visible, and I think they wouldn't
> print anything to stderr in normal course of operation anyway.

I don't know what stderr redirection you're referring to.

-- 
see shy jo


signature.asc
Description: Digital signature

Bug#354953: Similar problems with dpkg-parsechangelog

[Davor Ocelic]

Basically the same problem occurs at a place where debhelper would want
to call dpkg-parsechangelog.

Maybe a good solution would be not to redirect stderr to /dev/null; this
way, all messages would be clearly visible, and I think they wouldn't
print anything to stderr in normal course of operation anyway.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]