Bug#355883: Same problem here

2008-08-20 Thread Adam Cécile (Le_Vert)

Leandro Dorileo a écrit :

Hi Adam

Adam Cécile (Le_Vert) wrote:

Bastian Blank a écrit :
 

On Tue, Aug 19, 2008 at 06:50:11PM +0200, Adam Cécile (Le_Vert) wrote:
 
I can confirm this bug 2.6.26-1-amd64 and a slightly modified 
rebuild of

the i386 flavour.
My usb stick is unusable.
  

I doubt that you see the same bug. Try #494800.
  

Check reply by Kumar Appaiah (20080812). He re-opened this bug against
kernel 2.6.26.
 
 

I noticed severity has been dropped from important to normal. Any
justification ?
  

Someone which is not submitter or maintainer changed it.

 

I'd rather say it's critical. Everybody needs usb sticks
  

No. Many of my machines don't even have usb.
  

No comment.
 

Bastian
  

I found the attached patch somewhere on lkml. It's targeted for kernel
2.6.27. I can confirm this patch fix the issue with my stick.
  
This patch hasn`t taken to Linus`s tree yet but has been queued by 
Greg K-H, guess we`ll see it merged until 2.6.27.
I hope it will be merged into debian's package before it reach main 
linux development tree.

If not I'll have to downgrade to 2.6.25...



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#355883: Same problem here

2008-08-20 Thread Kumar Appaiah
Hi!

Just wanted to add that this bug doesn't exist in the latest kernel I
got from the SCM (2.6.27-rc3). So it got fixed in between 2.6.26 and
now somewhere; I couldn't zero in on the patch which Adam pointed
out. But anyway...


On Wed, Aug 20, 2008 at 09:44:10AM +0200, Adam Cécile (Le_Vert) wrote:
 No. Many of my machines don't even have usb.
   
 No comment.
  

Sorry Bastian, but it's sort of unfair that you reduced the
severity. Granted that it was raised by a non-maintainer, and that you
don't use USB sticks. But that doesn't imply that all users won't have
it.

In fact, I'd really want this to be RC, but I don't want to fall into
anyone's bad books, so I'll just stop with making a request for a
severity upgrade.

 I found the attached patch somewhere on lkml. It's targeted for kernel
 2.6.27. I can confirm this patch fix the issue with my stick.
   
 This patch hasn`t taken to Linus`s tree yet but has been queued by  
 Greg K-H, guess we`ll see it merged until 2.6.27.
 I hope it will be merged into debian's package before it reach main  
 linux development tree.
 If not I'll have to downgrade to 2.6.25...

The latest version on git.kernel.org seems to have his fix. Commit
59f4ff2ecff4cef36378928cec891785b402e80c [1] seems to have been added
a week ago.

HTH. Thanks to all.

Kumar

[1]: 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=59f4ff2ecff4cef36378928cec891785b402e80c
-- 
Kumar Appaiah


signature.asc
Description: Digital signature


Bug#355883: Same problem here

2008-08-19 Thread Adam Cécile (Le_Vert)
Hello,

I can confirm this bug 2.6.26-1-amd64 and a slightly modified rebuild of
the i386 flavour.
My usb stick is unusable.

I noticed severity has been dropped from important to normal. Any
justification ?

I'd rather say it's critical. Everybody needs usb sticks

Regards, Adam.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#355883: Same problem here

2008-08-19 Thread Bastian Blank
On Tue, Aug 19, 2008 at 06:50:11PM +0200, Adam Cécile (Le_Vert) wrote:
 I can confirm this bug 2.6.26-1-amd64 and a slightly modified rebuild of
 the i386 flavour.
 My usb stick is unusable.

I doubt that you see the same bug. Try #494800.

 I noticed severity has been dropped from important to normal. Any
 justification ?

Someone which is not submitter or maintainer changed it.

 I'd rather say it's critical. Everybody needs usb sticks

No. Many of my machines don't even have usb.

Bastian

-- 
... The prejudices people feel about each other disappear when they get
to know each other.
-- Kirk, Elaan of Troyius, stardate 4372.5



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#355883: Same problem here

2008-08-19 Thread Adam Cécile (Le_Vert)
Bastian Blank a écrit :
 On Tue, Aug 19, 2008 at 06:50:11PM +0200, Adam Cécile (Le_Vert) wrote:
   
 I can confirm this bug 2.6.26-1-amd64 and a slightly modified rebuild of
 the i386 flavour.
 My usb stick is unusable.
 

 I doubt that you see the same bug. Try #494800.
   
Check reply by Kumar Appaiah (20080812). He re-opened this bug against
kernel 2.6.26.
   
 I noticed severity has been dropped from important to normal. Any
 justification ?
 

 Someone which is not submitter or maintainer changed it.

   
 I'd rather say it's critical. Everybody needs usb sticks
 

 No. Many of my machines don't even have usb.
   
No comment.
 Bastian
   
I found the attached patch somewhere on lkml. It's targeted for kernel
2.6.27. I can confirm this patch fix the issue with my stick.

Regards, Adam.

--- drivers/usb/storage/transport.c	2008-07-13 21:51:29.0 +
+++ drivers/usb/storage/transport.c.new	2008-08-19 17:38:28.510241535 +
@@ -1034,8 +1034,21 @@
 
 	/* try to compute the actual residue, based on how much data
 	 * was really transferred and what the device tells us */
-	if (residue) {
-		if (!(us-flags  US_FL_IGNORE_RESIDUE)) {
+if (residue  !(us-flags  US_FL_IGNORE_RESIDUE)) {
+
+/* Heuristically detect devices that generate bogus residues
+ * by seeing what happens with INQUIRY and READ CAPACITY
+ * commands.
+ */
+if (bcs-Status == US_BULK_STAT_OK 
+scsi_get_resid(srb) == 0 
+((srb-cmnd[0] == INQUIRY 
+transfer_length == 36) ||
+   (srb-cmnd[0] == READ_CAPACITY 
+transfer_length == 8))) {
+us-flags |= US_FL_IGNORE_RESIDUE;
+
+} else {
 			residue = min(residue, transfer_length);
 			scsi_set_resid(srb, max(scsi_get_resid(srb),
 			   (int) residue));


Bug#355883: Same problem here

2008-08-19 Thread Leandro Dorileo

Hi Adam

Adam Cécile (Le_Vert) wrote:

Bastian Blank a écrit :
  

On Tue, Aug 19, 2008 at 06:50:11PM +0200, Adam Cécile (Le_Vert) wrote:
  


I can confirm this bug 2.6.26-1-amd64 and a slightly modified rebuild of
the i386 flavour.
My usb stick is unusable.

  

I doubt that you see the same bug. Try #494800.
  


Check reply by Kumar Appaiah (20080812). He re-opened this bug against
kernel 2.6.26.
  
  


I noticed severity has been dropped from important to normal. Any
justification ?

  

Someone which is not submitter or maintainer changed it.

  


I'd rather say it's critical. Everybody needs usb sticks

  

No. Many of my machines don't even have usb.
  


No comment.
  

Bastian
  


I found the attached patch somewhere on lkml. It's targeted for kernel
2.6.27. I can confirm this patch fix the issue with my stick.
  
This patch hasn`t taken to Linus`s tree yet but has been queued by Greg 
K-H, guess we`ll see it merged until 2.6.27.




--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]