Bug#370347: Make etc/munin-node.conf automatically configurable
Tore Anderson wrote: * Luk Claes Automatically configuring etc/munin-node.conf is not policy compliant for the moment as one needs to edit a conffile. A solution might be to include some file if it exists in the configuration... or to add a debconf question... [...] Do you believe the default configuration file is sub-optimal in any way? If so, what should be changed, in your opinion? No, the default configuration is good, though it's only a default... If not (what you're trying to do would make sense only in Debian- Edu?), what exactly are you trying to do? You mention the possibility of adding a Debconf question, but you do not say what the question should be about. If I knew, maybe I could come up with another way to cater for your needs without making munin-node.conf a non-conffile or introducing Debconf scripts. In Debian-Edu one wants to add a line 'allow ^10\.0\.2\.2$' Cheers Luk -- Luk Claes - http://people.debian.org/~luk - GPG key 1024D/9B7C328D Fingerprint: D5AF 25FB 316B 53BB 08E7 F999 E544 DE07 9B7C 328D -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#370347: Make etc/munin-node.conf automatically configurable
* Luk Claes In Debian-Edu one wants to add a line 'allow ^10\.0\.2\.2$' I see. Well, that certainly doesn't belong in the default configuration file. I have a suggestion, though. What if I add the following code (or something similar) to /etc/init.d/munin-node: --- munin-node.init (revision 1134) +++ munin-node.init (working copy) @@ -43,6 +43,7 @@ } . /lib/lsb/init-functions +[ -r /etc/default/munin-node ] . /etc/default/munin-node if [ ! -x $DAEMON ]; then log_failure_msg Munin-Node appears to be uninstalled. @@ -86,7 +87,7 @@ log_end_msg 0 exit 0 fi - start_daemon -p $PIDFILE $DAEMON + start_daemon -p $PIDFILE $DAEMON $DAEMON_ARGS ret=$? # start_daemon() isn't thorough enough, ensure the daemon has been # started manually Then your package could include the file /etc/default/munin-node, containing «DAEMON_ARGS=--config /etc/debian-edu/munin-node.conf». This file could be shipped as a conffile, or you could copy the default munin-node.conf in the postinst and apply your changes to the copy. Does this sound like an acceptable solution to you? Regards -- Tore Anderson
Bug#370347: Make etc/munin-node.conf automatically configurable
* Luk Claes Automatically configuring etc/munin-node.conf is not policy compliant for the moment as one needs to edit a conffile. A solution might be to include some file if it exists in the configuration... or to add a debconf question... Hi Luk, and apologies for answering so late. It has recently dawned on me that Etch is drawing near and that I need to start working on my packages again now if I am to make the freeze. :-) Anyway, I'm not really sure how to respond to this bug. I kinda like the fact that munin-node.conf is a conffile. Personally I have a strong preference that packages should just shut up and work out of the box, and that Debconf is overused - way too many packages asking all sorts of questions that have perfectly reasonable defaults, a trend that is futher aggravated when sloppy maintainers use end up using Debconf as some carte blanche to nuke user configuration. Boy do I hate seeing a comment à la «this file is maintained by debconf» in my configuration files. Sorry, that turned into a rant, but as you probably understand I'm reluctant to deprive munin-node.conf of its conffile status, and even more reluctant to introduce Debconf scripts to generate it dynamically. Before doing so I want to have a very good reason. That said, I'd like to help you see your problem solved, but I'm not really sure what it is, exactly. So a few questions: Do you believe the default configuration file is sub-optimal in any way? If so, what should be changed, in your opinion? If not (what you're trying to do would make sense only in Debian- Edu?), what exactly are you trying to do? You mention the possibility of adding a Debconf question, but you do not say what the question should be about. If I knew, maybe I could come up with another way to cater for your needs without making munin-node.conf a non-conffile or introducing Debconf scripts. Oh and by the way, the munin-node.conf format is dictated by Net::Server, so support for an eventual «include» configuration directive has to be added there, not in Munin itself. Cheers -- Tore Anderson
Bug#370347: Make etc/munin-node.conf automatically configurable
Package: munin Severity: wishlist Hi Automatically configuring etc/munin-node.conf is not policy compliant for the moment as one needs to edit a conffile. A solution might be to include some file if it exists in the configuration... or to add a debconf question... Cheers Luk -- Luk Claes - http://people.debian.org/~luk - GPG key 1024D/9B7C328D Fingerprint: D5AF 25FB 316B 53BB 08E7 F999 E544 DE07 9B7C 328D signature.asc Description: PGP signature signature.asc Description: OpenPGP digital signature
