Bug#379796: dbconfig-common: Please support sqlite as a database type
tags 379796 pending thanks bts sean finney wrote: cool! could i nitpick and ask that they be called dbc_dbfile_foo, or something similar, just so that it's more clear what they are used for? Done since you and thijs are both reporting success with this now, go ahead and merge this into trunk and let's do a release. and done :) I look forward to seeing the release soon! -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
Thijs Kinkhorst wrote: On Thu, 2006-08-10 at 10:53 -0400, sean finney wrote: there are some hinting variables which you can use to specify the defaults. i believe they're dbc_generate_include_owner and dbc_generate_include_mode, though don't trust my memory. there should also be something like dbc_generate_include_args for even more control. Yes, but this is about the database that is created by sqlite, not the include file. Maybe we should have the same set of variables for any backend that creates a database file on the local filesystem, that performs the same chown / chmod like with the include file. New packages at http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ now have two variables dbc_owner and dbc_perms modeled off the dbc_generate_include_ versions to allow you to hint at the desired settings. Let me know how it goes. -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
hey matt, thijs, On Mon, Aug 14, 2006 at 06:47:14PM +1200, Matt Brown wrote: New packages at http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ now have two variables dbc_owner and dbc_perms modeled off the dbc_generate_include_ versions to allow you to hint at the desired settings. cool! could i nitpick and ask that they be called dbc_dbfile_foo, or something similar, just so that it's more clear what they are used for? since you and thijs are both reporting success with this now, go ahead and merge this into trunk and let's do a release. thanks, sean signature.asc Description: Digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
On Mon, 2006-08-14 at 18:47 +1200, Matt Brown wrote: Thijs Kinkhorst wrote: On Thu, 2006-08-10 at 10:53 -0400, sean finney wrote: there are some hinting variables which you can use to specify the defaults. i believe they're dbc_generate_include_owner and dbc_generate_include_mode, though don't trust my memory. there should also be something like dbc_generate_include_args for even more control. Yes, but this is about the database that is created by sqlite, not the include file. Maybe we should have the same set of variables for any backend that creates a database file on the local filesystem, that performs the same chown / chmod like with the include file. New packages at http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ now have two variables dbc_owner and dbc_perms modeled off the dbc_generate_include_ versions to allow you to hint at the desired settings. Let me know how it goes. It works just fine, thanks! The variable is not called dbc_perms but dbc_mode, however. It would be nice to put this as an example in the postinst of the sqlite example package, maybe commented out, but as a hint that this is possible. I think this is ready for release, at least from my point of view, great work! Thijs signature.asc Description: This is a digitally signed message part
Bug#379796: dbconfig-common: Please support sqlite as a database type
Hello Matt, Both errors were caused by a simple typo in the function that checked whether a database existed. I've also made a few other tidy ups and merged in the changes from trunk. I've built new packages (1.8.19~sqlite0) and put them at: http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ Would you have time to test them out with your package again? It would be much appreciated. Sure, thanks for the quick response. I've checked it out and it works good, except for the fact that the database is owned by root:root and filemode 0640. That makes it unreadable for my webapp. Would there be a way to specify the file owner to be www-data, or would I have to code that into the package scripts? One more tweak, you didn't add lintian overrides for the newly added example packages; it should be easy to add that to the existing debian/lintian file following the lines already there. Thanks for your work! I hope it can be incorporated soon. Thijs signature.asc Description: This is a digitally signed message part
Bug#379796: dbconfig-common: Please support sqlite as a database type
Thijs Kinkhorst wrote: Sure, thanks for the quick response. I've checked it out and it works good, except for the fact that the database is owned by root:root and filemode 0640. That makes it unreadable for my webapp. Would there be a way to specify the file owner to be www-data, or would I have to code that into the package scripts? See the following post (2nd point) for background. http://lists.alioth.debian.org/pipermail/dbconfig-common-devel/2006-June/000545.html So the answer is code it into your package scripts. I haven't really tested that we preserve permissions on upgrade, and I have a nasty feeling that we probably don't... I'll take a look at that. It would be nice to come up with some examples for how a packager should set custom permissions from their maintainer scripts. One more tweak, you didn't add lintian overrides for the newly added example packages; it should be easy to add that to the existing debian/lintian file following the lines already there. Will do. -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
hey guys, On Thu, Aug 10, 2006 at 10:06:02PM +1200, Matt Brown wrote: Thijs Kinkhorst wrote: Sure, thanks for the quick response. I've checked it out and it works good, except for the fact that the database is owned by root:root and filemode 0640. That makes it unreadable for my webapp. Would there be a way to specify the file owner to be www-data, or would I have to code that into the package scripts? there are some hinting variables which you can use to specify the defaults. i believe they're dbc_generate_include_owner and dbc_generate_include_mode, though don't trust my memory. there should also be something like dbc_generate_include_args for even more control. So the answer is code it into your package scripts. I haven't really tested that we preserve permissions on upgrade, and I have a nasty feeling that we probably don't... I'll take a look at that. i don't think we do... It would be nice to come up with some examples for how a packager should set custom permissions from their maintainer scripts. i think a packager shouldn't have to do more than the above, and anything else we should take care of ourselves. without thinking too hard i'd suggest that we modify d-g-i to check dpkg-statoverride for locally overriden permissions and not apply the permissions if such an override exists. sean -- signature.asc Description: Digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
On Thu, 2006-08-10 at 10:53 -0400, sean finney wrote: there are some hinting variables which you can use to specify the defaults. i believe they're dbc_generate_include_owner and dbc_generate_include_mode, though don't trust my memory. there should also be something like dbc_generate_include_args for even more control. Yes, but this is about the database that is created by sqlite, not the include file. Maybe we should have the same set of variables for any backend that creates a database file on the local filesystem, that performs the same chown / chmod like with the include file. Thijs signature.asc Description: This is a digitally signed message part
Bug#379796: dbconfig-common: Please support sqlite as a database type
sean finney wrote: oh, sorry, brain fart. yes, i think there should be something similar for that, but i don't think it's there currently. so then there are two issues :) There was but it was implemented as the debconf question rather than hints from the maintainer file. I'll add it back in without the debconf questions in a similar format to how the dbconfig-generate-include permissions are handled. Cheers -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
On Thu, Aug 10, 2006 at 06:54:05PM +0200, Thijs Kinkhorst wrote: Yes, but this is about the database that is created by sqlite, not the include file. Maybe we should have the same set of variables for any backend that creates a database file on the local filesystem, that performs the same chown / chmod like with the include file. oh, sorry, brain fart. yes, i think there should be something similar for that, but i don't think it's there currently. so then there are two issues :) sean signature.asc Description: Digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
Hi Thijs, Thijs Kinkhorst wrote: I've done so on a new package of mine. It took a while to get it working, because as it seems sqlite is very picky (or even buggy) on SQL syntax. I've now transformed my inserts into a format that all database types will accept. Thanks for helping out with the testing :) What I noticed: * Purge does not purge the database, and is very noisy. snip * Install outputs a strange notice. snip Both errors were caused by a simple typo in the function that checked whether a database existed. I've also made a few other tidy ups and merged in the changes from trunk. I've built new packages (1.8.19~sqlite0) and put them at: http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ Would you have time to test them out with your package again? It would be much appreciated. It works but it the verify reports that it failed. Otherwise, it works just fine! I hope it can be included in dbconfig-common 'release' soon. I'm planning to get my PHPwiki package working with it to test the migration features, once that's done I'll merge the changes into the trunk and then sean can make a new release when he's ready. Hopefully I'll have all that done by the end of the weekend at the latest. Cheers -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
Hello Matt, Sean, On Fri, 2006-07-28 at 22:16 +1200, Matt Brown wrote: I've built a package based on the current state of the branch and placed it at: http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ Feel free to use it for testing. I've done so on a new package of mine. It took a while to get it working, because as it seems sqlite is very picky (or even buggy) on SQL syntax. I've now transformed my inserts into a format that all database types will accept. What I noticed: * Purge does not purge the database, and is very noisy. When choosing to purge, I get: dbconfig-common: dumping sqlite database serendipity to /var/tmp/serendipity.serendipity.2006-08-06-19.23.sqlite.d13582. BEGIN TRANSACTION; [... LOTS of sql output ...] COMMIT; dbconfig-common: dropping sqlite database serendipity. dropping database serendipity: database does not exist. dbconfig-common: revoking privileges for user on serendipity. Purging configuration files for serendipity ... However, after that the database is not purged at all: ls -l /var/lib/dbconfig-common/serendipity -rw-r--r-- 1 root root 94208 Aug 6 19:23 serendipity * Install outputs a strange notice. Creating config file /etc/serendipity/database.inc.php with new version creating database serendipity: success. verifying database serendipity exists: failed. populating database via sql... done. It works but it the verify reports that it failed. Otherwise, it works just fine! I hope it can be included in dbconfig-common 'release' soon. Thijs signature.asc Description: This is a digitally signed message part
Bug#379796: dbconfig-common: Please support sqlite as a database type
sean finney wrote: if there are 2 or 3 packages that can already make use of it, i suggest that we do the following: Sounds like a good plan to me. - build yourself a dbconfig package from the sqlite branch - set up your sqlite-using package to use dbconfig I've built a package based on the current state of the branch and placed it at: http://www.mattb.net.nz/debian/dists/sid/main/source/admin/ Feel free to use it for testing. - after you can verify there are no apparent problems with install/reconfigure/remove/purge actions for all 2 or 3 packages, we go ahead and merge the sqlite branch, and upload it. Hopefully I'll be able to report on how it goes with PHPwiki after the weekend. Cheers -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
hi guys, On Wed, Jul 26, 2006 at 06:37:21PM +0200, Thijs Kinkhorst wrote: It just waiting on a bit more testing before I prompt sean again to get it into the proper release. That's good news - I'll check it out soon. If it works then I suggest to merge it into dbconfig-common soon, I can also use it in two different packages already. And it would be quite on time for etch to get enough testing. if there are 2 or 3 packages that can already make use of it, i suggest that we do the following: - build yourself a dbconfig package from the sqlite branch - set up your sqlite-using package to use dbconfig - after you can verify there are no apparent problems with install/reconfigure/remove/purge actions for all 2 or 3 packages, we go ahead and merge the sqlite branch, and upload it. - we let testing/unstable users let us know if there are any problems we missed :) we should get started on this sooner rather than later, so let me know when the first two steps are done and i'll work with matt to get the code merged in. sean -- signature.asc Description: Digital signature
Bug#379796: dbconfig-common: Please support sqlite as a database type
On Wed, 2006-07-26 at 09:41 +1200, Matt Brown wrote: I've recently added SQLite support to dbconfig-common because I need it for the phpwiki package. It's in the svn repository in a branch called sqlite http://svn.debian.org/wsvn/dbconfig-common/branches/sqlite/?rev=0sc=0 It just waiting on a bit more testing before I prompt sean again to get it into the proper release. That's good news - I'll check it out soon. If it works then I suggest to merge it into dbconfig-common soon, I can also use it in two different packages already. And it would be quite on time for etch to get enough testing. Thijs signature.asc Description: This is a digitally signed message part
Bug#379796: dbconfig-common: Please support sqlite as a database type
Package: dbconfig-common Version: 1.8.17 Severity: wishlist Hello Sean, I see that you've mentioned this already in your TODO file in the package, but I'd like to register still that we (the phpgedview maintainers) would appreciate to see sqlite support in dbconfig-common. Since sqlite operation is currently our default modus operandi this is a blocker for us to use dbconfig-common for the package. thanks, Thijs signature.asc Description: This is a digitally signed message part
Bug#379796: dbconfig-common: Please support sqlite as a database type
tag 379796 + patch thanks Hi Thijs, Thijs Kinkhorst wrote: I see that you've mentioned this already in your TODO file in the package, but I'd like to register still that we (the phpgedview maintainers) would appreciate to see sqlite support in dbconfig-common. Since sqlite operation is currently our default modus operandi this is a blocker for us to use dbconfig-common for the package. I've recently added SQLite support to dbconfig-common because I need it for the phpwiki package. It's in the svn repository in a branch called sqlite http://svn.debian.org/wsvn/dbconfig-common/branches/sqlite/?rev=0sc=0 It just waiting on a bit more testing before I prompt sean again to get it into the proper release. Cheers -- Matt Brown [EMAIL PROTECTED] Mob +64 21 611 544 www.mattb.net.nz signature.asc Description: OpenPGP digital signature
