Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-13 Thread Sam Hocevar
On Thu, Oct 12, 2006, Steve Langasek wrote:

 It was mere code checking. I assumed that since /usr/local was the
  administrator's sandbox, one could assume anything could be found there
  and did not bother looking at old versions of console-common. I agree
  that the code might never be triggered in real life, though.
 
 Downgrading as such.

  Uh? a package must not rely on the presence or absence of files or
directories in `/usr/local' for normal operation. It seems to me that
console-common relies on old files no longer being present in order not
to fail.

-- 
Sam.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-12 Thread Christian Perrier
Quoting Sam Hocevar (Debian packages) ([EMAIL PROTECTED]):
 Package: console-common
 Version: 0.7.62
 Severity: serious
 Justification: Policy 9.1.2
 
 Quoting policy 9.1.2:
  Since `/usr/local' can be mounted read-only from a remote server,
  these directories must be created and removed by the `postinst' and
  `prerm' maintainer scripts and not be included in the `.deb' archive.
  These scripts must not fail if either of these operations fail.
 
 postinst is set -e and tries to move files in /usr/local without handling
 errors.


Alastair, trying to fix that one, I risk writing bad shell script.

Can you try working on it ?




signature.asc
Description: Digital signature


Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-12 Thread Alastair McKinstry
On 10/12/06, Christian Perrier [EMAIL PROTECTED] wrote:
Quoting Sam Hocevar (Debian packages) ([EMAIL PROTECTED]): Package: console-common Version: 0.7.62 Severity: serious Justification: Policy 9.1.2
 QAlastair, trying to fix that one, I risk writing bad shell script.Can you try working on it?Christian,Yes, I'll do a fix today. I'm a bit hampered by broken DSL at home, so I have to set up a chroot to work 
in here at work. It has been impeding my Debian work for the last two weeks (until yesterday DSL wasjust not working in the evenings. Now it is broken totally: hence mail breakages recently, I think.Unfortunately I have little choice in Broadband providers, living in rural Ireland (ie. 10 km from a city ...)
RegardsAlastair-BEGIN PGP SIGNATURE-Version: GnuPG 
v1.4.5 (GNU/Linux)iD8DBQFFLdqR1OXtrMAUPS0RAmbgAJ4/PagxaJpVn4Fb3PdrF/Mde/UhjgCfSizpbR146gwjDbT2phH/xopmqyk==RA8f-END PGP SIGNATURE-


Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-12 Thread Sam Hocevar
On Thu, Oct 12, 2006, Alastair McKinstry wrote:

Did you actually manage to get to trigger these bugs, or did you find them
by code checking?

   It was mere code checking. I assumed that since /usr/local was the
administrator's sandbox, one could assume anything could be found there
and did not bother looking at old versions of console-common. I agree
that the code might never be triggered in real life, though.

-- 
Sam.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-12 Thread Alastair McKinstry
On 10/12/06, Sam Hocevar (Debian packages) [EMAIL PROTECTED] wrote:
Package: console-commonVersion: 0.7.62Severity: seriousJustification: Policy 9.1.2Quoting policy 9.1.2: Since `/usr/local' can be mounted read-only from a remote server, these directories must be created and removed by the `postinst' and
 `prerm' maintainer scripts and not be included in the `.deb' archive. These scripts must not fail if either of these operations fail.postinst is set -e and tries to move files in /usr/local without handling
errors.Hmm,Did you actually manage to get to trigger these bugs, or did you find them by code checking?While I agree these are bugs (and will fix them), I am having a hard time triggering them via upgrade, etc.:
I think the code paths are only followed if handling legacy directories that are no longer present in sarge, ie. upgrading via an unsupported configuration. If you triggered them In Real Life, i'd like to see the
scenario so I could properly test it.RegardsAlastair-- System Information:
Debian Release: testing/unstableAPT prefers unstableAPT policy: (500, 'unstable'), (50, 'experimental')Architecture: i386 (i686)Shell:/bin/sh linked to /bin/bashKernel: Linux 
2.6.17.11Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)


Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-12 Thread Alastair McKinstry
On 10/12/06, Sam Hocevar [EMAIL PROTECTED] wrote:
On Thu, Oct 12, 2006, Alastair McKinstry wrote:Did you actually manage to get to trigger these bugs, or did you find themby code checking? It was mere code checking. I assumed that since /usr/local was the
administrator's sandbox, one could assume anything could be found thereand did not bother looking at old versions of console-common. I agreethat the code might never be triggered in real life, though.
Ok, I have a fix that I am working on and will try to upload today.RegardsAlastair
--Sam.


Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-12 Thread Steve Langasek
severity 392508 important
thanks

On Thu, Oct 12, 2006 at 02:38:26PM +0200, Sam Hocevar wrote:
 On Thu, Oct 12, 2006, Alastair McKinstry wrote:

 Did you actually manage to get to trigger these bugs, or did you find 
  them
 by code checking?

It was mere code checking. I assumed that since /usr/local was the
 administrator's sandbox, one could assume anything could be found there
 and did not bother looking at old versions of console-common. I agree
 that the code might never be triggered in real life, though.

Downgrading as such.

Thanks,
-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
[EMAIL PROTECTED]   http://www.debian.org/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#392508: console-common: installation fails if /usr/local is mounted read-only

2006-10-11 Thread Sam Hocevar (Debian packages)
Package: console-common
Version: 0.7.62
Severity: serious
Justification: Policy 9.1.2

Quoting policy 9.1.2:
 Since `/usr/local' can be mounted read-only from a remote server,
 these directories must be created and removed by the `postinst' and
 `prerm' maintainer scripts and not be included in the `.deb' archive.
 These scripts must not fail if either of these operations fail.

postinst is set -e and tries to move files in /usr/local without handling
errors.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (50, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17.11
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]